mbox series

[for-next,0/6] Fix extra/redundant copies

Message ID 20210618045742.204195-1-rpearsonhpe@gmail.com (mailing list archive)
Headers show
Series Fix extra/redundant copies | expand

Message

Bob Pearson June 18, 2021, 4:57 a.m. UTC
This series of patches removes or shortens several unneeded passes over
packet data.

Applies cleanly to for-next after the memory windows commits.

Signed-off-by: Bob Pearson <rpearsonhpe@gmail.com>
---

Bob Pearson (6):
  RDMA/rxe: Fix useless copy in send_atomic_ack
  RDMA/rxe: Fix redundant call to ip_send_check
  RDMA/rxe: Fix extra copies in build_rdma_network_hdr
  RDMA/rxe: Fix over copying in get_srq_wqe
  RDMA/rxe: Fix extra copy in prepare_ack_packet
  RDMA/rxe: Fix redundant skb_put_zero

 drivers/infiniband/sw/rxe/rxe_net.c  |  4 +-
 drivers/infiniband/sw/rxe/rxe_resp.c | 56 ++++++++++++----------------
 2 files changed, 24 insertions(+), 36 deletions(-)

Comments

Jason Gunthorpe June 22, 2021, 6:40 p.m. UTC | #1
On Thu, Jun 17, 2021 at 11:57:37PM -0500, Bob Pearson wrote:
> This series of patches removes or shortens several unneeded passes over
> packet data.
> 
> Applies cleanly to for-next after the memory windows commits.
> 
> Signed-off-by: Bob Pearson <rpearsonhpe@gmail.com>
> 
> Bob Pearson (6):
>   RDMA/rxe: Fix useless copy in send_atomic_ack
>   RDMA/rxe: Fix redundant call to ip_send_check
>   RDMA/rxe: Fix extra copies in build_rdma_network_hdr
>   RDMA/rxe: Fix over copying in get_srq_wqe
>   RDMA/rxe: Fix extra copy in prepare_ack_packet
>   RDMA/rxe: Fix redundant skb_put_zero

I'm inclined to agree with Bob that the network fast path should not
rely on pre-zeroing but each written header should zero or write valid
data as it goes, for performance

So applied to for-next, thanks

Jason