mbox series

[v3,0/4] Generate UDP src port with flow label or lqpn/rqpn

Message ID 20220106180359.2915060-1-yanjun.zhu@linux.dev (mailing list archive)
Headers show
Series Generate UDP src port with flow label or lqpn/rqpn | expand

Message

Zhu Yanjun Jan. 6, 2022, 6:03 p.m. UTC
From: Zhu Yanjun <yanjun.zhu@linux.dev>

Follow the advice from Leon Romanovsky, rdma_get_udp_sport is moved to
ib_verbs.h. several drivers generate udp source port with this function.

---
v2->v3:Because in-subnet communications, GRH is optional. Without thei
       randomization for src_port done in rxe_qp_init_req, udp source
       port will be 0xC000 in that case.
v1->v2:Remove the local variables in commits "RDMA/irdma: Make the source
       udp port vary" and "RDMA/rxe: Use the standard method to produce
       udp source port". A new commit is added to remove the redundant
       randomization for UDP source port in RXE.
---



Zhu Yanjun (4):
  RDMA/core: Calculate UDP source port based on flow label or lqpn/rqpn
  RDMA/hns: Replace get_udp_sport with rdma_get_udp_sport
  RDMA/irdma: Make the source udp port vary
  RDMA/rxe: Use the standard method to produce udp source port

 drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 12 ++----------
 drivers/infiniband/hw/irdma/verbs.c        |  4 ++++
 drivers/infiniband/sw/rxe/rxe_verbs.c      |  6 ++++++
 include/rdma/ib_verbs.h                    | 17 +++++++++++++++++
 4 files changed, 29 insertions(+), 10 deletions(-)

Comments

Jason Gunthorpe Jan. 7, 2022, 11:39 p.m. UTC | #1
On Thu, Jan 06, 2022 at 01:03:55PM -0500, yanjun.zhu@linux.dev wrote:
> From: Zhu Yanjun <yanjun.zhu@linux.dev>
> 
> Follow the advice from Leon Romanovsky, rdma_get_udp_sport is moved to
> ib_verbs.h. several drivers generate udp source port with this function.
> 
> ---
> v2->v3:Because in-subnet communications, GRH is optional. Without thei
>        randomization for src_port done in rxe_qp_init_req, udp source
>        port will be 0xC000 in that case.
> v1->v2:Remove the local variables in commits "RDMA/irdma: Make the source
>        udp port vary" and "RDMA/rxe: Use the standard method to produce
>        udp source port". A new commit is added to remove the redundant
>        randomization for UDP source port in RXE.
> ---
> 
> 
> 
> Zhu Yanjun (4):
>   RDMA/core: Calculate UDP source port based on flow label or lqpn/rqpn
>   RDMA/hns: Replace get_udp_sport with rdma_get_udp_sport
>   RDMA/irdma: Make the source udp port vary
>   RDMA/rxe: Use the standard method to produce udp source port

Applied to for-next, thanks

Jason