mbox series

[PATCHv2,0/3] Use net_type to check network type

Message ID 20220223024252.3873736-1-yanjun.zhu@linux.dev (mailing list archive)
Headers show
Series Use net_type to check network type | expand

Message

Zhu Yanjun Feb. 23, 2022, 2:42 a.m. UTC
From: Zhu Yanjun <yanjun.zhu@linux.dev>

The member variable net_type already exists. Now it is used
to check network type. As such, the variable saddr is redundant.
So it is removed.

The union irdma_sockaddr is used in several functions. So it is
moved into header file.

Zhu Yanjun (3):
  RDMA/irdma: Use net_type to check network type
  RDMA/irdma: Remove the unnecessary variable saddr
  RDMA/irdma: Move union irdma_sockaddr to header file

 drivers/infiniband/hw/irdma/verbs.c | 26 ++++++--------------------
 drivers/infiniband/hw/irdma/verbs.h | 12 +++++++-----
 2 files changed, 13 insertions(+), 25 deletions(-)

--
V1-->V2: Modify the commit log.

Comments

Shiraz Saleem Feb. 22, 2022, 3 p.m. UTC | #1
> Subject: [PATCHv2 0/3] Use net_type to check network type
> 
> From: Zhu Yanjun <yanjun.zhu@linux.dev>
> 
> The member variable net_type already exists. Now it is used to check network
> type. As such, the variable saddr is redundant.
> So it is removed.
> 
> The union irdma_sockaddr is used in several functions. So it is moved into header
> file.
> 
> Zhu Yanjun (3):
>   RDMA/irdma: Use net_type to check network type
>   RDMA/irdma: Remove the unnecessary variable saddr
>   RDMA/irdma: Move union irdma_sockaddr to header file
> 
>  drivers/infiniband/hw/irdma/verbs.c | 26 ++++++--------------------
> drivers/infiniband/hw/irdma/verbs.h | 12 +++++++-----
>  2 files changed, 13 insertions(+), 25 deletions(-)
> 
> --
> V1-->V2: Modify the commit log.

Thanks for the clean up.

Acked-by: Shiraz Saleem <shiraz.saleem@intel.com>
Jason Gunthorpe Feb. 24, 2022, 12:40 a.m. UTC | #2
On Tue, Feb 22, 2022 at 09:42:49PM -0500, yanjun.zhu@linux.dev wrote:
> From: Zhu Yanjun <yanjun.zhu@linux.dev>
> 
> The member variable net_type already exists. Now it is used
> to check network type. As such, the variable saddr is redundant.
> So it is removed.
> 
> The union irdma_sockaddr is used in several functions. So it is
> moved into header file.
> 
> Zhu Yanjun (3):
>   RDMA/irdma: Use net_type to check network type
>   RDMA/irdma: Remove the unnecessary variable saddr
>   RDMA/irdma: Move union irdma_sockaddr to header file

Applied to for-next, thanks

Jason