| Message ID | 20220606143836.3323-1-rpearsonhpe@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Fix incorrect atomic retry behavior | expand |
On Mon, Jun 06, 2022 at 09:38:32AM -0500, Bob Pearson wrote: > Restructure the design of the atomic retries in rxe_resp.c modeled > on the design of RDMA read reply. This fixes failures which > occur when an atomic ack packet is lost as observed in the > pyverbs test suite with a patch to randomly drop packets. Applied to for-next Thanks, Jason
On 6/30/22 13:52, Jason Gunthorpe wrote: > On Mon, Jun 06, 2022 at 09:38:32AM -0500, Bob Pearson wrote: >> Restructure the design of the atomic retries in rxe_resp.c modeled >> on the design of RDMA read reply. This fixes failures which >> occur when an atomic ack packet is lost as observed in the >> pyverbs test suite with a patch to randomly drop packets. > > Applied to for-next > > Thanks, > Jason Thanks. I think this will commute with the other fixes I just sent. If it doesn't I can rebase them. Bob
Restructure the design of the atomic retries in rxe_resp.c modeled on the design of RDMA read reply. This fixes failures which occur when an atomic ack packet is lost as observed in the pyverbs test suite with a patch to randomly drop packets. Link: https://lore.kernel.org/linux-rdma/84aaf934-9cac-30ae-0fa5-1e40819a519e@gmail.com/ Signed-off-by: Bob Pearson <rpearsonhpe@gmail.com> --- Bob Pearson (5): RDMA/rxe: Move code to rxe_prepare_atomic_res() RDMA/rxe: Add a responder state for atomic reply RDMA/rxe: Move atomic responder res to atomic_reply RDMA/rxe: Move atomic original value to res RDMA/rxe: Merge normal and retry atomic flows drivers/infiniband/sw/rxe/rxe_qp.c | 2 - drivers/infiniband/sw/rxe/rxe_resp.c | 132 ++++++++++++++++---------- drivers/infiniband/sw/rxe/rxe_verbs.h | 3 +- 3 files changed, 81 insertions(+), 56 deletions(-) base-commit: f2906aa863381afb0015a9eb7fefad885d4e5a56