[v3,net,0/4] Do not use RT_TOS for IPv6 flowlabel

Message

Matthias May Aug. 5, 2022, 7:19 p.m. UTC

According to Guillaume Nault RT_TOS should never be used for IPv6.

Quote:
RT_TOS() is an old macro used to interprete IPv4 TOS as described in
the obsolete RFC 1349. It's conceptually wrong to use it even in IPv4
code, although, given the current state of the code, most of the
existing calls have no consequence.

But using RT_TOS() in IPv6 code is always a bug: IPv6 never had a "TOS"
field to be interpreted the RFC 1349 way. There's no historical
compatibility to worry about.

---
v1 -> v2:
 - Fix spacing of "Fixes" tag.
 - Add missing CCs
v2 -> v3:
 - Add the info from the cover to the actual patch message (Guillaume Nault)

Matthias May (4):
  geneve: do not use RT_TOS for IPv6 flowlabel
  vxlan: do not use RT_TOS for IPv6 flowlabel
  mlx5: do not use RT_TOS for IPv6 flowlabel
  ipv6: do not use RT_TOS for IPv6 flowlabel

 drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.c | 4 ++--
 drivers/net/geneve.c                                | 3 +--
 drivers/net/vxlan/vxlan_core.c                      | 2 +-
 net/ipv6/ip6_output.c                               | 3 +--
 4 files changed, 5 insertions(+), 7 deletions(-)

Comments

[e-mail] Aug. 10, 2022, 5:30 a.m. UTC | #1

Hello:

This series was applied to netdev/net.git (master)
by Jakub Kicinski <[e-mail]>:

On Fri, 5 Aug 2022 21:19:02 +0200 you wrote:
> According to Guillaume Nault RT_TOS should never be used for IPv6.
> 
> Quote:
> RT_TOS() is an old macro used to interprete IPv4 TOS as described in
> the obsolete RFC 1349. It's conceptually wrong to use it even in IPv4
> code, although, given the current state of the code, most of the
> existing calls have no consequence.
> 
> [...]

Here is the summary with links:
  - [v3,net,1/4] geneve: do not use RT_TOS for IPv6 flowlabel
    https://git.kernel.org/netdev/net/c/ca2bb69514a8
  - [v3,net,2/4] vxlan: do not use RT_TOS for IPv6 flowlabel
    https://git.kernel.org/netdev/net/c/e488d4f5d6e4
  - [v3,net,3/4] mlx5: do not use RT_TOS for IPv6 flowlabel
    https://git.kernel.org/netdev/net/c/bcb0da7fffee
  - [v3,net,4/4] ipv6: do not use RT_TOS for IPv6 flowlabel
    https://git.kernel.org/netdev/net/c/ab7e2e0dfa5d

You are awesome, thank you!