| Message ID | 20220902101922.26273-1-guoqing.jiang@linux.dev (mailing list archive) |
|---|---|
| Headers | show |
| Series | misc changes for rtrs | expand |
On Fri, Sep 02, 2022 at 06:19:19PM +0800, Guoqing Jiang wrote: > Hi, > > Pls review the three patches. > > Thanks, > Guoqing > > Guoqing Jiang (3): > RDMA/rtrs: Update comments for MAX_SESS_QUEUE_DEPTH > RDMA/rtrs-clt: Break the loop once one path is connected > RDMA/rtrs-clt: Kill xchg_paths > > drivers/infiniband/ulp/rtrs/rtrs-clt.c | 18 +++++------------- > drivers/infiniband/ulp/rtrs/rtrs-pri.h | 7 +++---- > 2 files changed, 8 insertions(+), 17 deletions(-) The third patch still generates warnings. ➜ kernel git:(wip/leon-for-next) mkt ci ^[[A^[[A^[[Ad9b137e23d31 (HEAD -> build) RDMA/rtrs-clt: Kill xchg_paths WARNING: line length of 81 exceeds 80 columns #43: FILE: drivers/infiniband/ulp/rtrs/rtrs-clt.c:2297: + if (try_cmpxchg((typeof(ppcpu_path))ppcpu_path, &clt_path, next)) drivers/infiniband/ulp/rtrs/rtrs-clt.c:2297:21: warning: incorrect type in initializer (different address spaces) drivers/infiniband/ulp/rtrs/rtrs-clt.c:2297:21: expected struct rtrs_clt_path [noderef] __rcu *__new drivers/infiniband/ulp/rtrs/rtrs-clt.c:2297:21: got struct rtrs_clt_path *[assigned] next > > -- > 2.31.1 >
Hi Leon, On 9/5/22 8:28 PM, Leon Romanovsky wrote: > On Fri, Sep 02, 2022 at 06:19:19PM +0800, Guoqing Jiang wrote: >> Hi, >> >> Pls review the three patches. >> >> Thanks, >> Guoqing >> >> Guoqing Jiang (3): >> RDMA/rtrs: Update comments for MAX_SESS_QUEUE_DEPTH >> RDMA/rtrs-clt: Break the loop once one path is connected >> RDMA/rtrs-clt: Kill xchg_paths >> >> drivers/infiniband/ulp/rtrs/rtrs-clt.c | 18 +++++------------- >> drivers/infiniband/ulp/rtrs/rtrs-pri.h | 7 +++---- >> 2 files changed, 8 insertions(+), 17 deletions(-) > The third patch still generates warnings. Sorry, I didn't run sparse check,
On Tue, Sep 06, 2022 at 03:04:50PM +0800, Guoqing Jiang wrote: > Hi Leon, > > On 9/5/22 8:28 PM, Leon Romanovsky wrote: > > On Fri, Sep 02, 2022 at 06:19:19PM +0800, Guoqing Jiang wrote: > > > Hi, > > > > > > Pls review the three patches. > > > > > > Thanks, > > > Guoqing > > > > > > Guoqing Jiang (3): > > > RDMA/rtrs: Update comments for MAX_SESS_QUEUE_DEPTH > > > RDMA/rtrs-clt: Break the loop once one path is connected > > > RDMA/rtrs-clt: Kill xchg_paths > > > > > > drivers/infiniband/ulp/rtrs/rtrs-clt.c | 18 +++++------------- > > > drivers/infiniband/ulp/rtrs/rtrs-pri.h | 7 +++---- > > > 2 files changed, 8 insertions(+), 17 deletions(-) > > The third patch still generates warnings. > > Sorry, I didn't run sparse check,
On Tue, Sep 6, 2022 at 1:13 PM Leon Romanovsky <leon@kernel.org> wrote: > > On Tue, Sep 06, 2022 at 03:04:50PM +0800, Guoqing Jiang wrote: > > Hi Leon, > > > > On 9/5/22 8:28 PM, Leon Romanovsky wrote: > > > On Fri, Sep 02, 2022 at 06:19:19PM +0800, Guoqing Jiang wrote: > > > > Hi, > > > > > > > > Pls review the three patches. > > > > > > > > Thanks, > > > > Guoqing > > > > > > > > Guoqing Jiang (3): > > > > RDMA/rtrs: Update comments for MAX_SESS_QUEUE_DEPTH > > > > RDMA/rtrs-clt: Break the loop once one path is connected > > > > RDMA/rtrs-clt: Kill xchg_paths > > > > > > > > drivers/infiniband/ulp/rtrs/rtrs-clt.c | 18 +++++------------- > > > > drivers/infiniband/ulp/rtrs/rtrs-pri.h | 7 +++---- > > > > 2 files changed, 8 insertions(+), 17 deletions(-) > > > The third patch still generates warnings. > > > > Sorry, I didn't run sparse check,