mbox series

[RFC,00/12] Misc changes for rtrs

Message ID 20221113010823.6436-1-guoqing.jiang@linux.dev (mailing list archive)
Headers show
Series Misc changes for rtrs | expand

Message

Guoqing Jiang Nov. 13, 2022, 1:08 a.m. UTC
Hi,

Here are some changes for rtrs, please review them.

Thanks,
Guoqing

Guoqing Jiang (12):
  RDMA/rtrs-srv: Remove ib_dev_count from rtrs_srv_ib_ctx
  RDMA/rtrs-srv: Refactor rtrs_srv_rdma_cm_handler
  RDMA/rtrs-srv: Only close srv_path if it is just allocated
  RDMA/rtrs-srv: refactor the handling of failure case in map_cont_bufs
  RDMA/rtrs-srv: Correct the checking of ib_map_mr_sg
  RDMA/rtrs-clt: Correct the checking of ib_map_mr_sg
  RDMA/rtrs-srv: Remove outdated comments from create_con
  RDMA/rtrs: Kill recon_cnt from several structs
  RDMA/rtrs: Clean up rtrs_rdma_dev_pd_ops
  RDMA/rtrs-srv: Remove paths_num
  RDMA/rtrs-srv: fix several issues in rtrs_srv_destroy_path_files
  RDMA/rtrs-srv: Remove kobject_del from
    rtrs_srv_destroy_once_sysfs_root_folders

 drivers/infiniband/ulp/rtrs/rtrs-clt.c       |  12 +-
 drivers/infiniband/ulp/rtrs/rtrs-pri.h       |   6 -
 drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c |  13 ++-
 drivers/infiniband/ulp/rtrs/rtrs-srv.c       | 110 ++++++-------------
 drivers/infiniband/ulp/rtrs/rtrs-srv.h       |   2 -
 drivers/infiniband/ulp/rtrs/rtrs.c           |  22 +---
 6 files changed, 47 insertions(+), 118 deletions(-)

Comments

Leon Romanovsky Nov. 14, 2022, 8:32 a.m. UTC | #1
On Sun, Nov 13, 2022 at 09:08:11AM +0800, Guoqing Jiang wrote:
> Hi,
> 
> Here are some changes for rtrs, please review them.
> 
> Thanks,
> Guoqing
> 
> Guoqing Jiang (12):
>   RDMA/rtrs-srv: Remove ib_dev_count from rtrs_srv_ib_ctx
>   RDMA/rtrs-srv: Refactor rtrs_srv_rdma_cm_handler
>   RDMA/rtrs-srv: Only close srv_path if it is just allocated
>   RDMA/rtrs-srv: refactor the handling of failure case in map_cont_bufs
>   RDMA/rtrs-srv: Correct the checking of ib_map_mr_sg
>   RDMA/rtrs-clt: Correct the checking of ib_map_mr_sg
>   RDMA/rtrs-srv: Remove outdated comments from create_con
>   RDMA/rtrs: Kill recon_cnt from several structs
>   RDMA/rtrs: Clean up rtrs_rdma_dev_pd_ops
>   RDMA/rtrs-srv: Remove paths_num
>   RDMA/rtrs-srv: fix several issues in rtrs_srv_destroy_path_files
>   RDMA/rtrs-srv: Remove kobject_del from
>     rtrs_srv_destroy_once_sysfs_root_folders
> 
>  drivers/infiniband/ulp/rtrs/rtrs-clt.c       |  12 +-
>  drivers/infiniband/ulp/rtrs/rtrs-pri.h       |   6 -
>  drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c |  13 ++-
>  drivers/infiniband/ulp/rtrs/rtrs-srv.c       | 110 ++++++-------------
>  drivers/infiniband/ulp/rtrs/rtrs-srv.h       |   2 -
>  drivers/infiniband/ulp/rtrs/rtrs.c           |  22 +---
>  6 files changed, 47 insertions(+), 118 deletions(-)

Why is this series marked as RFC?

Thanks

> 
> -- 
> 2.31.1
>
Guoqing Jiang Nov. 14, 2022, 8:46 a.m. UTC | #2
On 11/14/22 4:32 PM, Leon Romanovsky wrote:
> On Sun, Nov 13, 2022 at 09:08:11AM +0800, Guoqing Jiang wrote:
>> Hi,
>>
>> Here are some changes for rtrs, please review them.
>>
>> Thanks,
>> Guoqing
>>
>> Guoqing Jiang (12):
>>    RDMA/rtrs-srv: Remove ib_dev_count from rtrs_srv_ib_ctx
>>    RDMA/rtrs-srv: Refactor rtrs_srv_rdma_cm_handler
>>    RDMA/rtrs-srv: Only close srv_path if it is just allocated
>>    RDMA/rtrs-srv: refactor the handling of failure case in map_cont_bufs
>>    RDMA/rtrs-srv: Correct the checking of ib_map_mr_sg
>>    RDMA/rtrs-clt: Correct the checking of ib_map_mr_sg
>>    RDMA/rtrs-srv: Remove outdated comments from create_con
>>    RDMA/rtrs: Kill recon_cnt from several structs
>>    RDMA/rtrs: Clean up rtrs_rdma_dev_pd_ops
>>    RDMA/rtrs-srv: Remove paths_num
>>    RDMA/rtrs-srv: fix several issues in rtrs_srv_destroy_path_files
>>    RDMA/rtrs-srv: Remove kobject_del from
>>      rtrs_srv_destroy_once_sysfs_root_folders
>>
>>   drivers/infiniband/ulp/rtrs/rtrs-clt.c       |  12 +-
>>   drivers/infiniband/ulp/rtrs/rtrs-pri.h       |   6 -
>>   drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c |  13 ++-
>>   drivers/infiniband/ulp/rtrs/rtrs-srv.c       | 110 ++++++-------------
>>   drivers/infiniband/ulp/rtrs/rtrs-srv.h       |   2 -
>>   drivers/infiniband/ulp/rtrs/rtrs.c           |  22 +---
>>   6 files changed, 47 insertions(+), 118 deletions(-)
> Why is this series marked as RFC?

Because I am not quite sure about some of them, and there is no rush for
the series.

Thanks,
Guoqing
Leon Romanovsky Nov. 17, 2022, 9:52 a.m. UTC | #3
On Sun, Nov 13, 2022 at 09:08:11AM +0800, Guoqing Jiang wrote:
> Hi,
> 
> Here are some changes for rtrs, please review them.
> 
> Thanks,
> Guoqing
> 
> Guoqing Jiang (12):
>   RDMA/rtrs-srv: Remove ib_dev_count from rtrs_srv_ib_ctx
>   RDMA/rtrs-srv: Refactor rtrs_srv_rdma_cm_handler
>   RDMA/rtrs-srv: Only close srv_path if it is just allocated
>   RDMA/rtrs-srv: refactor the handling of failure case in map_cont_bufs
>   RDMA/rtrs-srv: Correct the checking of ib_map_mr_sg
>   RDMA/rtrs-clt: Correct the checking of ib_map_mr_sg
>   RDMA/rtrs-srv: Remove outdated comments from create_con
>   RDMA/rtrs: Kill recon_cnt from several structs
>   RDMA/rtrs: Clean up rtrs_rdma_dev_pd_ops
>   RDMA/rtrs-srv: Remove paths_num
>   RDMA/rtrs-srv: fix several issues in rtrs_srv_destroy_path_files
>   RDMA/rtrs-srv: Remove kobject_del from
>     rtrs_srv_destroy_once_sysfs_root_folders

Can you please resend already reviewed and non-controversial patches as a
standalone series, so we will be able to apply them?

Thanks

> 
>  drivers/infiniband/ulp/rtrs/rtrs-clt.c       |  12 +-
>  drivers/infiniband/ulp/rtrs/rtrs-pri.h       |   6 -
>  drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c |  13 ++-
>  drivers/infiniband/ulp/rtrs/rtrs-srv.c       | 110 ++++++-------------
>  drivers/infiniband/ulp/rtrs/rtrs-srv.h       |   2 -
>  drivers/infiniband/ulp/rtrs/rtrs.c           |  22 +---
>  6 files changed, 47 insertions(+), 118 deletions(-)
> 
> -- 
> 2.31.1
>
Guoqing Jiang Nov. 17, 2022, 10:06 a.m. UTC | #4
On 11/17/22 5:52 PM, Leon Romanovsky wrote:
> On Sun, Nov 13, 2022 at 09:08:11AM +0800, Guoqing Jiang wrote:
>> Hi,
>>
>> Here are some changes for rtrs, please review them.
>>
>> Thanks,
>> Guoqing
>>
>> Guoqing Jiang (12):
>>    RDMA/rtrs-srv: Remove ib_dev_count from rtrs_srv_ib_ctx
>>    RDMA/rtrs-srv: Refactor rtrs_srv_rdma_cm_handler
>>    RDMA/rtrs-srv: Only close srv_path if it is just allocated
>>    RDMA/rtrs-srv: refactor the handling of failure case in map_cont_bufs
>>    RDMA/rtrs-srv: Correct the checking of ib_map_mr_sg
>>    RDMA/rtrs-clt: Correct the checking of ib_map_mr_sg
>>    RDMA/rtrs-srv: Remove outdated comments from create_con
>>    RDMA/rtrs: Kill recon_cnt from several structs
>>    RDMA/rtrs: Clean up rtrs_rdma_dev_pd_ops
>>    RDMA/rtrs-srv: Remove paths_num
>>    RDMA/rtrs-srv: fix several issues in rtrs_srv_destroy_path_files
>>    RDMA/rtrs-srv: Remove kobject_del from
>>      rtrs_srv_destroy_once_sysfs_root_folders
> Can you please resend already reviewed and non-controversial patches as a
> standalone series, so we will be able to apply them?

Sure, will send a new v2 series soon.

Thanks,
Guoqing