[v5,rdma-next,0/6] RDMA/mlx5: Switch MR cache to use RB-tree

Message

Michael Guralnik Jan. 25, 2023, 10:28 p.m. UTC

This series moves the MR cache to use RB tree to store the entries of the
cache. By doing so, enabling more flexibility when managing the cache
entries.

The MR cache will now cache mkeys returned by the user even if they are
not from one of the predefined pools, by that allowing restarting
applications to reuse their released mkey and improve restart times.

v4->v5:
- Commit message fix: 'Remove implicit ODP' instead of 'explicit'
- Fix return value of init function in case of no ODP in configuration

v3->v4:
- remove 'change-id' and 'issue' git trailers

v2->v3:
- Refactor MR cache init flow
- Move rb_key decleration to rome unnecessary change in following
  patches

v1->v2:
- Rearrange patch order to first introduce the RB-tree and only then
  introduce the caching of previously non-cachable mkeys

v0->v1:
- Fix rb tree search from memcmp to dedicated cmp function
- Rewording of some commit messages

Aharon Landau (2):
  RDMA/mlx5: Don't keep umrable 'page_shift' in cache entries
  RDMA/mlx5: Remove explicit ODP cache entry

Michael Guralnik (4):
  RDMA/mlx5: Change the cache structure to an RB-tree
  RDMA/mlx5: Introduce mlx5r_cache_rb_key
  RDMA/mlx5: Cache all user cacheable mkeys on dereg MR flow
  RDMA/mlx5: Add work to remove temporary entries from the cache

 drivers/infiniband/hw/mlx5/mlx5_ib.h |  38 ++-
 drivers/infiniband/hw/mlx5/mr.c      | 478 +++++++++++++++++++++------
 drivers/infiniband/hw/mlx5/odp.c     |  40 +--
 include/linux/mlx5/driver.h          |   1 -
 4 files changed, 417 insertions(+), 140 deletions(-)

Comments

Jason Gunthorpe Jan. 27, 2023, 5:17 p.m. UTC | #1

On Thu, Jan 26, 2023 at 12:28:01AM +0200, Michael Guralnik wrote:
> This series moves the MR cache to use RB tree to store the entries of the
> cache. By doing so, enabling more flexibility when managing the cache
> entries.
> 
> The MR cache will now cache mkeys returned by the user even if they are
> not from one of the predefined pools, by that allowing restarting
> applications to reuse their released mkey and improve restart times.
> 
> v4->v5:
> - Commit message fix: 'Remove implicit ODP' instead of 'explicit'
> - Fix return value of init function in case of no ODP in configuration
> 
> v3->v4:
> - remove 'change-id' and 'issue' git trailers
> 
> v2->v3:
> - Refactor MR cache init flow
> - Move rb_key decleration to rome unnecessary change in following
>   patches
> 
> v1->v2:
> - Rearrange patch order to first introduce the RB-tree and only then
>   introduce the caching of previously non-cachable mkeys
> 
> v0->v1:
> - Fix rb tree search from memcmp to dedicated cmp function
> - Rewording of some commit messages
> 
> Aharon Landau (2):
>   RDMA/mlx5: Don't keep umrable 'page_shift' in cache entries
>   RDMA/mlx5: Remove explicit ODP cache entry
> 
> Michael Guralnik (4):
>   RDMA/mlx5: Change the cache structure to an RB-tree
>   RDMA/mlx5: Introduce mlx5r_cache_rb_key
>   RDMA/mlx5: Cache all user cacheable mkeys on dereg MR flow
>   RDMA/mlx5: Add work to remove temporary entries from the cache

Applied to for-next

Thanks,
Jason