mbox series

[for-next,v4,0/4] Add error logging to rxe

Message ID 20230303221623.8053-1-rpearsonhpe@gmail.com (mailing list archive)
Headers show
Series Add error logging to rxe | expand

Message

Bob Pearson March 3, 2023, 10:16 p.m. UTC 
Primarily to make debugging more efficient, log message types
are added and error logging messages are added to the verbs API
to rxe driver with the goal that each error reported up to
rdma-core will generate at least one message with additional
details and internal errors restricted to debug messages which can
be dynamically turned on.

v4:
  Removed a mistaken WARN_ON at line 750 in rxe_verbs.c. This was
  hidden by a later fix that covered the error.

v3:
  Corrected a debug message referring to err before err was set in
  patch 4/4.
Reported-by: kernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/oe-kbuild-all/202302250056.mgmG5a52-lkp@intel.com/

v2:
  This set of four patches was split off an earlier series called
  "RDMA/rxe: Correct qp reference counting" since it is not really
  related.

Bob Pearson (4):
  RDMA/rxe: Replace exists by rxe in rxe.c
  RDMA/rxe: Change rxe_dbg to rxe_dbg_dev
  RDMA/rxe: Extend dbg log messages to err and info
  RDMA/rxe: Add error messages

 drivers/infiniband/sw/rxe/rxe.c       |  16 +-
 drivers/infiniband/sw/rxe/rxe.h       |  45 +-
 drivers/infiniband/sw/rxe/rxe_comp.c  |   4 +
 drivers/infiniband/sw/rxe/rxe_cq.c    |   6 +-
 drivers/infiniband/sw/rxe/rxe_icrc.c  |   4 +-
 drivers/infiniband/sw/rxe/rxe_loc.h   |   1 -
 drivers/infiniband/sw/rxe/rxe_mmap.c  |   6 +-
 drivers/infiniband/sw/rxe/rxe_mr.c    |  13 -
 drivers/infiniband/sw/rxe/rxe_net.c   |   4 +-
 drivers/infiniband/sw/rxe/rxe_qp.c    |  16 +-
 drivers/infiniband/sw/rxe/rxe_resp.c  |   4 +
 drivers/infiniband/sw/rxe/rxe_srq.c   |   6 +-
 drivers/infiniband/sw/rxe/rxe_verbs.c | 830 +++++++++++++++++++-------
 13 files changed, 684 insertions(+), 271 deletions(-)


base-commit: 66fb1d5df6ace316a4a6e2c31e13fc123ea2b644

Comments

Jason Gunthorpe March 24, 2023, 2:09 p.m. UTC | #1 
On Fri, Mar 03, 2023 at 04:16:20PM -0600, Bob Pearson wrote:
> Primarily to make debugging more efficient, log message types
> are added and error logging messages are added to the verbs API
> to rxe driver with the goal that each error reported up to
> rdma-core will generate at least one message with additional
> details and internal errors restricted to debug messages which can
> be dynamically turned on.
> 
> v4:
>   Removed a mistaken WARN_ON at line 750 in rxe_verbs.c. This was
>   hidden by a later fix that covered the error.
> 
> v3:
>   Corrected a debug message referring to err before err was set in
>   patch 4/4.
> Reported-by: kernel test robot <lkp@intel.com>
> Link: https://lore.kernel.org/oe-kbuild-all/202302250056.mgmG5a52-lkp@intel.com/
> 
> v2:
>   This set of four patches was split off an earlier series called
>   "RDMA/rxe: Correct qp reference counting" since it is not really
>   related.
> 
> Bob Pearson (4):
>   RDMA/rxe: Replace exists by rxe in rxe.c
>   RDMA/rxe: Change rxe_dbg to rxe_dbg_dev
>   RDMA/rxe: Extend dbg log messages to err and info
>   RDMA/rxe: Add error messages

Applied to for-next, thanks

Jason