mbox series

[for-next,v3,0/7] RDMA/rxe: Misc cleanups

Message ID 20230727192831.65495-1-rpearsonhpe@gmail.com (mailing list archive)
Headers show
Series RDMA/rxe: Misc cleanups | expand

Message

Bob Pearson July 27, 2023, 7:28 p.m. UTC 
This patch set is a collection of cleanup patches previously
posted as part of a larger set that included support for
nonlinear or fragmented packets. It has been rebased to the
current for-next branch after the application of three previous
patch sets:
	RDMA/rxe: Fix incomplete state save in rxe_requester
	RDMA/rxe: Misc fixes and cleanups
	Enable rcu locking of verbs objects

These changes are a pre-requisite for a patch set to follow
which implemements support for nonlinear packets. They are
mainly a code cleanup of rxe_req.c.

Bob Pearson (8):
  RDMA/rxe: Add pad size to struct rxe_pkt_info
  RDMA/rxe: Isolate code to fill request roce headers
  RDMA/rxe: Isolate request payload code in a subroutine
  RDMA/rxe: Remove paylen parameter from rxe_init_packet
  RDMA/rxe: Isolate code to build request packet
  RDMA/rxe: Put fake udp send code in a subroutine
  RDMA/rxe: Combine setting pkt info
  RDMA/rxe: Move next_opcode to rxe_opcode.c

 drivers/infiniband/sw/rxe/rxe_hdr.h    |   1 +
 drivers/infiniband/sw/rxe/rxe_icrc.c   |   4 +-
 drivers/infiniband/sw/rxe/rxe_loc.h    |   2 +-
 drivers/infiniband/sw/rxe/rxe_net.c    |  11 +-
 drivers/infiniband/sw/rxe/rxe_opcode.c | 176 +++++++++-
 drivers/infiniband/sw/rxe/rxe_opcode.h |   4 +
 drivers/infiniband/sw/rxe/rxe_recv.c   |   1 +
 drivers/infiniband/sw/rxe/rxe_req.c    | 451 ++++++++-----------------
 drivers/infiniband/sw/rxe/rxe_resp.c   |  36 +-
 9 files changed, 354 insertions(+), 332 deletions(-)


base-commit: 693e1cdebb50d2aa67406411ca6d5be195d62771
prerequisite-patch-id: c3994e7a93e37e0ce4f50e0c768f3c1a0059a02f
prerequisite-patch-id: 48e13f6ccb560fdeacbd20aaf6696782c23d1190
prerequisite-patch-id: da75fb8eaa863df840e7b392b5048fcc72b0bef3
prerequisite-patch-id: d0877649e2edaf00585a0a6a80391fe0d7bbc13b
prerequisite-patch-id: 6495b1d1f664f8ab91ed9ef9d2ca5b3b27d7df35
prerequisite-patch-id: a6367b8fedd0d8999139c8b857ebbd3ce5c72245
prerequisite-patch-id: 78c95e90a5e49b15b7af8ef57130739c143e88b5
prerequisite-patch-id: 7c65a01066c0418de6897bc8b5f44d078d21b0ec
prerequisite-patch-id: 8ab09f93c23c7875e56c597e69236c30464723b6
prerequisite-patch-id: ca9d84b34873b49048e42fb4c13a2a097c215c46
prerequisite-patch-id: 0f6a587501c8246e1185dfd0cbf5e2044c5f9b13
prerequisite-patch-id: 5246df93137429916d76e75b9a13a4ad5ceb0bad

Comments

Jason Gunthorpe Aug. 9, 2023, 7:20 p.m. UTC | #1 
On Thu, Jul 27, 2023 at 02:28:24PM -0500, Bob Pearson wrote:
> This patch set is a collection of cleanup patches previously
> posted as part of a larger set that included support for
> nonlinear or fragmented packets. It has been rebased to the
> current for-next branch after the application of three previous
> patch sets:
> 	RDMA/rxe: Fix incomplete state save in rxe_requester
> 	RDMA/rxe: Misc fixes and cleanups
> 	Enable rcu locking of verbs objects
> 
> These changes are a pre-requisite for a patch set to follow
> which implemements support for nonlinear packets. They are
> mainly a code cleanup of rxe_req.c.
> 
> Bob Pearson (8):
>   RDMA/rxe: Add pad size to struct rxe_pkt_info
>   RDMA/rxe: Isolate code to fill request roce headers
>   RDMA/rxe: Isolate request payload code in a subroutine
>   RDMA/rxe: Remove paylen parameter from rxe_init_packet
>   RDMA/rxe: Isolate code to build request packet
>   RDMA/rxe: Put fake udp send code in a subroutine
>   RDMA/rxe: Combine setting pkt info
>   RDMA/rxe: Move next_opcode to rxe_opcode.c

This doesn't apply to anything I have so I'm going to drop it for now,
resend it when it can be applied

I didn't notice anything troubling in it

Thanks,
Jason