mbox series

[net,v7,0/4] Add update_pn flag

Message ID 20231005180636.672791-1-radu-nicolae.pirea@oss.nxp.com (mailing list archive)
Headers show
Series Add update_pn flag | expand

Message

Radu Pirea (NXP OSS) Oct. 5, 2023, 6:06 p.m. UTC 
Patches extracted from
https://lore.kernel.org/all/20230928084430.1882670-1-radu-nicolae.pirea@oss.nxp.com/
Update_pn flag will let the offloaded MACsec implementations to know when
the PN is updated.

Radu P.

Radu Pirea (NXP OSS) (4):
  net: macsec: indicate next pn update when offloading
  octeontx2-pf: mcs: update PN only when update_pn is true
  net: phy: mscc: macsec: reject PN update requests
  net/mlx5e: macsec: use update_pn flag instead of PN comparation

 .../ethernet/marvell/octeontx2/nic/cn10k_macsec.c   | 13 +++++++++----
 .../ethernet/mellanox/mlx5/core/en_accel/macsec.c   |  4 ++--
 drivers/net/macsec.c                                |  2 ++
 drivers/net/phy/mscc/mscc_macsec.c                  |  6 ++++++
 include/net/macsec.h                                |  1 +
 5 files changed, 20 insertions(+), 6 deletions(-)

Comments

Sabrina Dubroca Oct. 10, 2023, 8:09 a.m. UTC | #1 
2023-10-05, 21:06:32 +0300, Radu Pirea (NXP OSS) wrote:
> Patches extracted from
> https://lore.kernel.org/all/20230928084430.1882670-1-radu-nicolae.pirea@oss.nxp.com/
> Update_pn flag will let the offloaded MACsec implementations to know when
> the PN is updated.
> 
> Radu P.
> 
> Radu Pirea (NXP OSS) (4):
>   net: macsec: indicate next pn update when offloading
>   octeontx2-pf: mcs: update PN only when update_pn is true
>   net: phy: mscc: macsec: reject PN update requests
>   net/mlx5e: macsec: use update_pn flag instead of PN comparation

Thanks Radu! For the series:
Reviewed-by: Sabrina Dubroca <sd@queasysnail.net>


While reviewing this, I noticed that octeon can leave the HW in an
inconsistent state during upd_txsa and upd_rxsa: these ops do 2
separate changes that can both fail, and if the 2nd change fails, we
don't roll back the first change. This is an older issue (not
introduced by this patch) and can be looked at later (I don't know
what happens to the HW and why setting the PN would fail, maybe it's
not recoverable at that point).
patchwork-bot+netdevbpf@kernel.org Oct. 10, 2023, 8:50 a.m. UTC | #2 
Hello:

This series was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@redhat.com>:

On Thu,  5 Oct 2023 21:06:32 +0300 you wrote:
> Patches extracted from
> https://lore.kernel.org/all/20230928084430.1882670-1-radu-nicolae.pirea@oss.nxp.com/
> Update_pn flag will let the offloaded MACsec implementations to know when
> the PN is updated.
> 
> Radu P.
> 
> [...]

Here is the summary with links:
  - [net,v7,1/4] net: macsec: indicate next pn update when offloading
    https://git.kernel.org/netdev/net/c/0412cc846a1e
  - [net,v7,2/4] octeontx2-pf: mcs: update PN only when update_pn is true
    https://git.kernel.org/netdev/net/c/4dcf38ae3ca1
  - [net,v7,3/4] net: phy: mscc: macsec: reject PN update requests
    https://git.kernel.org/netdev/net/c/e0a8c918daa5
  - [net,v7,4/4] net/mlx5e: macsec: use update_pn flag instead of PN comparation
    https://git.kernel.org/netdev/net/c/fde2f2d7f23d

You are awesome, thank you!