| Message ID | 20231009071801.10210-1-guoqing.jiang@linux.dev (mailing list archive) |
|---|---|
| Headers | show |
| Series | Cleanup for siw | expand |
> -----Original Message----- > From: Guoqing Jiang <guoqing.jiang@linux.dev> > Sent: Monday, October 9, 2023 9:18 AM > To: Bernard Metzler <BMT@zurich.ibm.com>; jgg@ziepe.ca; leon@kernel.org > Cc: linux-rdma@vger.kernel.org > Subject: [EXTERNAL] [PATCH 00/19] Cleanup for siw > > Hi, > > This series aim to cleanup siw code, please review and comment! > > Thanks, > Guoqing > > Guoqing Jiang (19): > RDMA/siw: Introduce siw_get_page > RDMA/siw: Introduce siw_srx_update_skb > RDMA/siw: Use iov.iov_len in kernel_sendmsg > RDMA/siw: Remove goto lable in siw_mmap > RDMA/siw: Remove rcu from siw_qp > RDMA/siw: No need to check term_info.valid before call > siw_send_terminate > RDMA/siw: Also goto out_sem_up if pin_user_pages returns 0 > RDMA/siw: Factor out siw_generic_rx helper > RDMA/siw: Introduce SIW_STAG_MAX_INDEX > RDMA/siw: Add one parameter to siw_destroy_cpulist > RDMA/siw: Introduce siw_cep_set_free_and_put > RDMA/siw: Introduce siw_free_cm_id > RDMA/siw: Simplify siw_qp_id2obj > RDMA/siw: Simplify siw_mem_id2obj > RDMA/siw: Cleanup siw_accept > RDMA/siw: Remove siw_sk_assign_cm_upcalls > RDMA/siw: Fix typo > RDMA/siw: Only check attrs->cap.max_send_wr in siw_create_qp > RDMA/siw: Introduce siw_destroy_cep_sock > > drivers/infiniband/sw/siw/siw.h | 9 +- > drivers/infiniband/sw/siw/siw_cm.c | 154 +++++++++++--------------- > drivers/infiniband/sw/siw/siw_main.c | 30 +++-- > drivers/infiniband/sw/siw/siw_mem.c | 22 ++-- > drivers/infiniband/sw/siw/siw_qp.c | 2 +- > drivers/infiniband/sw/siw/siw_qp_rx.c | 84 ++++++-------- > drivers/infiniband/sw/siw/siw_qp_tx.c | 34 +++--- > drivers/infiniband/sw/siw/siw_verbs.c | 23 +--- > 8 files changed, 142 insertions(+), 216 deletions(-) > > -- > 2.35.3 Hi Guoqing, I'll have a look later next week. Currently on vacation. Thanks, Bernard.
Hi Bernard, On 10/13/23 23:45, Bernard Metzler wrote: >> -----Original Message----- >> From: Guoqing Jiang <guoqing.jiang@linux.dev> >> Sent: Monday, October 9, 2023 9:18 AM >> To: Bernard Metzler <BMT@zurich.ibm.com>; jgg@ziepe.ca; leon@kernel.org >> Cc: linux-rdma@vger.kernel.org >> Subject: [EXTERNAL] [PATCH 00/19] Cleanup for siw >> >> Hi, >> >> This series aim to cleanup siw code, please review and comment! >> >> Thanks, >> Guoqing >> >> Guoqing Jiang (19): >> RDMA/siw: Introduce siw_get_page >> RDMA/siw: Introduce siw_srx_update_skb >> RDMA/siw: Use iov.iov_len in kernel_sendmsg >> RDMA/siw: Remove goto lable in siw_mmap >> RDMA/siw: Remove rcu from siw_qp >> RDMA/siw: No need to check term_info.valid before call >> siw_send_terminate >> RDMA/siw: Also goto out_sem_up if pin_user_pages returns 0 >> RDMA/siw: Factor out siw_generic_rx helper >> RDMA/siw: Introduce SIW_STAG_MAX_INDEX >> RDMA/siw: Add one parameter to siw_destroy_cpulist >> RDMA/siw: Introduce siw_cep_set_free_and_put >> RDMA/siw: Introduce siw_free_cm_id >> RDMA/siw: Simplify siw_qp_id2obj >> RDMA/siw: Simplify siw_mem_id2obj >> RDMA/siw: Cleanup siw_accept >> RDMA/siw: Remove siw_sk_assign_cm_upcalls >> RDMA/siw: Fix typo >> RDMA/siw: Only check attrs->cap.max_send_wr in siw_create_qp >> RDMA/siw: Introduce siw_destroy_cep_sock >> >> drivers/infiniband/sw/siw/siw.h | 9 +- >> drivers/infiniband/sw/siw/siw_cm.c | 154 +++++++++++--------------- >> drivers/infiniband/sw/siw/siw_main.c | 30 +++-- >> drivers/infiniband/sw/siw/siw_mem.c | 22 ++-- >> drivers/infiniband/sw/siw/siw_qp.c | 2 +- >> drivers/infiniband/sw/siw/siw_qp_rx.c | 84 ++++++-------- >> drivers/infiniband/sw/siw/siw_qp_tx.c | 34 +++--- >> drivers/infiniband/sw/siw/siw_verbs.c | 23 +--- >> 8 files changed, 142 insertions(+), 216 deletions(-) >> >> -- >> 2.35.3 > Hi Guoqing, > > I'll have a look later next week. Currently on vacation. > Thanks, Bernard. No hurry, enjoy your vacation first :) BTW, v2 is here. https://lore.kernel.org/linux-rdma/20231013020053.2120-1-guoqing.jiang@linux.dev/T/#t Thanks, Guoqing
Hi, This series aim to cleanup siw code, please review and comment! Thanks, Guoqing Guoqing Jiang (19): RDMA/siw: Introduce siw_get_page RDMA/siw: Introduce siw_srx_update_skb RDMA/siw: Use iov.iov_len in kernel_sendmsg RDMA/siw: Remove goto lable in siw_mmap RDMA/siw: Remove rcu from siw_qp RDMA/siw: No need to check term_info.valid before call siw_send_terminate RDMA/siw: Also goto out_sem_up if pin_user_pages returns 0 RDMA/siw: Factor out siw_generic_rx helper RDMA/siw: Introduce SIW_STAG_MAX_INDEX RDMA/siw: Add one parameter to siw_destroy_cpulist RDMA/siw: Introduce siw_cep_set_free_and_put RDMA/siw: Introduce siw_free_cm_id RDMA/siw: Simplify siw_qp_id2obj RDMA/siw: Simplify siw_mem_id2obj RDMA/siw: Cleanup siw_accept RDMA/siw: Remove siw_sk_assign_cm_upcalls RDMA/siw: Fix typo RDMA/siw: Only check attrs->cap.max_send_wr in siw_create_qp RDMA/siw: Introduce siw_destroy_cep_sock drivers/infiniband/sw/siw/siw.h | 9 +- drivers/infiniband/sw/siw/siw_cm.c | 154 +++++++++++--------------- drivers/infiniband/sw/siw/siw_main.c | 30 +++-- drivers/infiniband/sw/siw/siw_mem.c | 22 ++-- drivers/infiniband/sw/siw/siw_qp.c | 2 +- drivers/infiniband/sw/siw/siw_qp_rx.c | 84 ++++++-------- drivers/infiniband/sw/siw/siw_qp_tx.c | 34 +++--- drivers/infiniband/sw/siw/siw_verbs.c | 23 +--- 8 files changed, 142 insertions(+), 216 deletions(-)