| Message ID | cover.1634033956.git.leonro@nvidia.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Clean MR key use across mlx5_* modules | expand |
On Tue, Oct 12, 2021 at 01:26:28PM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky <leonro@nvidia.com> > > Hi, > > This is cleanup series of mlx5_* MR mkey management. > > Thanks Looks fine superficially Acked-by: Michael S. Tsirkin <mst@redhat.com> > Aharon Landau (7): > RDMA/mlx5: Don't set esc_size in user mr > RDMA/mlx5: Remove iova from struct mlx5_core_mkey > RDMA/mlx5: Remove size from struct mlx5_core_mkey > RDMA/mlx5: Remove pd from struct mlx5_core_mkey > RDMA/mlx5: Replace struct mlx5_core_mkey by u32 key > RDMA/mlx5: Move struct mlx5_core_mkey to mlx5_ib > RDMA/mlx5: Attach ndescs to mlx5_ib_mkey > > drivers/infiniband/hw/mlx5/devx.c | 13 +-- > drivers/infiniband/hw/mlx5/devx.h | 2 +- > drivers/infiniband/hw/mlx5/mlx5_ib.h | 31 ++++--- > drivers/infiniband/hw/mlx5/mr.c | 82 +++++++++---------- > drivers/infiniband/hw/mlx5/odp.c | 38 +++------ > drivers/infiniband/hw/mlx5/wr.c | 10 +-- > .../mellanox/mlx5/core/diag/fw_tracer.c | 6 +- > .../mellanox/mlx5/core/diag/fw_tracer.h | 2 +- > .../mellanox/mlx5/core/diag/rsc_dump.c | 10 +-- > drivers/net/ethernet/mellanox/mlx5/core/en.h | 2 +- > .../net/ethernet/mellanox/mlx5/core/en/ptp.c | 2 +- > .../net/ethernet/mellanox/mlx5/core/en/trap.c | 2 +- > .../ethernet/mellanox/mlx5/core/en_common.c | 6 +- > .../net/ethernet/mellanox/mlx5/core/en_main.c | 13 ++- > .../ethernet/mellanox/mlx5/core/fpga/conn.c | 10 +-- > .../ethernet/mellanox/mlx5/core/fpga/core.h | 2 +- > drivers/net/ethernet/mellanox/mlx5/core/mr.c | 27 +++--- > .../mellanox/mlx5/core/steering/dr_icm_pool.c | 10 +-- > .../mellanox/mlx5/core/steering/dr_send.c | 11 ++- > .../mellanox/mlx5/core/steering/dr_types.h | 2 +- > drivers/vdpa/mlx5/core/mlx5_vdpa.h | 8 +- > drivers/vdpa/mlx5/core/mr.c | 8 +- > drivers/vdpa/mlx5/core/resources.c | 13 +-- > drivers/vdpa/mlx5/net/mlx5_vnet.c | 2 +- > include/linux/mlx5/driver.h | 30 ++----- > 25 files changed, 147 insertions(+), 195 deletions(-) > > -- > 2.31.1
On Tue, Oct 12, 2021 at 01:26:28PM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky <leonro@nvidia.com> > > Hi, > > This is cleanup series of mlx5_* MR mkey management. > > Thanks > > Aharon Landau (7): > RDMA/mlx5: Don't set esc_size in user mr ^^^^ this typo, I will fix when apply to mmlx5-next. Thanks > RDMA/mlx5: Remove iova from struct mlx5_core_mkey > RDMA/mlx5: Remove size from struct mlx5_core_mkey > RDMA/mlx5: Remove pd from struct mlx5_core_mkey > RDMA/mlx5: Replace struct mlx5_core_mkey by u32 key > RDMA/mlx5: Move struct mlx5_core_mkey to mlx5_ib > RDMA/mlx5: Attach ndescs to mlx5_ib_mkey > > drivers/infiniband/hw/mlx5/devx.c | 13 +-- > drivers/infiniband/hw/mlx5/devx.h | 2 +- > drivers/infiniband/hw/mlx5/mlx5_ib.h | 31 ++++--- > drivers/infiniband/hw/mlx5/mr.c | 82 +++++++++---------- > drivers/infiniband/hw/mlx5/odp.c | 38 +++------ > drivers/infiniband/hw/mlx5/wr.c | 10 +-- > .../mellanox/mlx5/core/diag/fw_tracer.c | 6 +- > .../mellanox/mlx5/core/diag/fw_tracer.h | 2 +- > .../mellanox/mlx5/core/diag/rsc_dump.c | 10 +-- > drivers/net/ethernet/mellanox/mlx5/core/en.h | 2 +- > .../net/ethernet/mellanox/mlx5/core/en/ptp.c | 2 +- > .../net/ethernet/mellanox/mlx5/core/en/trap.c | 2 +- > .../ethernet/mellanox/mlx5/core/en_common.c | 6 +- > .../net/ethernet/mellanox/mlx5/core/en_main.c | 13 ++- > .../ethernet/mellanox/mlx5/core/fpga/conn.c | 10 +-- > .../ethernet/mellanox/mlx5/core/fpga/core.h | 2 +- > drivers/net/ethernet/mellanox/mlx5/core/mr.c | 27 +++--- > .../mellanox/mlx5/core/steering/dr_icm_pool.c | 10 +-- > .../mellanox/mlx5/core/steering/dr_send.c | 11 ++- > .../mellanox/mlx5/core/steering/dr_types.h | 2 +- > drivers/vdpa/mlx5/core/mlx5_vdpa.h | 8 +- > drivers/vdpa/mlx5/core/mr.c | 8 +- > drivers/vdpa/mlx5/core/resources.c | 13 +-- > drivers/vdpa/mlx5/net/mlx5_vnet.c | 2 +- > include/linux/mlx5/driver.h | 30 ++----- > 25 files changed, 147 insertions(+), 195 deletions(-) > > -- > 2.31.1 > > _______________________________________________ > Virtualization mailing list > Virtualization@lists.linux-foundation.org > https://lists.linuxfoundation.org/mailman/listinfo/virtualization
On Tue, Oct 12, 2021 at 01:26:28PM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky <leonro@nvidia.com> > > Hi, > > This is cleanup series of mlx5_* MR mkey management. > > Thanks > > Aharon Landau (7): > RDMA/mlx5: Don't set esc_size in user mr Please sent just this patch to -rc after modifying as I noted, don't put this in mlx5-next > RDMA/mlx5: Remove iova from struct mlx5_core_mkey > RDMA/mlx5: Remove size from struct mlx5_core_mkey > RDMA/mlx5: Remove pd from struct mlx5_core_mkey > RDMA/mlx5: Replace struct mlx5_core_mkey by u32 key > RDMA/mlx5: Move struct mlx5_core_mkey to mlx5_ib > RDMA/mlx5: Attach ndescs to mlx5_ib_mkey It seems fine to me, other than the little notes, a V2 can go to mlx5-next Jason
On Wed, Oct 13, 2021 at 11:43:03AM -0300, Jason Gunthorpe wrote: > On Tue, Oct 12, 2021 at 01:26:28PM +0300, Leon Romanovsky wrote: > > From: Leon Romanovsky <leonro@nvidia.com> > > > > Hi, > > > > This is cleanup series of mlx5_* MR mkey management. > > > > Thanks > > > > Aharon Landau (7): > > RDMA/mlx5: Don't set esc_size in user mr > > Please sent just this patch to -rc after modifying as I noted, don't > put this in mlx5-next > > > RDMA/mlx5: Remove iova from struct mlx5_core_mkey > > RDMA/mlx5: Remove size from struct mlx5_core_mkey > > RDMA/mlx5: Remove pd from struct mlx5_core_mkey > > RDMA/mlx5: Replace struct mlx5_core_mkey by u32 key > > RDMA/mlx5: Move struct mlx5_core_mkey to mlx5_ib > > RDMA/mlx5: Attach ndescs to mlx5_ib_mkey > > It seems fine to me, other than the little notes, a V2 can go to > mlx5-next Applied to vfio-next, to serve as a basis for live migration patches. https://lore.kernel.org/kvm/20211019105838.227569-1-yishaih@nvidia.com/T/#m89f4f0ec4baddeb2828a2b38dcbbd6900009fb83 ae0579acde81 RDMA/mlx5: Attach ndescs to mlx5_ib_mkey 4123bfb0b28b RDMA/mlx5: Move struct mlx5_core_mkey to mlx5_ib 83fec3f12a59 RDMA/mlx5: Replace struct mlx5_core_mkey by u32 key c64674168b6a RDMA/mlx5: Remove pd from struct mlx5_core_mkey 062fd731e51e RDMA/mlx5: Remove size from struct mlx5_core_mkey cf6a8b1b24d6 RDMA/mlx5: Remove iova from struct mlx5_core_mkey https://git.kernel.org/pub/scm/linux/kernel/git/mellanox/linux.git/log/?h=vfio-next Thanks > > Jason
From: Leon Romanovsky <leonro@nvidia.com> Hi, This is cleanup series of mlx5_* MR mkey management. Thanks Aharon Landau (7): RDMA/mlx5: Don't set esc_size in user mr RDMA/mlx5: Remove iova from struct mlx5_core_mkey RDMA/mlx5: Remove size from struct mlx5_core_mkey RDMA/mlx5: Remove pd from struct mlx5_core_mkey RDMA/mlx5: Replace struct mlx5_core_mkey by u32 key RDMA/mlx5: Move struct mlx5_core_mkey to mlx5_ib RDMA/mlx5: Attach ndescs to mlx5_ib_mkey drivers/infiniband/hw/mlx5/devx.c | 13 +-- drivers/infiniband/hw/mlx5/devx.h | 2 +- drivers/infiniband/hw/mlx5/mlx5_ib.h | 31 ++++--- drivers/infiniband/hw/mlx5/mr.c | 82 +++++++++---------- drivers/infiniband/hw/mlx5/odp.c | 38 +++------ drivers/infiniband/hw/mlx5/wr.c | 10 +-- .../mellanox/mlx5/core/diag/fw_tracer.c | 6 +- .../mellanox/mlx5/core/diag/fw_tracer.h | 2 +- .../mellanox/mlx5/core/diag/rsc_dump.c | 10 +-- drivers/net/ethernet/mellanox/mlx5/core/en.h | 2 +- .../net/ethernet/mellanox/mlx5/core/en/ptp.c | 2 +- .../net/ethernet/mellanox/mlx5/core/en/trap.c | 2 +- .../ethernet/mellanox/mlx5/core/en_common.c | 6 +- .../net/ethernet/mellanox/mlx5/core/en_main.c | 13 ++- .../ethernet/mellanox/mlx5/core/fpga/conn.c | 10 +-- .../ethernet/mellanox/mlx5/core/fpga/core.h | 2 +- drivers/net/ethernet/mellanox/mlx5/core/mr.c | 27 +++--- .../mellanox/mlx5/core/steering/dr_icm_pool.c | 10 +-- .../mellanox/mlx5/core/steering/dr_send.c | 11 ++- .../mellanox/mlx5/core/steering/dr_types.h | 2 +- drivers/vdpa/mlx5/core/mlx5_vdpa.h | 8 +- drivers/vdpa/mlx5/core/mr.c | 8 +- drivers/vdpa/mlx5/core/resources.c | 13 +-- drivers/vdpa/mlx5/net/mlx5_vnet.c | 2 +- include/linux/mlx5/driver.h | 30 ++----- 25 files changed, 147 insertions(+), 195 deletions(-)