diff mbox

[1/2] Use autoreconf in autogen.sh

Message ID 1365866108-9731-1-git-send-email-jsquyres@cisco.com (mailing list archive)
State Rejected
Headers show

Commit Message

Jeff Squyres April 13, 2013, 3:15 p.m. UTC
The old sequence of Autotools commands listed in autogen.sh is no
longer correct.  Instead, just use the single "autoreconf" command,
which will invoke all the Right Autotools commands in the correct
order.

Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
---
 autogen.sh | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

Comments

Jeff Squyres April 19, 2013, 3:25 p.m. UTC | #1
Bump.

Any thoughts on these two patches?  They're pretty trivial, enable use with modern versions of Autotools, and now feature the proper Signed-off-by line.


On Apr 13, 2013, at 8:15 AM, Jeff Squyres <jsquyres@cisco.com> wrote:

> The old sequence of Autotools commands listed in autogen.sh is no
> longer correct.  Instead, just use the single "autoreconf" command,
> which will invoke all the Right Autotools commands in the correct
> order.
> 
> Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
> ---
> autogen.sh | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/autogen.sh b/autogen.sh
> index fd47839..6c9233e 100755
> --- a/autogen.sh
> +++ b/autogen.sh
> @@ -1,8 +1,4 @@
> #! /bin/sh
> 
> set -x
> -aclocal -I config
> -libtoolize --force --copy
> -autoheader
> -automake --foreign --add-missing --copy
> -autoconf
> +autoreconf -ifv -I config
> -- 
> 1.8.1.1
>
Hefty, Sean April 20, 2013, 12:19 a.m. UTC | #2
> Any thoughts on these two patches?  They're pretty trivial, enable use with
> modern versions of Autotools, and now feature the proper Signed-off-by line.

It may help if you identify the library this patch is against.  :)
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jeff Squyres April 22, 2013, 5:02 p.m. UTC | #3
On Apr 19, 2013, at 8:19 PM, "Hefty, Sean" <sean.hefty@intel.com> wrote:

> It may help if you identify the library this patch is against.  :)

3rd time sending will be the charm...  :-)
diff mbox

Patch

diff --git a/autogen.sh b/autogen.sh
index fd47839..6c9233e 100755
--- a/autogen.sh
+++ b/autogen.sh
@@ -1,8 +1,4 @@ 
 #! /bin/sh
 
 set -x
-aclocal -I config
-libtoolize --force --copy
-autoheader
-automake --foreign --add-missing --copy
-autoconf
+autoreconf -ifv -I config