| Message ID | 1373886239.2591.26.camel@x61.thuisdomein (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
> 1) Perhaps a better way to silence GCC is to drop "port" entirely, and > assign to "id_priv->id.port_num" directly. Would that be acceptable? Yes, this would work. - Sean
diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c index f1c279f..c6c0a5f 100644 --- a/drivers/infiniband/core/cma.c +++ b/drivers/infiniband/core/cma.c @@ -426,6 +426,7 @@ static int cma_resolve_ib_dev(struct rdma_id_private *id_priv) u8 port, p; int i; + port = 0; /* silence GCC */ cma_dev = NULL; addr = (struct sockaddr_ib *) cma_dst_addr(id_priv); dgid = (union ib_gid *) &addr->sib_addr;
Building cma.o triggers this GCC warning: drivers/infiniband/core/cma.c: In function ‘rdma_resolve_addr’: drivers/infiniband/core/cma.c:465:23: warning: ‘port’ may be used uninitialized in this function [-Wmaybe-uninitialized] drivers/infiniband/core/cma.c:426:5: note: ‘port’ was declared here This is a false positive, as "port" will always be initialized if we're at "found". Help GCC by initializing "port" to 0. Since valid port numbers apparently start at 1, this is an invalid value. That could help in analyzing the code and tracking down errors. Signed-off-by: Paul Bolle <pebolle@tiscali.nl> --- 0) Compile tested only. 1) Perhaps a better way to silence GCC is to drop "port" entirely, and assign to "id_priv->id.port_num" directly. Would that be acceptable? drivers/infiniband/core/cma.c | 1 + 1 file changed, 1 insertion(+)