| Message ID | 1392821725-14137-1-git-send-email-prarit@redhat.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
Hi, Le mercredi 19 février 2014 à 09:55 -0500, Prarit Bhargava a écrit : > drivers/infiniband/hw/ocrdma/ocrdma_verbs.c: In function ‘_ocrdma_modify_qp’: > drivers/infiniband/hw/ocrdma/ocrdma_verbs.c:1299:31: error: ‘old_qps’ may be used uninitialized in this function [-Werror=maybe-uninitialized] > status = ocrdma_mbx_modify_qp(dev, qp, attr, attr_mask, old_qps); > > ocrdma_mbx_modify_qp() (and subsequent calls) doesn't appear to use old_qps > so it doesn't need to be passed on. Removing the variable results in the > warning going away. > Nice to see this warning removed. > Signed-off-by: Prarit Bhargava <prarit@redhat.com> > You should move the signed of after the Cc's. > Cc: Roland Dreier <roland@kernel.org> > Cc: Sean Hefty <sean.hefty@intel.com> > Cc: Hal Rosenstock <hal.rosenstock@gmail.com> > Cc: Naresh Gottumukkala <bgottumukkala@emulex.com> > Cc: Moni Shoua <monis@mellanox.com> > Or Gerlitz <ogerlitz@mellanox.com> ^^^ There's a missing Cc: tag > Cc: Matan Barak <matanb@mellanox.com> > Cc: "Gottumukkala, Naresh" <B.A.L.NRaju.Gottumukkala@Emulex.Com> Regards.
Le mercredi 19 février 2014 à 17:47 +0100, Yann Droneaud a écrit : > Le mercredi 19 février 2014 à 09:55 -0500, Prarit Bhargava a écrit : > > drivers/infiniband/hw/ocrdma/ocrdma_verbs.c: In function ‘_ocrdma_modify_qp’: > > drivers/infiniband/hw/ocrdma/ocrdma_verbs.c:1299:31: error: ‘old_qps’ may be used uninitialized in this function [-Werror=maybe-uninitialized] > > status = ocrdma_mbx_modify_qp(dev, qp, attr, attr_mask, old_qps); > > > > ocrdma_mbx_modify_qp() (and subsequent calls) doesn't appear to use old_qps > > so it doesn't need to be passed on. Removing the variable results in the > > warning going away. > > > > Nice to see this warning removed. > > > Signed-off-by: Prarit Bhargava <prarit@redhat.com> > > > > You should move the signed of after the Cc's. > > > Cc: Roland Dreier <roland@kernel.org> > > Cc: Sean Hefty <sean.hefty@intel.com> > > Cc: Hal Rosenstock <hal.rosenstock@gmail.com> > > Cc: Naresh Gottumukkala <bgottumukkala@emulex.com> > > Cc: Moni Shoua <monis@mellanox.com> > > Or Gerlitz <ogerlitz@mellanox.com> > ^^^ > There's a missing Cc: tag > > > Cc: Matan Barak <matanb@mellanox.com> > > Cc: "Gottumukkala, Naresh" <B.A.L.NRaju.Gottumukkala@Emulex.Com> > Additionnaly some addresses seems to be invalid: <B.A.L.NRaju.Gottumukkala@emulex.com>: host emulex.com.mail5.psmtp.com[64.18.5.10] said: 550 No such user - psmtp (in reply to RCPT TO command) <bgottumukkala@emulex.com>: host emulex.com.mail5.psmtp.com[64.18.5.10] said: 550 No such user - psmtp (in reply to RCPT TO command) Regards.
On 02/19/2014 11:54 AM, Yann Droneaud wrote: > Le mercredi 19 février 2014 à 17:47 +0100, Yann Droneaud a écrit : >> Le mercredi 19 février 2014 à 09:55 -0500, Prarit Bhargava a écrit : >>> drivers/infiniband/hw/ocrdma/ocrdma_verbs.c: In function ‘_ocrdma_modify_qp’: >>> drivers/infiniband/hw/ocrdma/ocrdma_verbs.c:1299:31: error: ‘old_qps’ may be used uninitialized in this function [-Werror=maybe-uninitialized] >>> status = ocrdma_mbx_modify_qp(dev, qp, attr, attr_mask, old_qps); >>> >>> ocrdma_mbx_modify_qp() (and subsequent calls) doesn't appear to use old_qps >>> so it doesn't need to be passed on. Removing the variable results in the >>> warning going away. >>> >> >> Nice to see this warning removed. >> >>> Signed-off-by: Prarit Bhargava <prarit@redhat.com> >>> >> >> You should move the signed of after the Cc's. >> >>> Cc: Roland Dreier <roland@kernel.org> >>> Cc: Sean Hefty <sean.hefty@intel.com> >>> Cc: Hal Rosenstock <hal.rosenstock@gmail.com> >>> Cc: Naresh Gottumukkala <bgottumukkala@emulex.com> >>> Cc: Moni Shoua <monis@mellanox.com> >>> Or Gerlitz <ogerlitz@mellanox.com> >> ^^^ >> There's a missing Cc: tag Oops. I'll add him to v2. >> >>> Cc: Matan Barak <matanb@mellanox.com> >>> Cc: "Gottumukkala, Naresh" <B.A.L.NRaju.Gottumukkala@Emulex.Com> >> > > Additionnaly some addresses seems to be invalid: > > <B.A.L.NRaju.Gottumukkala@emulex.com>: host > emulex.com.mail5.psmtp.com[64.18.5.10] said: 550 No such user - psmtp > (in reply to RCPT TO command) > > <bgottumukkala@emulex.com>: host emulex.com.mail5.psmtp.com[64.18.5.10] > said: 550 No such user - psmtp (in reply to RCPT TO command) Yep, but those are spit out by get_maintainer.pl before I send the patch. There's no way to know that they are dead email addresses until the mail is sent :/. Trimming them now... P. > > Regards. > -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c index 1664d64..ac3fbf2 100644 --- a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c +++ b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c @@ -2127,8 +2127,7 @@ static int ocrdma_set_av_params(struct ocrdma_qp *qp, static int ocrdma_set_qp_params(struct ocrdma_qp *qp, struct ocrdma_modify_qp *cmd, - struct ib_qp_attr *attrs, int attr_mask, - enum ib_qp_state old_qps) + struct ib_qp_attr *attrs, int attr_mask) { int status = 0; @@ -2233,8 +2232,7 @@ pmtu_err: } int ocrdma_mbx_modify_qp(struct ocrdma_dev *dev, struct ocrdma_qp *qp, - struct ib_qp_attr *attrs, int attr_mask, - enum ib_qp_state old_qps) + struct ib_qp_attr *attrs, int attr_mask) { int status = -ENOMEM; struct ocrdma_modify_qp *cmd; @@ -2257,7 +2255,7 @@ int ocrdma_mbx_modify_qp(struct ocrdma_dev *dev, struct ocrdma_qp *qp, OCRDMA_QP_PARAMS_STATE_MASK; } - status = ocrdma_set_qp_params(qp, cmd, attrs, attr_mask, old_qps); + status = ocrdma_set_qp_params(qp, cmd, attrs, attr_mask); if (status) goto mbx_err; status = ocrdma_mbx_cmd(dev, (struct ocrdma_mqe *)cmd); diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_hw.h b/drivers/infiniband/hw/ocrdma/ocrdma_hw.h index 82fe332..db3d55f 100644 --- a/drivers/infiniband/hw/ocrdma/ocrdma_hw.h +++ b/drivers/infiniband/hw/ocrdma/ocrdma_hw.h @@ -112,8 +112,7 @@ int ocrdma_mbx_create_qp(struct ocrdma_qp *, struct ib_qp_init_attr *attrs, u8 enable_dpp_cq, u16 dpp_cq_id, u16 *dpp_offset, u16 *dpp_credit_lmt); int ocrdma_mbx_modify_qp(struct ocrdma_dev *, struct ocrdma_qp *, - struct ib_qp_attr *attrs, int attr_mask, - enum ib_qp_state old_qps); + struct ib_qp_attr *attrs, int attr_mask); int ocrdma_mbx_query_qp(struct ocrdma_dev *, struct ocrdma_qp *, struct ocrdma_qp_params *param); int ocrdma_mbx_destroy_qp(struct ocrdma_dev *, struct ocrdma_qp *); diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c index e0cc201..f1108eb 100644 --- a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c +++ b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c @@ -1296,7 +1296,7 @@ int _ocrdma_modify_qp(struct ib_qp *ibqp, struct ib_qp_attr *attr, */ if (status < 0) return status; - status = ocrdma_mbx_modify_qp(dev, qp, attr, attr_mask, old_qps); + status = ocrdma_mbx_modify_qp(dev, qp, attr, attr_mask); if (!status && attr_mask & IB_QP_STATE && attr->qp_state == IB_QPS_RTR) ocrdma_flush_rq_db(qp);
drivers/infiniband/hw/ocrdma/ocrdma_verbs.c: In function ‘_ocrdma_modify_qp’: drivers/infiniband/hw/ocrdma/ocrdma_verbs.c:1299:31: error: ‘old_qps’ may be used uninitialized in this function [-Werror=maybe-uninitialized] status = ocrdma_mbx_modify_qp(dev, qp, attr, attr_mask, old_qps); ocrdma_mbx_modify_qp() (and subsequent calls) doesn't appear to use old_qps so it doesn't need to be passed on. Removing the variable results in the warning going away. Signed-off-by: Prarit Bhargava <prarit@redhat.com> Cc: Roland Dreier <roland@kernel.org> Cc: Sean Hefty <sean.hefty@intel.com> Cc: Hal Rosenstock <hal.rosenstock@gmail.com> Cc: Naresh Gottumukkala <bgottumukkala@emulex.com> Cc: Moni Shoua <monis@mellanox.com> Or Gerlitz <ogerlitz@mellanox.com> Cc: Matan Barak <matanb@mellanox.com> Cc: "Gottumukkala, Naresh" <B.A.L.NRaju.Gottumukkala@Emulex.Com> --- drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 8 +++----- drivers/infiniband/hw/ocrdma/ocrdma_hw.h | 3 +-- drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 2 +- 3 files changed, 5 insertions(+), 8 deletions(-)