| Message ID | 1398782723-13433-1-git-send-email-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On Tue, 2014-04-29 at 17:45 +0300, Andy Shevchenko wrote: > Instead of supplying each byte through stack let's use %pM specifier. Anyone to comment or apply this patch? > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Cc: Tom Tucker <tom@opengridcomputing.com> > Cc: Steve Wise <swise@opengridcomputing.com> > Cc: linux-rdma@vger.kernel.org > --- > drivers/scsi/fnic/vnic_dev.c | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) > > diff --git a/drivers/scsi/fnic/vnic_dev.c b/drivers/scsi/fnic/vnic_dev.c > index 9795d6f..ba69d61 100644 > --- a/drivers/scsi/fnic/vnic_dev.c > +++ b/drivers/scsi/fnic/vnic_dev.c > @@ -499,10 +499,7 @@ void vnic_dev_add_addr(struct vnic_dev *vdev, u8 *addr) > > err = vnic_dev_cmd(vdev, CMD_ADDR_ADD, &a0, &a1, wait); > if (err) > - printk(KERN_ERR > - "Can't add addr [%02x:%02x:%02x:%02x:%02x:%02x], %d\n", > - addr[0], addr[1], addr[2], addr[3], addr[4], addr[5], > - err); > + pr_err("Can't add addr [%pM], %d\n", addr, err); > } > > void vnic_dev_del_addr(struct vnic_dev *vdev, u8 *addr) > @@ -517,10 +514,7 @@ void vnic_dev_del_addr(struct vnic_dev *vdev, u8 *addr) > > err = vnic_dev_cmd(vdev, CMD_ADDR_DEL, &a0, &a1, wait); > if (err) > - printk(KERN_ERR > - "Can't del addr [%02x:%02x:%02x:%02x:%02x:%02x], %d\n", > - addr[0], addr[1], addr[2], addr[3], addr[4], addr[5], > - err); > + pr_err("Can't del addr [%pM], %d\n", addr, err); > } > > int vnic_dev_notify_set(struct vnic_dev *vdev, u16 intr)
Hi Andy, On 3/19/15 12:54 PM, Andy Shevchenko wrote: > On Tue, 2014-04-29 at 17:45 +0300, Andy Shevchenko wrote: >> Instead of supplying each byte through stack let's use %pM specifier. > Anyone to comment or apply this patch? > >> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> >> Cc: Tom Tucker <tom@opengridcomputing.com> >> Cc: Steve Wise <swise@opengridcomputing.com> >> Cc: linux-rdma@vger.kernel.org >> --- >> drivers/scsi/fnic/vnic_dev.c | 10 ++-------- >> 1 file changed, 2 insertions(+), 8 deletions(-) >> >> diff --git a/drivers/scsi/fnic/vnic_dev.c b/drivers/scsi/fnic/vnic_dev.c >> index 9795d6f..ba69d61 100644 >> --- a/drivers/scsi/fnic/vnic_dev.c >> +++ b/drivers/scsi/fnic/vnic_dev.c >> @@ -499,10 +499,7 @@ void vnic_dev_add_addr(struct vnic_dev *vdev, u8 *addr) >> >> err = vnic_dev_cmd(vdev, CMD_ADDR_ADD, &a0, &a1, wait); >> if (err) >> - printk(KERN_ERR >> - "Can't add addr [%02x:%02x:%02x:%02x:%02x:%02x], %d\n", >> - addr[0], addr[1], addr[2], addr[3], addr[4], addr[5], >> - err); >> + pr_err("Can't add addr [%pM], %d\n", addr, err); This looks completely reasonable to me. Tom >> } >> >> void vnic_dev_del_addr(struct vnic_dev *vdev, u8 *addr) >> @@ -517,10 +514,7 @@ void vnic_dev_del_addr(struct vnic_dev *vdev, u8 *addr) >> >> err = vnic_dev_cmd(vdev, CMD_ADDR_DEL, &a0, &a1, wait); >> if (err) >> - printk(KERN_ERR >> - "Can't del addr [%02x:%02x:%02x:%02x:%02x:%02x], %d\n", >> - addr[0], addr[1], addr[2], addr[3], addr[4], addr[5], >> - err); >> + pr_err("Can't del addr [%pM], %d\n", addr, err); >> } >> >> int vnic_dev_notify_set(struct vnic_dev *vdev, u16 intr) > -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, 2015-03-19 at 21:50 -0500, Tom Tucker wrote: > Hi Andy, > > On 3/19/15 12:54 PM, Andy Shevchenko wrote: > > On Tue, 2014-04-29 at 17:45 +0300, Andy Shevchenko wrote: > > > Instead of supplying each byte through stack let's use %pM > > > specifier. > > Anyone to comment or apply this patch? > > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com > > > > > > > Cc: Tom Tucker <tom@opengridcomputing.com> > > > Cc: Steve Wise <swise@opengridcomputing.com> > > > Cc: linux-rdma@vger.kernel.org > > > --- > > > drivers/scsi/fnic/vnic_dev.c | 10 ++-------- > > > 1 file changed, 2 insertions(+), 8 deletions(-) > > > > > > diff --git a/drivers/scsi/fnic/vnic_dev.c > > > b/drivers/scsi/fnic/vnic_dev.c > > > index 9795d6f..ba69d61 100644 > > > --- a/drivers/scsi/fnic/vnic_dev.c > > > +++ b/drivers/scsi/fnic/vnic_dev.c > > > @@ -499,10 +499,7 @@ void vnic_dev_add_addr(struct vnic_dev > > > *vdev, u8 *addr) > > > > > > err = vnic_dev_cmd(vdev, CMD_ADDR_ADD, &a0, &a1, wait); > > > if (err) > > > - printk(KERN_ERR > > > - "Can't add addr > > > [%02x:%02x:%02x:%02x:%02x:%02x], %d\n", > > > - addr[0], addr[1], addr[2], addr[3], > > > addr[4], addr[5], > > > - err); > > > + pr_err("Can't add addr [%pM], %d\n", addr, err); > > This looks completely reasonable to me. Anyone to apply then? > > Tom > > > } > > > > > > void vnic_dev_del_addr(struct vnic_dev *vdev, u8 *addr) > > > @@ -517,10 +514,7 @@ void vnic_dev_del_addr(struct vnic_dev > > > *vdev, u8 *addr) > > > > > > err = vnic_dev_cmd(vdev, CMD_ADDR_DEL, &a0, &a1, wait); > > > if (err) > > > - printk(KERN_ERR > > > - "Can't del addr > > > [%02x:%02x:%02x:%02x:%02x:%02x], %d\n", > > > - addr[0], addr[1], addr[2], addr[3], > > > addr[4], addr[5], > > > - err); > > > + pr_err("Can't del addr [%pM], %d\n", addr, err); > > > } > > > > > > int vnic_dev_notify_set(struct vnic_dev *vdev, u16 intr) > > >
diff --git a/drivers/scsi/fnic/vnic_dev.c b/drivers/scsi/fnic/vnic_dev.c index 9795d6f..ba69d61 100644 --- a/drivers/scsi/fnic/vnic_dev.c +++ b/drivers/scsi/fnic/vnic_dev.c @@ -499,10 +499,7 @@ void vnic_dev_add_addr(struct vnic_dev *vdev, u8 *addr) err = vnic_dev_cmd(vdev, CMD_ADDR_ADD, &a0, &a1, wait); if (err) - printk(KERN_ERR - "Can't add addr [%02x:%02x:%02x:%02x:%02x:%02x], %d\n", - addr[0], addr[1], addr[2], addr[3], addr[4], addr[5], - err); + pr_err("Can't add addr [%pM], %d\n", addr, err); } void vnic_dev_del_addr(struct vnic_dev *vdev, u8 *addr) @@ -517,10 +514,7 @@ void vnic_dev_del_addr(struct vnic_dev *vdev, u8 *addr) err = vnic_dev_cmd(vdev, CMD_ADDR_DEL, &a0, &a1, wait); if (err) - printk(KERN_ERR - "Can't del addr [%02x:%02x:%02x:%02x:%02x:%02x], %d\n", - addr[0], addr[1], addr[2], addr[3], addr[4], addr[5], - err); + pr_err("Can't del addr [%pM], %d\n", addr, err); } int vnic_dev_notify_set(struct vnic_dev *vdev, u16 intr)
Instead of supplying each byte through stack let's use %pM specifier. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Cc: Tom Tucker <tom@opengridcomputing.com> Cc: Steve Wise <swise@opengridcomputing.com> Cc: linux-rdma@vger.kernel.org --- drivers/scsi/fnic/vnic_dev.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-)