| Message ID | 1432238824-16953-1-git-send-email-laurent.navet@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On Thu, 2015-05-21 at 22:07 +0200, Laurent Navet wrote: > The same code is executed regardless status value, so these tests can > be removed. > Fix Coverity CID 1271151 and 1268788 Thanks, applied for 4.2. > Signed-off-by: Laurent Navet <laurent.navet@gmail.com> > --- > drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c > index 0c9e959..e748090 100644 > --- a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c > +++ b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c > @@ -1960,9 +1960,6 @@ static int ocrdma_mbx_reg_mr_cont(struct ocrdma_dev *dev, > upper_32_bits(hwmr->pbl_table[i + pbl_offset].pa); > } > status = ocrdma_mbx_cmd(dev, (struct ocrdma_mqe *)cmd); > - if (status) > - goto mbx_err; > -mbx_err: > kfree(cmd); > return status; > } > @@ -3044,9 +3041,6 @@ static int ocrdma_mbx_modify_eqd(struct ocrdma_dev *dev, struct ocrdma_eq *eq, > (eq[i].aic_obj.prev_eqd * 65)/100; > } > status = ocrdma_mbx_cmd(dev, (struct ocrdma_mqe *)cmd); > - if (status) > - goto mbx_err; > -mbx_err: > kfree(cmd); > return status; > }
Although already applied, Thanks Laurent and Doug. Acked-By: Devesh Sharma <devesh.sharma@avagotech.com> > -----Original Message----- > From: Doug Ledford [mailto:dledford@redhat.com] > Sent: Tuesday, May 26, 2015 6:15 PM > To: Laurent Navet > Cc: selvin.xavier@emulex.com; devesh.sharma@emulex.com; > mitesh.ahuja@emulex.com; sean.hefty@intel.com; hal.rosenstock@gmail.com; > linux-rdma@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH] RDMA/ocrdma: remove unneeded tests > > On Thu, 2015-05-21 at 22:07 +0200, Laurent Navet wrote: > > The same code is executed regardless status value, so these tests can > > be removed. > > Fix Coverity CID 1271151 and 1268788 > > Thanks, applied for 4.2. > > > Signed-off-by: Laurent Navet <laurent.navet@gmail.com> > > --- > > drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 6 ------ > > 1 file changed, 6 deletions(-) > > > > diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c > > b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c > > index 0c9e959..e748090 100644 > > --- a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c > > +++ b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c > > @@ -1960,9 +1960,6 @@ static int ocrdma_mbx_reg_mr_cont(struct > ocrdma_dev *dev, > > upper_32_bits(hwmr->pbl_table[i + pbl_offset].pa); > > } > > status = ocrdma_mbx_cmd(dev, (struct ocrdma_mqe *)cmd); > > - if (status) > > - goto mbx_err; > > -mbx_err: > > kfree(cmd); > > return status; > > } > > @@ -3044,9 +3041,6 @@ static int ocrdma_mbx_modify_eqd(struct > ocrdma_dev *dev, struct ocrdma_eq *eq, > > (eq[i].aic_obj.prev_eqd * 65)/100; > > } > > status = ocrdma_mbx_cmd(dev, (struct ocrdma_mqe *)cmd); > > - if (status) > > - goto mbx_err; > > -mbx_err: > > kfree(cmd); > > return status; > > } > > > -- > Doug Ledford <dledford@redhat.com> > GPG KeyID: 0E572FDD -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c index 0c9e959..e748090 100644 --- a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c +++ b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c @@ -1960,9 +1960,6 @@ static int ocrdma_mbx_reg_mr_cont(struct ocrdma_dev *dev, upper_32_bits(hwmr->pbl_table[i + pbl_offset].pa); } status = ocrdma_mbx_cmd(dev, (struct ocrdma_mqe *)cmd); - if (status) - goto mbx_err; -mbx_err: kfree(cmd); return status; } @@ -3044,9 +3041,6 @@ static int ocrdma_mbx_modify_eqd(struct ocrdma_dev *dev, struct ocrdma_eq *eq, (eq[i].aic_obj.prev_eqd * 65)/100; } status = ocrdma_mbx_cmd(dev, (struct ocrdma_mqe *)cmd); - if (status) - goto mbx_err; -mbx_err: kfree(cmd); return status; }
The same code is executed regardless status value, so these tests can be removed. Fix Coverity CID 1271151 and 1268788 Signed-off-by: Laurent Navet <laurent.navet@gmail.com> --- drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 6 ------ 1 file changed, 6 deletions(-)