diff mbox

[rdma-next,02/32] IB/core: Add SEND_LAST_INV and SEND_ONLY_INV opcodes

Message ID 1442410986-28232-3-git-send-email-kamalh@mellanox.com (mailing list archive)
State Superseded
Headers show

Commit Message

Kamal Heib Sept. 16, 2015, 1:42 p.m. UTC 
Intorduce Add SEND_LAST_INV and SEND_ONLY_INV opcodes in ib_pack.h to be
used by RXE for RC.

Signed-off-by: Kamal Heib <kamalh@mellanox.com>
Signed-off-by: Amir Vadai <amirv@mellanox.com>
Signed-off-by: Haggai Eran <haggaie@mellanox.com>
---
 include/rdma/ib_pack.h | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Christoph Hellwig Sept. 16, 2015, 1:44 p.m. UTC | #1 
On Wed, Sep 16, 2015 at 04:42:36PM +0300, Kamal Heib wrote:
> Intorduce Add SEND_LAST_INV and SEND_ONLY_INV opcodes in ib_pack.h to be
> used by RXE for RC.

Why does RXE need new public opcodes?

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jason Gunthorpe Sept. 16, 2015, 5:08 p.m. UTC | #2 
On Wed, Sep 16, 2015 at 06:44:24AM -0700, Christoph Hellwig wrote:
> On Wed, Sep 16, 2015 at 04:42:36PM +0300, Kamal Heib wrote:
> > Intorduce Add SEND_LAST_INV and SEND_ONLY_INV opcodes in ib_pack.h to be
> > used by RXE for RC.
> 
> Why does RXE need new public opcodes?

At some point after the original ib_pack.h was written the IBA was
extended with a few new opcodes for X with INVALIDATE, but ib_pack.h
was never updated. See page 246

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/include/rdma/ib_pack.h b/include/rdma/ib_pack.h
index 3883fcd..12bce2e 100644
--- a/include/rdma/ib_pack.h
+++ b/include/rdma/ib_pack.h
@@ -102,6 +102,8 @@  enum {
 	IB_OPCODE_ATOMIC_ACKNOWLEDGE                = 0x12,
 	IB_OPCODE_COMPARE_SWAP                      = 0x13,
 	IB_OPCODE_FETCH_ADD                         = 0x14,
+	IB_OPCODE_SEND_LAST_INV                     = 0x16,
+	IB_OPCODE_SEND_ONLY_INV                     = 0x17,
 
 	/* real constants follow -- see comment about above IB_OPCODE()
 	   macro for more details */
@@ -128,6 +130,8 @@  enum {
 	IB_OPCODE(RC, ATOMIC_ACKNOWLEDGE),
 	IB_OPCODE(RC, COMPARE_SWAP),
 	IB_OPCODE(RC, FETCH_ADD),
+	IB_OPCODE(RC, SEND_LAST_INV),
+	IB_OPCODE(RC, SEND_ONLY_INV),
 
 	/* UC */
 	IB_OPCODE(UC, SEND_FIRST),