| Message ID | 1443406123-15234-1-git-send-email-wen.gang.wang@oracle.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
Hi, Any comment on this patch? thanks, wengang ? 2015?09?28? 10:08, Wengang Wang ??: > There is a mis-order in mlx4 log. Fix it. > > Signed-off-by: Wengang Wang <wen.gang.wang@oracle.com> > --- > drivers/net/ethernet/mellanox/mlx4/cmd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/mellanox/mlx4/cmd.c b/drivers/net/ethernet/mellanox/mlx4/cmd.c > index 0a32020..150fbb3 100644 > --- a/drivers/net/ethernet/mellanox/mlx4/cmd.c > +++ b/drivers/net/ethernet/mellanox/mlx4/cmd.c > @@ -1010,7 +1010,7 @@ static int mlx4_MAD_IFC_wrapper(struct mlx4_dev *dev, int slave, > if (!(smp->mgmt_class == IB_MGMT_CLASS_SUBN_LID_ROUTED && > smp->method == IB_MGMT_METHOD_GET) || network_view) { > mlx4_err(dev, "Unprivileged slave %d is trying to execute a Subnet MGMT MAD, class 0x%x, method 0x%x, view=%s for attr 0x%x. Rejecting\n", > - slave, smp->method, smp->mgmt_class, > + slave, smp->mgmt_class, smp->method, > network_view ? "Network" : "Host", > be16_to_cpu(smp->attr_id)); > return -EPERM; -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 9/28/2015 5:08 AM, Wengang Wang wrote: > There is a mis-order in mlx4 log. Fix it. > > Signed-off-by: Wengang Wang<wen.gang.wang@oracle.com> Acked-by: Or Gerlitz <ogerlitz@mellanox.com> -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 9/28/2015 5:08 AM, Wengang Wang wrote: > There is a mis-order in mlx4 log. Fix it. > > Signed-off-by: Wengang Wang<wen.gang.wang@oracle.com> I wanted to ack it, but wait... We want commits to our driver to start with Capital letter so please resubmit with this title IB/mlx4: Use correct order of variables in log message You can add Acked-by: Or Gerlitz <ogerlitz@mellanox.com> -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Thanks Or. I will resend the revised(title) the patch with your Ack. thanks, wengang ? 2015?10?08? 12:52, Or Gerlitz ??: > On 9/28/2015 5:08 AM, Wengang Wang wrote: >> There is a mis-order in mlx4 log. Fix it. >> >> Signed-off-by: Wengang Wang<wen.gang.wang@oracle.com> > I wanted to ack it, but wait... > > We want commits to our driver to start with Capital letter so please > resubmit with this title > > IB/mlx4: Use correct order of variables in log message > > You can add Acked-by: Or Gerlitz <ogerlitz@mellanox.com> -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ethernet/mellanox/mlx4/cmd.c b/drivers/net/ethernet/mellanox/mlx4/cmd.c index 0a32020..150fbb3 100644 --- a/drivers/net/ethernet/mellanox/mlx4/cmd.c +++ b/drivers/net/ethernet/mellanox/mlx4/cmd.c @@ -1010,7 +1010,7 @@ static int mlx4_MAD_IFC_wrapper(struct mlx4_dev *dev, int slave, if (!(smp->mgmt_class == IB_MGMT_CLASS_SUBN_LID_ROUTED && smp->method == IB_MGMT_METHOD_GET) || network_view) { mlx4_err(dev, "Unprivileged slave %d is trying to execute a Subnet MGMT MAD, class 0x%x, method 0x%x, view=%s for attr 0x%x. Rejecting\n", - slave, smp->method, smp->mgmt_class, + slave, smp->mgmt_class, smp->method, network_view ? "Network" : "Host", be16_to_cpu(smp->attr_id)); return -EPERM;
There is a mis-order in mlx4 log. Fix it. Signed-off-by: Wengang Wang <wen.gang.wang@oracle.com> --- drivers/net/ethernet/mellanox/mlx4/cmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)