diff mbox

IB/usnic: Improve a failure message

Message ID 1449686539-29959-1-git-send-email-neescoba@cisco.com (mailing list archive)
State Accepted
Headers show

Commit Message

Nelson Escobar Dec. 9, 2015, 6:42 p.m. UTC 
Signed-off-by: Nelson Escobar <neescoba@cisco.com>
Reviewed-by: Dave Goodell <dgoodell@cisco.com>
---
 drivers/infiniband/hw/usnic/usnic_debugfs.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Doug Ledford Dec. 23, 2015, 4:12 p.m. UTC | #1 
On 12/09/2015 01:42 PM, Nelson Escobar wrote:
> Signed-off-by: Nelson Escobar <neescoba@cisco.com>
> Reviewed-by: Dave Goodell <dgoodell@cisco.com>
> ---
>  drivers/infiniband/hw/usnic/usnic_debugfs.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/infiniband/hw/usnic/usnic_debugfs.c b/drivers/infiniband/hw/usnic/usnic_debugfs.c
> index 5e55b8b..92dc66c 100644
> --- a/drivers/infiniband/hw/usnic/usnic_debugfs.c
> +++ b/drivers/infiniband/hw/usnic/usnic_debugfs.c
> @@ -157,8 +157,9 @@ void usnic_debugfs_flow_add(struct usnic_ib_qp_grp_flow *qp_flow)
>  							qp_flow,
>  							&flowinfo_ops);
>  	if (IS_ERR_OR_NULL(qp_flow->dbgfs_dentry)) {
> -		usnic_err("Failed to create dbg fs entry for flow %u\n",
> -				qp_flow->flow->flow_id);
> +		usnic_err("Failed to create dbg fs entry for flow %u with error %ld\n",
> +				qp_flow->flow->flow_id,
> +				PTR_ERR(qp_flow->dbgfs_dentry));
>  	}
>  }
>  
> 

Thanks, applied.
diff mbox

Patch

diff --git a/drivers/infiniband/hw/usnic/usnic_debugfs.c b/drivers/infiniband/hw/usnic/usnic_debugfs.c
index 5e55b8b..92dc66c 100644
--- a/drivers/infiniband/hw/usnic/usnic_debugfs.c
+++ b/drivers/infiniband/hw/usnic/usnic_debugfs.c
@@ -157,8 +157,9 @@  void usnic_debugfs_flow_add(struct usnic_ib_qp_grp_flow *qp_flow)
 							qp_flow,
 							&flowinfo_ops);
 	if (IS_ERR_OR_NULL(qp_flow->dbgfs_dentry)) {
-		usnic_err("Failed to create dbg fs entry for flow %u\n",
-				qp_flow->flow->flow_id);
+		usnic_err("Failed to create dbg fs entry for flow %u with error %ld\n",
+				qp_flow->flow->flow_id,
+				PTR_ERR(qp_flow->dbgfs_dentry));
 	}
 }