diff mbox

IB/usnic: Fix resource leak in error case

Message ID 1449686539-29959-5-git-send-email-neescoba@cisco.com (mailing list archive)
State Accepted
Headers show

Commit Message

Nelson Escobar Dec. 9, 2015, 6:42 p.m. UTC 
Signed-off-by: Dave Goodell <dgoodell@cisco.com>
Reviewed-by: Reese Faucette <rfaucett@cisco.com>
Reviewed-by: Xuyang Wang <xuywang@cisco.com>
Signed-off-by: Nelson Escobar <neescoba@cisco.com>
---
 drivers/infiniband/hw/usnic/usnic_ib_qp_grp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Doug Ledford Dec. 23, 2015, 4:14 p.m. UTC | #1 
On 12/09/2015 01:42 PM, Nelson Escobar wrote:
> Signed-off-by: Dave Goodell <dgoodell@cisco.com>
> Reviewed-by: Reese Faucette <rfaucett@cisco.com>
> Reviewed-by: Xuyang Wang <xuywang@cisco.com>
> Signed-off-by: Nelson Escobar <neescoba@cisco.com>
> ---
>  drivers/infiniband/hw/usnic/usnic_ib_qp_grp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/hw/usnic/usnic_ib_qp_grp.c b/drivers/infiniband/hw/usnic/usnic_ib_qp_grp.c
> index b306870..5f44b66 100644
> --- a/drivers/infiniband/hw/usnic/usnic_ib_qp_grp.c
> +++ b/drivers/infiniband/hw/usnic/usnic_ib_qp_grp.c
> @@ -575,7 +575,7 @@ alloc_res_chunk_list(struct usnic_vnic *vnic,
>  	return res_chunk_list;
>  
>  out_free_res:
> -	for (i--; i > 0; i--)
> +	for (i--; i >= 0; i--)
>  		usnic_vnic_put_resources(res_chunk_list[i]);
>  	kfree(res_chunk_list);
>  	return ERR_PTR(err);
> 

Thanks, applied.
diff mbox

Patch

diff --git a/drivers/infiniband/hw/usnic/usnic_ib_qp_grp.c b/drivers/infiniband/hw/usnic/usnic_ib_qp_grp.c
index b306870..5f44b66 100644
--- a/drivers/infiniband/hw/usnic/usnic_ib_qp_grp.c
+++ b/drivers/infiniband/hw/usnic/usnic_ib_qp_grp.c
@@ -575,7 +575,7 @@  alloc_res_chunk_list(struct usnic_vnic *vnic,
 	return res_chunk_list;
 
 out_free_res:
-	for (i--; i > 0; i--)
+	for (i--; i >= 0; i--)
 		usnic_vnic_put_resources(res_chunk_list[i]);
 	kfree(res_chunk_list);
 	return ERR_PTR(err);