diff mbox

IB/mlx4: Replace kfree with kvfree in mlx4_ib_destroy_srq

Message ID 1450320855-4570-1-git-send-email-wen.gang.wang@oracle.com (mailing list archive)
State Accepted
Headers show

Commit Message

Wengang Wang Dec. 17, 2015, 2:54 a.m. UTC
Commit 0ef2f05c7e02ff99c0b5b583d7dee2cd12b053f2 uses vmalloc for WR buffers
when needed and uses kvfree to free the buffers. It missed changing kfree
to kvfree in mlx4_ib_destroy_srq().

Reported-by: Matthew Finaly <matt@Mellanox.com>
Signed-off-by: Wengang Wang <wen.gang.wang@oracle.com>
---
 drivers/infiniband/hw/mlx4/srq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Doug Ledford Dec. 23, 2015, 7:35 p.m. UTC | #1
On 12/16/2015 09:54 PM, Wengang Wang wrote:
> Commit 0ef2f05c7e02ff99c0b5b583d7dee2cd12b053f2 uses vmalloc for WR buffers
> when needed and uses kvfree to free the buffers. It missed changing kfree
> to kvfree in mlx4_ib_destroy_srq().
> 
> Reported-by: Matthew Finaly <matt@Mellanox.com>
> Signed-off-by: Wengang Wang <wen.gang.wang@oracle.com>
> ---
>  drivers/infiniband/hw/mlx4/srq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/hw/mlx4/srq.c b/drivers/infiniband/hw/mlx4/srq.c
> index 8d133c4..c394376 100644
> --- a/drivers/infiniband/hw/mlx4/srq.c
> +++ b/drivers/infiniband/hw/mlx4/srq.c
> @@ -286,7 +286,7 @@ int mlx4_ib_destroy_srq(struct ib_srq *srq)
>  		mlx4_ib_db_unmap_user(to_mucontext(srq->uobject->context), &msrq->db);
>  		ib_umem_release(msrq->umem);
>  	} else {
> -		kfree(msrq->wrid);
> +		kvfree(msrq->wrid);
>  		mlx4_buf_free(dev->dev, msrq->msrq.max << msrq->msrq.wqe_shift,
>  			      &msrq->buf);
>  		mlx4_db_free(dev->dev, &msrq->db);
> 

Thanks, applied.
diff mbox

Patch

diff --git a/drivers/infiniband/hw/mlx4/srq.c b/drivers/infiniband/hw/mlx4/srq.c
index 8d133c4..c394376 100644
--- a/drivers/infiniband/hw/mlx4/srq.c
+++ b/drivers/infiniband/hw/mlx4/srq.c
@@ -286,7 +286,7 @@  int mlx4_ib_destroy_srq(struct ib_srq *srq)
 		mlx4_ib_db_unmap_user(to_mucontext(srq->uobject->context), &msrq->db);
 		ib_umem_release(msrq->umem);
 	} else {
-		kfree(msrq->wrid);
+		kvfree(msrq->wrid);
 		mlx4_buf_free(dev->dev, msrq->msrq.max << msrq->msrq.wqe_shift,
 			      &msrq->buf);
 		mlx4_db_free(dev->dev, &msrq->db);