| Message ID | 1450446906-10336-10-git-send-email-hch@lst.de (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
On 12/18/2015 3:55 PM, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig <hch@lst.de> > Reviewed-by: Sagi Grimberg <sagig@mellanox.com> > Reviewed-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com> [core] > Reviewed-by: Steve Wise <swise@opengridcomputing.com> Here, too, please avoid empty change logs to IB core patches. Or. > --- > include/rdma/ib_verbs.h | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h > index ea093ee..284916d 100644 > --- a/include/rdma/ib_verbs.h > +++ b/include/rdma/ib_verbs.h > @@ -1143,11 +1143,6 @@ enum ib_access_flags { > IB_ACCESS_ON_DEMAND = (1<<6), > }; > > -struct ib_phys_buf { > - u64 addr; > - u64 size; > -}; > - > /* > * XXX: these are apparently used for ->rereg_user_mr, no idea why they > * are hidden here instead of a uapi header! -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sun, Dec 20, 2015 at 09:37:38AM +0200, Or Gerlitz wrote: > On 12/18/2015 3:55 PM, Christoph Hellwig wrote: > >> Signed-off-by: Christoph Hellwig <hch@lst.de> >> Reviewed-by: Sagi Grimberg <sagig@mellanox.com> >> Reviewed-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com> [core] >> Reviewed-by: Steve Wise <swise@opengridcomputing.com> > > Here, too, please avoid empty change logs to IB core patches. You sound like a bot :) While I tend to ask people for better description a lot when I don't understand a patch without them I really don't see what you might want here. In general it really helps to say what you want to see. I can't see a useful explanation for removing an unused structure. But if you really want one and come up with a coherent sentence or two I can add it. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 12/20/2015 5:41 PM, Christoph Hellwig wrote: > I can't see a useful explanation for removing an unused structure. But if you > really want one and come up with a coherent sentence or two I can add it. patch title - IB/core: Remove struct ib_phys_buf change log: Remove struct ib_phys_buf since YYY where you need to fill few words for YYY, e.g not used anywhere ever, not used after you did cleanup ZZZ, something that can serve someone reading your patch -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h index ea093ee..284916d 100644 --- a/include/rdma/ib_verbs.h +++ b/include/rdma/ib_verbs.h @@ -1143,11 +1143,6 @@ enum ib_access_flags { IB_ACCESS_ON_DEMAND = (1<<6), }; -struct ib_phys_buf { - u64 addr; - u64 size; -}; - /* * XXX: these are apparently used for ->rereg_user_mr, no idea why they * are hidden here instead of a uapi header!