| Message ID | 1454532937-22649-1-git-send-email-clsoto@linux.vnet.ibm.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On 02/03/2016 03:55 PM, clsoto@linux.vnet.ibm.com wrote: > From: Carol L Soto <clsoto@linux.vnet.ibm.com> > > We are seeing this warning: at net/core/skbuff.c:4174 > and before commit a44878d10063 ("IB/ipoib: Use one linear skb in RX flow") > skb truesize was not being set when ipoib was using just one skb. > Removing this line avoids the warning when running tcp tests like iperf. > > Fixes: a44878d10063 ("IB/ipoib: Use one linear skb in RX flow") > Signed-off-by: Carol L Soto <clsoto@linux.vnet.ibm.com> > > --- > drivers/infiniband/ulp/ipoib/ipoib_ib.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/infiniband/ulp/ipoib/ipoib_ib.c b/drivers/infiniband/ulp/ipoib/ipoib_ib.c > index 5ea0c14..fa9c42f 100644 > --- a/drivers/infiniband/ulp/ipoib/ipoib_ib.c > +++ b/drivers/infiniband/ulp/ipoib/ipoib_ib.c > @@ -245,8 +245,6 @@ static void ipoib_ib_handle_rx_wc(struct net_device *dev, struct ib_wc *wc) > skb_reset_mac_header(skb); > skb_pull(skb, IPOIB_ENCAP_LEN); > > - skb->truesize = SKB_TRUESIZE(skb->len); > - > ++dev->stats.rx_packets; > dev->stats.rx_bytes += skb->len; > > Thanks, applied.
diff --git a/drivers/infiniband/ulp/ipoib/ipoib_ib.c b/drivers/infiniband/ulp/ipoib/ipoib_ib.c index 5ea0c14..fa9c42f 100644 --- a/drivers/infiniband/ulp/ipoib/ipoib_ib.c +++ b/drivers/infiniband/ulp/ipoib/ipoib_ib.c @@ -245,8 +245,6 @@ static void ipoib_ib_handle_rx_wc(struct net_device *dev, struct ib_wc *wc) skb_reset_mac_header(skb); skb_pull(skb, IPOIB_ENCAP_LEN); - skb->truesize = SKB_TRUESIZE(skb->len); - ++dev->stats.rx_packets; dev->stats.rx_bytes += skb->len;