diff mbox

[v1] IB/core: Don't drain the receive queue for srq attached queue-pair

Message ID 1461699255-23029-1-git-send-email-sagi@grimberg.me (mailing list archive)
State Accepted
Headers show

Commit Message

Sagi Grimberg April 26, 2016, 7:34 p.m. UTC
SRQ attached QPs don't have a dedicated RQ, hence we should not
try to drain the QP receive queue.

Fixes: 765d67748bcf ("IB: new common API for draining queues")
Reviewed-by: Steve Wise <swise@opengridcomputing.com>
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
---
Changes from v0:
- Give a less idiotic patch description

 drivers/infiniband/core/verbs.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Bart Van Assche April 26, 2016, 8:04 p.m. UTC | #1
On 04/26/2016 12:34 PM, Sagi Grimberg wrote:
> SRQ attached QPs don't have a dedicated RQ, hence we should not
> try to drain the QP receive queue.

Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/infiniband/core/verbs.c b/drivers/infiniband/core/verbs.c
index 769b000e8360..566bfb31cadb 100644
--- a/drivers/infiniband/core/verbs.c
+++ b/drivers/infiniband/core/verbs.c
@@ -1897,6 +1897,7 @@  EXPORT_SYMBOL(ib_drain_rq);
 void ib_drain_qp(struct ib_qp *qp)
 {
 	ib_drain_sq(qp);
-	ib_drain_rq(qp);
+	if (!qp->srq)
+		ib_drain_rq(qp);
 }
 EXPORT_SYMBOL(ib_drain_qp);