diff mbox

[RFC,rdma-next,2/3] IB/core: Export mlx5 vendor specific strucutres

Message ID 1473841649-8923-3-git-send-email-leon@kernel.org (mailing list archive)
State RFC
Headers show

Commit Message

Leon Romanovsky Sept. 14, 2016, 8:27 a.m. UTC
Signed-off-by: Leon Romanovsky <leon@kernel.org>
---
 include/uapi/rdma/Kbuild           | 1 +
 include/uapi/rdma/providers/Kbuild | 2 ++
 2 files changed, 3 insertions(+)
 create mode 100644 include/uapi/rdma/providers/Kbuild

--
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Christoph Hellwig Sept. 15, 2016, 6:13 a.m. UTC | #1
> index 4edb0f2..e804cc3 100644
> --- a/include/uapi/rdma/Kbuild
> +++ b/include/uapi/rdma/Kbuild
> @@ -7,3 +7,4 @@ header-y += rdma_netlink.h
>  header-y += rdma_user_cm.h
>  header-y += hfi/
>  header-y += rdma_user_rxe.h
> +header-y += providers/

Can we avoid the horrible providers name?  The directories for drivers
in the source tree so far are called hw/ and sw/ so we should stick to
that here as well.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Leon Romanovsky Sept. 15, 2016, 6:25 a.m. UTC | #2
On Wed, Sep 14, 2016 at 11:13:36PM -0700, Christoph Hellwig wrote:
> > index 4edb0f2..e804cc3 100644
> > --- a/include/uapi/rdma/Kbuild
> > +++ b/include/uapi/rdma/Kbuild
> > @@ -7,3 +7,4 @@ header-y += rdma_netlink.h
> >  header-y += rdma_user_cm.h
> >  header-y += hfi/
> >  header-y += rdma_user_rxe.h
> > +header-y += providers/
>
> Can we avoid the horrible providers name?  The directories for drivers
> in the source tree so far are called hw/ and sw/ so we should stick to
> that here as well.

I don't like providers name too, but I don't want to stick to
drivers/.../{hw|sw} either. Any redesign there will lead to
disconnection between UAPI directory and internal structure.
Jason Gunthorpe Sept. 15, 2016, 4:17 p.m. UTC | #3
On Wed, Sep 14, 2016 at 11:13:36PM -0700, Christoph Hellwig wrote:
> > index 4edb0f2..e804cc3 100644
> > +++ b/include/uapi/rdma/Kbuild
> > @@ -7,3 +7,4 @@ header-y += rdma_netlink.h
> >  header-y += rdma_user_cm.h
> >  header-y += hfi/
> >  header-y += rdma_user_rxe.h
> > +header-y += providers/
> 
> Can we avoid the horrible providers name?  The directories for drivers
> in the source tree so far are called hw/ and sw/ so we should stick to
> that here as well.

I also don't like the provider name, it is not consistent with Linux.

Not sure hw/sw is any better, other subsystems don't split their
drivers like that.

Just driver/?

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/include/uapi/rdma/Kbuild b/include/uapi/rdma/Kbuild
index 4edb0f2..e804cc3 100644
--- a/include/uapi/rdma/Kbuild
+++ b/include/uapi/rdma/Kbuild
@@ -7,3 +7,4 @@  header-y += rdma_netlink.h
 header-y += rdma_user_cm.h
 header-y += hfi/
 header-y += rdma_user_rxe.h
+header-y += providers/
diff --git a/include/uapi/rdma/providers/Kbuild b/include/uapi/rdma/providers/Kbuild
new file mode 100644
index 0000000..d863744
--- /dev/null
+++ b/include/uapi/rdma/providers/Kbuild
@@ -0,0 +1,2 @@ 
+# UAPI Header export list
+header-y += mlx5-abi.h