| Message ID | 1475665714-5885-1-git-send-email-leon@kernel.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
On Wed, Oct 05, 2016 at 02:08:34PM +0300, Leon Romanovsky wrote: > The attribute HIDDEN was declared is almost every provider, but it wasn't > used, except in libibverbs. Let's remove it. There is no reason for libibverbs to use this either, please remove it completely. All libraries and providers use a linker map file which superceeds the hidden attribute. Reviewed-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com> Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/libhfi1verbs/src/hfiverbs.h b/libhfi1verbs/src/hfiverbs.h index deebc65..e82ba2b 100644 --- a/libhfi1verbs/src/hfiverbs.h +++ b/libhfi1verbs/src/hfiverbs.h @@ -67,8 +67,6 @@ #include <infiniband/arch.h> #include <infiniband/verbs.h> -#define HIDDEN __attribute__((visibility ("hidden"))) - #define PFX "hfi1: " struct hfi1_device { diff --git a/libi40iw/src/i40iw_umain.h b/libi40iw/src/i40iw_umain.h index 13d3da8..719aefc 100644 --- a/libi40iw/src/i40iw_umain.h +++ b/libi40iw/src/i40iw_umain.h @@ -54,8 +54,6 @@ #define unlikely(x) __builtin_expect((x), 0) #endif -#define HIDDEN __attribute__((visibility("hidden"))) - #define PFX "libi40iw-" #define I40IW_BASE_PUSH_PAGE 1 diff --git a/libipathverbs/src/ipathverbs.h b/libipathverbs/src/ipathverbs.h index 05e1c71..ff25854 100644 --- a/libipathverbs/src/ipathverbs.h +++ b/libipathverbs/src/ipathverbs.h @@ -47,8 +47,6 @@ #include <infiniband/arch.h> #include <infiniband/verbs.h> -#define HIDDEN __attribute__((visibility ("hidden"))) - #define PFX "ipath: " struct ipath_device { diff --git a/libmlx4/src/mlx4.h b/libmlx4/src/mlx4.h index 1855cfb..95a6521 100644 --- a/libmlx4/src/mlx4.h +++ b/libmlx4/src/mlx4.h @@ -49,8 +49,6 @@ #include <valgrind/memcheck.h> -#define HIDDEN __attribute__((visibility ("hidden"))) - #define PFX "mlx4: " enum { diff --git a/libmlx5/src/mlx5.h b/libmlx5/src/mlx5.h index c209a79..f8674c7 100644 --- a/libmlx5/src/mlx5.h +++ b/libmlx5/src/mlx5.h @@ -54,8 +54,6 @@ #include <valgrind/memcheck.h> -#define HIDDEN __attribute__((visibility("hidden"))) - #ifdef HAVE_FUNC_ATTRIBUTE_ALWAYS_INLINE #define ALWAYS_INLINE __attribute__((always_inline)) #else diff --git a/libmthca/src/mthca.h b/libmthca/src/mthca.h index da53010..b4b0b6a 100644 --- a/libmthca/src/mthca.h +++ b/libmthca/src/mthca.h @@ -41,8 +41,6 @@ #include <valgrind/memcheck.h> -#define HIDDEN __attribute__((visibility ("hidden"))) - #define PFX "mthca: " enum mthca_hca_type { diff --git a/libnes/src/nes_umain.h b/libnes/src/nes_umain.h index 9129982..f3cc348 100644 --- a/libnes/src/nes_umain.h +++ b/libnes/src/nes_umain.h @@ -48,8 +48,6 @@ #define unlikely(x) __builtin_expect((x),0) #endif -#define HIDDEN __attribute__((visibility ("hidden"))) - #define PFX "libnes: " #define NES_QP_MMAP 1
The attribute HIDDEN was declared is almost every provider, but it wasn't used, except in libibverbs. Let's remove it. Signed-off-by: Leon Romanovsky <leon@kernel.org> --- libhfi1verbs/src/hfiverbs.h | 2 -- libi40iw/src/i40iw_umain.h | 2 -- libipathverbs/src/ipathverbs.h | 2 -- libmlx4/src/mlx4.h | 2 -- libmlx5/src/mlx5.h | 2 -- libmthca/src/mthca.h | 2 -- libnes/src/nes_umain.h | 2 -- 7 files changed, 14 deletions(-) -- 2.7.4 -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html