diff mbox

[rdma-next,V1,06/17] IB/hfi1: Remove debug prints after allocation failure

Message ID 1478184265-9620-7-git-send-email-leon@kernel.org (mailing list archive)
State Accepted
Headers show

Commit Message

Leon Romanovsky Nov. 3, 2016, 2:44 p.m. UTC
The prints after [k|v][m|z|c]alloc() functions are not needed,
because in case of failure, allocator will print their internal
error prints anyway.

Signed-off-by: Leon Romanovsky <leon@kernel.org>
---
 drivers/infiniband/hw/hfi1/pio.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Dennis Dalessandro Nov. 12, 2016, 4:04 a.m. UTC | #1
T24gVGh1LCAyMDE2LTExLTAzIGF0IDE2OjQ0ICswMjAwLCBMZW9uIFJvbWFub3Zza3kgd3JvdGU6
DQo+IFRoZSBwcmludHMgYWZ0ZXIgW2t8dl1bbXx6fGNdYWxsb2MoKSBmdW5jdGlvbnMgYXJlIG5v
dCBuZWVkZWQsDQo+IGJlY2F1c2UgaW4gY2FzZSBvZiBmYWlsdXJlLCBhbGxvY2F0b3Igd2lsbCBw
cmludCB0aGVpciBpbnRlcm5hbA0KPiBlcnJvciBwcmludHMgYW55d2F5Lg0KPiANCj4gU2lnbmVk
LW9mZi1ieTogTGVvbiBSb21hbm92c2t5IDxsZW9uQGtlcm5lbC5vcmc+DQoNCkFja2VkLWJ5OiBE
ZW5uaXMgRGFsZXNzYW5kcm8gPGRlbm5pcy5kYWxlc3NhbmRyb0BpbnRlbC5jb20+
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Doug Ledford Dec. 3, 2016, 6:31 p.m. UTC | #2
On Sat, 2016-11-12 at 04:04 +0000, Dalessandro, Dennis wrote:
> On Thu, 2016-11-03 at 16:44 +0200, Leon Romanovsky wrote:
> > 
> > The prints after [k|v][m|z|c]alloc() functions are not needed,
> > because in case of failure, allocator will print their internal
> > error prints anyway.
> > 
> > Signed-off-by: Leon Romanovsky <leon@kernel.org>
> 
> Acked-by: Dennis Dalessandro <dennis.dalessandro@intel.com>

Hi Denny,

Your Ack was not recorded by patchworks.  Something about the way it
was signed or something like that.  All patchworks saw was what looked
like an encyrpted or signed block, with no legible text.
diff mbox

Patch

diff --git a/drivers/infiniband/hw/hfi1/pio.c b/drivers/infiniband/hw/hfi1/pio.c
index 50a3a36..d15ffed 100644
--- a/drivers/infiniband/hw/hfi1/pio.c
+++ b/drivers/infiniband/hw/hfi1/pio.c
@@ -2053,7 +2053,6 @@  int init_credit_return(struct hfi1_devdata *dd)
 		sizeof(struct credit_return_base),
 		GFP_KERNEL);
 	if (!dd->cr_base) {
-		dd_dev_err(dd, "Unable to allocate credit return base\n");
 		ret = -ENOMEM;
 		goto done;
 	}