| Message ID | 1478765808-12517-1-git-send-email-leon@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com> On Thu, Nov 10, 2016 at 10:16:48AM +0200, Leon Romanovsky wrote: > From: Kamal Heib <kamalh@mellanox.com> > > Remove the warning print of "can't use of GFP_NOIO" to avoid prints in > each QP creation when devices aren't supporting IB_QP_CREATE_USE_GFP_NOIO. > > This print become more annoying when the IPoIB interface is configured > to work in connected mode. > > Fixes: 09b93088d750 ('IB: Add a QP creation flag to use GFP_NOIO allocations') > Signed-off-by: Kamal Heib <kamalh@mellanox.com> > Signed-off-by: Leon Romanovsky <leon@kernel.org> > --- > drivers/infiniband/ulp/ipoib/ipoib_cm.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/infiniband/ulp/ipoib/ipoib_cm.c b/drivers/infiniband/ulp/ipoib/ipoib_cm.c > index 4ad297d..50c9772 100644 > --- a/drivers/infiniband/ulp/ipoib/ipoib_cm.c > +++ b/drivers/infiniband/ulp/ipoib/ipoib_cm.c > @@ -1053,8 +1053,6 @@ static struct ib_qp *ipoib_cm_create_tx_qp(struct net_device *dev, struct ipoib_ > > tx_qp = ib_create_qp(priv->pd, &attr); > if (PTR_ERR(tx_qp) == -EINVAL) { > - ipoib_warn(priv, "can't use GFP_NOIO for QPs on device %s, using GFP_KERNEL\n", > - priv->ca->name); > attr.create_flags &= ~IB_QP_CREATE_USE_GFP_NOIO; > tx_qp = ib_create_qp(priv->pd, &attr); > } > -- > 2.7.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Nov 10, 2016 at 10:16 AM, Leon Romanovsky wrote: > From: Kamal Heib <kamalh@mellanox.com> > > Remove the warning print of "can't use of GFP_NOIO" to avoid prints in > each QP creation when devices aren't supporting IB_QP_CREATE_USE_GFP_NOIO. > > This print become more annoying when the IPoIB interface is configured > to work in connected mode. > > Fixes: 09b93088d750 ('IB: Add a QP creation flag to use GFP_NOIO allocations') Hi Kamal, I don't think you're fixing a bug in this commit... you find the print annoying and you remove it, okay, maybe we can do that. Why not leave it in rate-limited manner? can you elaborate what was that deeply annoying with getting the warning? > --- a/drivers/infiniband/ulp/ipoib/ipoib_cm.c > +++ b/drivers/infiniband/ulp/ipoib/ipoib_cm.c > @@ -1053,8 +1053,6 @@ static struct ib_qp *ipoib_cm_create_tx_qp(struct net_device *dev, struct ipoib_ > > tx_qp = ib_create_qp(priv->pd, &attr); > if (PTR_ERR(tx_qp) == -EINVAL) { > - ipoib_warn(priv, "can't use GFP_NOIO for QPs on device %s, using GFP_KERNEL\n", > - priv->ca->name); > attr.create_flags &= ~IB_QP_CREATE_USE_GFP_NOIO; > tx_qp = ib_create_qp(priv->pd, &attr); > } -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Nov 18, 2016 at 12:30 AM, Or Gerlitz <gerlitz.or@gmail.com> wrote: > On Thu, Nov 10, 2016 at 10:16 AM, Leon Romanovsky wrote: >> From: Kamal Heib <kamalh@mellanox.com> >> >> Remove the warning print of "can't use of GFP_NOIO" to avoid prints in >> each QP creation when devices aren't supporting IB_QP_CREATE_USE_GFP_NOIO. >> >> This print become more annoying when the IPoIB interface is configured >> to work in connected mode. >> >> Fixes: 09b93088d750 ('IB: Add a QP creation flag to use GFP_NOIO allocations') > > Hi Kamal, Hi Or :) > > I don't think you're fixing a bug in this commit... you find the print > annoying and you remove it, okay, maybe we can do that. Why not leave > it in rate-limited manner? can you elaborate what was that deeply > annoying with getting the warning? > It's really annoying when you have multiple ipoib interfaces and pkeys, so the dmesg will look like the following: [933236.858739] mlx5_ib0: can't use GFP_NOIO for QPs on device mlx5_0, using GFP_KERNEL [933407.571911] mlx5_ib0.8002: can't use GFP_NOIO for QPs on device mlx5_0, using GFP_KERNEL [933634.121955] mlx5_ib0.8006: can't use GFP_NOIO for QPs on device mlx5_0, using GFP_KERNEL [934167.851164] mlx5_ib0.8004: can't use GFP_NOIO for QPs on device mlx5_0, using GFP_KERNEL [934936.645002] mlx5_ib0.8002: can't use GFP_NOIO for QPs on device mlx5_0, using GFP_KERNEL >> --- a/drivers/infiniband/ulp/ipoib/ipoib_cm.c >> +++ b/drivers/infiniband/ulp/ipoib/ipoib_cm.c >> @@ -1053,8 +1053,6 @@ static struct ib_qp *ipoib_cm_create_tx_qp(struct net_device *dev, struct ipoib_ >> >> tx_qp = ib_create_qp(priv->pd, &attr); >> if (PTR_ERR(tx_qp) == -EINVAL) { >> - ipoib_warn(priv, "can't use GFP_NOIO for QPs on device %s, using GFP_KERNEL\n", >> - priv->ca->name); >> attr.create_flags &= ~IB_QP_CREATE_USE_GFP_NOIO; >> tx_qp = ib_create_qp(priv->pd, &attr); >> } > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/infiniband/ulp/ipoib/ipoib_cm.c b/drivers/infiniband/ulp/ipoib/ipoib_cm.c index 4ad297d..50c9772 100644 --- a/drivers/infiniband/ulp/ipoib/ipoib_cm.c +++ b/drivers/infiniband/ulp/ipoib/ipoib_cm.c @@ -1053,8 +1053,6 @@ static struct ib_qp *ipoib_cm_create_tx_qp(struct net_device *dev, struct ipoib_ tx_qp = ib_create_qp(priv->pd, &attr); if (PTR_ERR(tx_qp) == -EINVAL) { - ipoib_warn(priv, "can't use GFP_NOIO for QPs on device %s, using GFP_KERNEL\n", - priv->ca->name); attr.create_flags &= ~IB_QP_CREATE_USE_GFP_NOIO; tx_qp = ib_create_qp(priv->pd, &attr); }