| Message ID | 1494413139-11883-15-git-send-email-selvin.xavier@broadcom.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
On 5/10/2017 6:45 AM, Selvin Xavier wrote: > Update the driver version to the scheme used in the internal > development branches. See the feedback [1] we got from Greg KH on a similar patch. [1] https://patchwork.kernel.org/patch/7490321/ > Signed-off-by: Selvin Xavier <selvin.xavier@broadcom.com> > --- > drivers/infiniband/hw/bnxt_re/bnxt_re.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/infiniband/hw/bnxt_re/bnxt_re.h b/drivers/infiniband/hw/bnxt_re/bnxt_re.h > index 30bff05..9041c23b 100644 > --- a/drivers/infiniband/hw/bnxt_re/bnxt_re.h > +++ b/drivers/infiniband/hw/bnxt_re/bnxt_re.h > @@ -40,7 +40,7 @@ > #ifndef __BNXT_RE_H__ > #define __BNXT_RE_H__ > #define ROCE_DRV_MODULE_NAME "bnxt_re" > -#define ROCE_DRV_MODULE_VERSION "1.0.0" > +#define ROCE_DRV_MODULE_VERSION "20.6.1.0u" > > #define BNXT_RE_DESC "Broadcom NetXtreme-C/E RoCE Driver" > > -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, May 10, 2017 at 11:06:31AM -0400, Dennis Dalessandro wrote: > On 5/10/2017 6:45 AM, Selvin Xavier wrote: > > Update the driver version to the scheme used in the internal > > development branches. > > See the feedback [1] we got from Greg KH on a similar patch. > > [1] https://patchwork.kernel.org/patch/7490321/ Yeah, the things go worse when this driver ported to old kernel. This numbers are entirely useless. > > > Signed-off-by: Selvin Xavier <selvin.xavier@broadcom.com> > > --- > > drivers/infiniband/hw/bnxt_re/bnxt_re.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/infiniband/hw/bnxt_re/bnxt_re.h b/drivers/infiniband/hw/bnxt_re/bnxt_re.h > > index 30bff05..9041c23b 100644 > > --- a/drivers/infiniband/hw/bnxt_re/bnxt_re.h > > +++ b/drivers/infiniband/hw/bnxt_re/bnxt_re.h > > @@ -40,7 +40,7 @@ > > #ifndef __BNXT_RE_H__ > > #define __BNXT_RE_H__ > > #define ROCE_DRV_MODULE_NAME "bnxt_re" > > -#define ROCE_DRV_MODULE_VERSION "1.0.0" > > +#define ROCE_DRV_MODULE_VERSION "20.6.1.0u" > > > > #define BNXT_RE_DESC "Broadcom NetXtreme-C/E RoCE Driver" > > > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
Thanks Leon and Dennis for your comments. The main intention of this patch is to easily map the upstream driver to the level of supported features in the internal code base. I understand the point you and others are mentioning while porting to older kernels or during the bug fixes/feature additions from other contributors. But, can we consider it as just a number to enable vendors to track their base branch? If you still feel that this patch doesn't make sense, please let me know. I will post a v2 after dropping the change. Thanks, Selvin On Wed, May 10, 2017 at 9:24 PM, Leon Romanovsky <leon@kernel.org> wrote: > On Wed, May 10, 2017 at 11:06:31AM -0400, Dennis Dalessandro wrote: >> On 5/10/2017 6:45 AM, Selvin Xavier wrote: >> > Update the driver version to the scheme used in the internal >> > development branches. >> >> See the feedback [1] we got from Greg KH on a similar patch. >> >> [1] https://patchwork.kernel.org/patch/7490321/ > > Yeah, the things go worse when this driver ported to old kernel. This > numbers are entirely useless. > >> >> > Signed-off-by: Selvin Xavier <selvin.xavier@broadcom.com> >> > --- >> > drivers/infiniband/hw/bnxt_re/bnxt_re.h | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > diff --git a/drivers/infiniband/hw/bnxt_re/bnxt_re.h b/drivers/infiniband/hw/bnxt_re/bnxt_re.h >> > index 30bff05..9041c23b 100644 >> > --- a/drivers/infiniband/hw/bnxt_re/bnxt_re.h >> > +++ b/drivers/infiniband/hw/bnxt_re/bnxt_re.h >> > @@ -40,7 +40,7 @@ >> > #ifndef __BNXT_RE_H__ >> > #define __BNXT_RE_H__ >> > #define ROCE_DRV_MODULE_NAME "bnxt_re" >> > -#define ROCE_DRV_MODULE_VERSION "1.0.0" >> > +#define ROCE_DRV_MODULE_VERSION "20.6.1.0u" >> > >> > #define BNXT_RE_DESC "Broadcom NetXtreme-C/E RoCE Driver" >> > >> > >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, May 11, 2017 at 10:52:31AM +0530, Selvin Xavier wrote: > Thanks Leon and Dennis for your comments. > > The main intention of this patch is to easily map the upstream driver > to the level of supported features in the > internal code base. I understand the point you and others are > mentioning while porting to older kernels or during > the bug fixes/feature additions from other contributors. But, can we > consider it as just a number to enable vendors > to track their base branch? It is up to you, just wanted to warn you that in long run it won't give you any information. We are in similar situation and decided to change versions in really rare situations, like addition of new driver. In other cases, it is useless. > > If you still feel that this patch doesn't make sense, please let me > know. I will post a v2 after dropping the change. > > Thanks, > Selvin > > On Wed, May 10, 2017 at 9:24 PM, Leon Romanovsky <leon@kernel.org> wrote: > > On Wed, May 10, 2017 at 11:06:31AM -0400, Dennis Dalessandro wrote: > >> On 5/10/2017 6:45 AM, Selvin Xavier wrote: > >> > Update the driver version to the scheme used in the internal > >> > development branches. > >> > >> See the feedback [1] we got from Greg KH on a similar patch. > >> > >> [1] https://patchwork.kernel.org/patch/7490321/ > > > > Yeah, the things go worse when this driver ported to old kernel. This > > numbers are entirely useless. > > > >> > >> > Signed-off-by: Selvin Xavier <selvin.xavier@broadcom.com> > >> > --- > >> > drivers/infiniband/hw/bnxt_re/bnxt_re.h | 2 +- > >> > 1 file changed, 1 insertion(+), 1 deletion(-) > >> > > >> > diff --git a/drivers/infiniband/hw/bnxt_re/bnxt_re.h b/drivers/infiniband/hw/bnxt_re/bnxt_re.h > >> > index 30bff05..9041c23b 100644 > >> > --- a/drivers/infiniband/hw/bnxt_re/bnxt_re.h > >> > +++ b/drivers/infiniband/hw/bnxt_re/bnxt_re.h > >> > @@ -40,7 +40,7 @@ > >> > #ifndef __BNXT_RE_H__ > >> > #define __BNXT_RE_H__ > >> > #define ROCE_DRV_MODULE_NAME "bnxt_re" > >> > -#define ROCE_DRV_MODULE_VERSION "1.0.0" > >> > +#define ROCE_DRV_MODULE_VERSION "20.6.1.0u" > >> > > >> > #define BNXT_RE_DESC "Broadcom NetXtreme-C/E RoCE Driver" > >> > > >> > > >> -- > >> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > >> the body of a message to majordomo@vger.kernel.org > >> More majordomo info at http://vger.kernel.org/majordomo-info.html > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
On 5/11/2017 4:27 AM, Leon Romanovsky wrote: > On Thu, May 11, 2017 at 10:52:31AM +0530, Selvin Xavier wrote: >> Thanks Leon and Dennis for your comments. >> >> The main intention of this patch is to easily map the upstream driver >> to the level of supported features in the >> internal code base. I understand the point you and others are >> mentioning while porting to older kernels or during >> the bug fixes/feature additions from other contributors. But, can we >> consider it as just a number to enable vendors >> to track their base branch? > > It is up to you, just wanted to warn you that in long run it won't give > you any information. We are in similar situation and decided to change > versions in really rare situations, like addition of new driver. In other > cases, it is useless. Personally it doesn't bother me one bit. I mean, hey we did it in our driver. But it was NAKed by the maintainer of the staging tree when our driver was there, so just wanted to point out that some in the community are pretty strongly opposed to it. -Denny -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/infiniband/hw/bnxt_re/bnxt_re.h b/drivers/infiniband/hw/bnxt_re/bnxt_re.h index 30bff05..9041c23b 100644 --- a/drivers/infiniband/hw/bnxt_re/bnxt_re.h +++ b/drivers/infiniband/hw/bnxt_re/bnxt_re.h @@ -40,7 +40,7 @@ #ifndef __BNXT_RE_H__ #define __BNXT_RE_H__ #define ROCE_DRV_MODULE_NAME "bnxt_re" -#define ROCE_DRV_MODULE_VERSION "1.0.0" +#define ROCE_DRV_MODULE_VERSION "20.6.1.0u" #define BNXT_RE_DESC "Broadcom NetXtreme-C/E RoCE Driver"
Update the driver version to the scheme used in the internal development branches. Signed-off-by: Selvin Xavier <selvin.xavier@broadcom.com> --- drivers/infiniband/hw/bnxt_re/bnxt_re.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)