diff mbox

[rdma-next,3/8] IB/IPoIB: Increase local_lid to 32 bits

Message ID 1494458576-6816-4-git-send-email-dasaratharaman.chandramouli@intel.com (mailing list archive)
State Superseded
Headers show

Commit Message

Dasaratharaman Chandramouli May 10, 2017, 11:22 p.m. UTC
IPoIB contains local_lid field which is 16 bits in
length, increase it to 32 bits.

Reviewed-by: Ira Weiny <ira.weiny@intel.com>
Signed-off-by: Dasaratharaman Chandramouli <dasaratharaman.chandramouli@intel.com>
Signed-off-by: Don Hiatt <don.hiatt@intel.com>
---
 drivers/infiniband/ulp/ipoib/ipoib.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Yuval Shaia May 11, 2017, 8:41 a.m. UTC | #1
On Wed, May 10, 2017 at 07:22:51PM -0400, Dasaratharaman Chandramouli wrote:
> IPoIB contains local_lid field which is 16 bits in
> length, increase it to 32 bits.

Is it IPoIB thing only? i see it also in struct ib_wc

> 
> Reviewed-by: Ira Weiny <ira.weiny@intel.com>
> Signed-off-by: Dasaratharaman Chandramouli <dasaratharaman.chandramouli@intel.com>
> Signed-off-by: Don Hiatt <don.hiatt@intel.com>
> ---
>  drivers/infiniband/ulp/ipoib/ipoib.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/ulp/ipoib/ipoib.h b/drivers/infiniband/ulp/ipoib/ipoib.h
> index ff50a7b..9e73810 100644
> --- a/drivers/infiniband/ulp/ipoib/ipoib.h
> +++ b/drivers/infiniband/ulp/ipoib/ipoib.h
> @@ -366,7 +366,7 @@ struct ipoib_dev_priv {
>  	u32		  qkey;
>  
>  	union ib_gid local_gid;
> -	u16	     local_lid;
> +	u32	     local_lid;
>  
>  	unsigned int admin_mtu;
>  	unsigned int mcast_mtu;
> -- 
> 1.8.3.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Yuval Shaia May 11, 2017, 8:49 a.m. UTC | #2
On Thu, May 11, 2017 at 11:41:26AM +0300, Yuval Shaia wrote:
> On Wed, May 10, 2017 at 07:22:51PM -0400, Dasaratharaman Chandramouli wrote:
> > IPoIB contains local_lid field which is 16 bits in
> > length, increase it to 32 bits.
> 
> Is it IPoIB thing only? i see it also in struct ib_wc

Sorry, please ignore this question.

Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com>


> 
> > 
> > Reviewed-by: Ira Weiny <ira.weiny@intel.com>
> > Signed-off-by: Dasaratharaman Chandramouli <dasaratharaman.chandramouli@intel.com>
> > Signed-off-by: Don Hiatt <don.hiatt@intel.com>
> > ---
> >  drivers/infiniband/ulp/ipoib/ipoib.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/infiniband/ulp/ipoib/ipoib.h b/drivers/infiniband/ulp/ipoib/ipoib.h
> > index ff50a7b..9e73810 100644
> > --- a/drivers/infiniband/ulp/ipoib/ipoib.h
> > +++ b/drivers/infiniband/ulp/ipoib/ipoib.h
> > @@ -366,7 +366,7 @@ struct ipoib_dev_priv {
> >  	u32		  qkey;
> >  
> >  	union ib_gid local_gid;
> > -	u16	     local_lid;
> > +	u32	     local_lid;
> >  
> >  	unsigned int admin_mtu;
> >  	unsigned int mcast_mtu;
> > -- 
> > 1.8.3.1
> > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/infiniband/ulp/ipoib/ipoib.h b/drivers/infiniband/ulp/ipoib/ipoib.h
index ff50a7b..9e73810 100644
--- a/drivers/infiniband/ulp/ipoib/ipoib.h
+++ b/drivers/infiniband/ulp/ipoib/ipoib.h
@@ -366,7 +366,7 @@  struct ipoib_dev_priv {
 	u32		  qkey;
 
 	union ib_gid local_gid;
-	u16	     local_lid;
+	u32	     local_lid;
 
 	unsigned int admin_mtu;
 	unsigned int mcast_mtu;