diff mbox

[V3,for-next,14/15] RDMA/bnxt_re: Sync up the module version to internal release version

Message ID 1495169074-12641-15-git-send-email-selvin.xavier@broadcom.com (mailing list archive)
State Superseded
Headers show

Commit Message

Selvin Xavier May 19, 2017, 4:44 a.m. UTC
Updates the module version. The new version number will enable us to
map the upstream driver to the level of supported features in the
internal code base.

Signed-off-by: Selvin Xavier <selvin.xavier@broadcom.com>
---
v2 -> v3:
	- Modified the commit message

 drivers/infiniband/hw/bnxt_re/bnxt_re.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Dennis Dalessandro May 19, 2017, 12:48 p.m. UTC | #1
On 5/19/2017 12:44 AM, Selvin Xavier wrote:
> Updates the module version. The new version number will enable us to
> map the upstream driver to the level of supported features in the
> internal code base.

Your internal code base doesn't mean anything at all to the kernel. If 
you don't have a valid reason why the kernel needs this version number 
get rid of this patch please.

-Denny

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Selvin Xavier May 22, 2017, 10:03 a.m. UTC | #2
Hi Dennis,
 I am dropping this patch from this series. Posting v4 without this patch.
Thanks,
Selvin Xavier

On Fri, May 19, 2017 at 6:18 PM, Dennis Dalessandro
<dennis.dalessandro@intel.com> wrote:
> On 5/19/2017 12:44 AM, Selvin Xavier wrote:
>>
>> Updates the module version. The new version number will enable us to
>> map the upstream driver to the level of supported features in the
>> internal code base.
>
>
> Your internal code base doesn't mean anything at all to the kernel. If you
> don't have a valid reason why the kernel needs this version number get rid
> of this patch please.
>
> -Denny
>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/infiniband/hw/bnxt_re/bnxt_re.h b/drivers/infiniband/hw/bnxt_re/bnxt_re.h
index 30bff05..9041c23b 100644
--- a/drivers/infiniband/hw/bnxt_re/bnxt_re.h
+++ b/drivers/infiniband/hw/bnxt_re/bnxt_re.h
@@ -40,7 +40,7 @@ 
 #ifndef __BNXT_RE_H__
 #define __BNXT_RE_H__
 #define ROCE_DRV_MODULE_NAME		"bnxt_re"
-#define ROCE_DRV_MODULE_VERSION		"1.0.0"
+#define ROCE_DRV_MODULE_VERSION		"20.6.1.0u"
 
 #define BNXT_RE_DESC	"Broadcom NetXtreme-C/E RoCE Driver"