diff mbox

[RFC,4/5] verbs: Tag matching send interface

Message ID 1497249767-15353-5-git-send-email-artemyko@mellanox.com (mailing list archive)
State RFC
Headers show

Commit Message

Artemy Kovalyov June 12, 2017, 6:42 a.m. UTC
Add tag matching header (TMH) and rendezvous header (RVH) definitions
to infiniband/tm_types.h

Change-Id: I35a2088190ff4a1776f77b43a4564bb6f65ca83c
Signed-off-by: Artemy Kovalyov <artemyko@mellanox.com>
Reviewed-by: Yishai Hadas <yishaih@mellanox.com>
---
 libibverbs/tm_types.h | 70 +++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 70 insertions(+)
 create mode 100644 libibverbs/tm_types.h

Comments

Jason Gunthorpe June 12, 2017, 4:41 p.m. UTC | #1
On Mon, Jun 12, 2017 at 09:42:46AM +0300, Artemy Kovalyov wrote:
> Add tag matching header (TMH) and rendezvous header (RVH) definitions
> to infiniband/tm_types.h
> 
> Change-Id: I35a2088190ff4a1776f77b43a4564bb6f65ca83c
> Signed-off-by: Artemy Kovalyov <artemyko@mellanox.com>
> Reviewed-by: Yishai Hadas <yishaih@mellanox.com>
>  libibverbs/tm_types.h | 70 +++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 70 insertions(+)
>  create mode 100644 libibverbs/tm_types.h
> 
> diff --git a/libibverbs/tm_types.h b/libibverbs/tm_types.h
> new file mode 100644
> index 0000000..7626787
> +++ b/libibverbs/tm_types.h

There is no cmake stuff for this file, and it is never used in this
series - what is the intention here?

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Leon Romanovsky June 13, 2017, 6:33 a.m. UTC | #2
On Mon, Jun 12, 2017 at 10:41:40AM -0600, Jason Gunthorpe wrote:
> On Mon, Jun 12, 2017 at 09:42:46AM +0300, Artemy Kovalyov wrote:
> > Add tag matching header (TMH) and rendezvous header (RVH) definitions
> > to infiniband/tm_types.h
> >
> > Change-Id: I35a2088190ff4a1776f77b43a4564bb6f65ca83c
> > Signed-off-by: Artemy Kovalyov <artemyko@mellanox.com>
> > Reviewed-by: Yishai Hadas <yishaih@mellanox.com>
> >  libibverbs/tm_types.h | 70 +++++++++++++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 70 insertions(+)
> >  create mode 100644 libibverbs/tm_types.h
> >
> > diff --git a/libibverbs/tm_types.h b/libibverbs/tm_types.h
> > new file mode 100644
> > index 0000000..7626787
> > +++ b/libibverbs/tm_types.h
>
> There is no cmake stuff for this file, and it is never used in this
> series - what is the intention here?

Jason,

It is RFC, the intention is to present headers and APIs in most clear way
without distraction of error handling, manuals and Cmake changes.

Thanks

>
> Jason
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/libibverbs/tm_types.h b/libibverbs/tm_types.h
new file mode 100644
index 0000000..7626787
--- /dev/null
+++ b/libibverbs/tm_types.h
@@ -0,0 +1,70 @@ 
+/*
+ * Copyright (c) 2017 Mellanox Technologies Ltd.  All rights reserved.
+ *
+ * This software is available to you under a choice of one of two
+ * licenses.  You may choose to be licensed under the terms of the GNU
+ * General Public License (GPL) Version 2, available from the file
+ * COPYING in the main directory of this source tree, or the
+ * OpenIB.org BSD license below:
+ *
+ *     Redistribution and use in source and binary forms, with or
+ *     without modification, are permitted provided that the following
+ *     conditions are met:
+ *
+ *      - Redistributions of source code must retain the above
+ *        copyright notice, this list of conditions and the following
+ *        disclaimer.
+ *
+ *      - Redistributions in binary form must reproduce the above
+ *        copyright notice, this list of conditions and the following
+ *        disclaimer in the documentation and/or other materials
+ *        provided with the distribution.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+ * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+ * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+ * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS
+ * BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN
+ * ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
+ * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+ * SOFTWARE.
+ *
+ */
+#ifndef _TM_TYPES_H
+#define _TM_TYPES_H
+
+#include <linux/types.h>
+#include <stdint.h>
+
+#ifdef __cplusplus
+#  define BEGIN_C_DECLS extern "C" {
+#  define END_C_DECLS   }
+#else				/* !__cplusplus */
+#  define BEGIN_C_DECLS
+#  define END_C_DECLS
+#endif				/* __cplusplus */
+
+BEGIN_C_DECLS
+
+enum ibv_tmh_op {
+	IBV_TMH_NO_TAG	      = 0,
+	IBV_TMH_RNDV	      = 1,
+	IBV_TMH_FIN	      = 2,
+	IBV_TMH_EAGER	      = 3
+};
+
+struct ibv_tmh {
+	uint8_t		opcode;      /* from enum ibv_tmh_op */
+	uint8_t		reserved[3]; /* must be zero */
+	__be32		app_ctx;
+	__be64		tag;
+};
+
+struct ibv_rvh {
+	__be64		va;
+	__be32		rkey;
+	__be32		len;
+};
+
+END_C_DECLS
+#endif				/* _TM_TYPES_H */