| Message ID | 1505842717-26646-1-git-send-email-Michal.Kalderon@cavium.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
On Tue, Sep 19, 2017 at 08:38:37PM +0300, Michal Kalderon wrote: > Initialize the rdma_type (iWARP or RoCE) which is set according to > device configuration in qed. > > Signed-off-by: Michal Kalderon <Michal.Kalderon@cavium.com> > Signed-off-by: Ariel Elior <Ariel.Elior@cavium.com> > --- Please add Fixes. Thanks
From: Leon Romanovsky <leon@kernel.org> Sent: Tuesday, September 19, 2017 8:47 PM On Tue, Sep 19, 2017 at 08:38:37PM +0300, Michal Kalderon wrote: >> Initialize the rdma_type (iWARP or RoCE) which is set according to >> device configuration in qed. >> >> Signed-off-by: Michal Kalderon <Michal.Kalderon@cavium.com> >> Signed-off-by: Ariel Elior <Ariel.Elior@cavium.com> >> --- > >Please add Fixes. > >Thanks sure, i'll send v1 -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 9/20/2017 1:42 AM, Kalderon, Michal wrote: > From: Leon Romanovsky <leon@kernel.org> > Sent: Tuesday, September 19, 2017 8:47 PM > > On Tue, Sep 19, 2017 at 08:38:37PM +0300, Michal Kalderon wrote: >>> Initialize the rdma_type (iWARP or RoCE) which is set according to >>> device configuration in qed. >>> >>> Signed-off-by: Michal Kalderon <Michal.Kalderon@cavium.com> >>> Signed-off-by: Ariel Elior <Ariel.Elior@cavium.com> >>> --- >> >> Please add Fixes. >> >> Thanks > sure, i'll send v1 Does just responding with a "Fixes" tag get appended automagically by Patchworks? -Denny -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Sep 25, 2017 at 08:29:58AM -0400, Dennis Dalessandro wrote: > On 9/20/2017 1:42 AM, Kalderon, Michal wrote: > > From: Leon Romanovsky <leon@kernel.org> > > Sent: Tuesday, September 19, 2017 8:47 PM > > > > On Tue, Sep 19, 2017 at 08:38:37PM +0300, Michal Kalderon wrote: > > > > Initialize the rdma_type (iWARP or RoCE) which is set according to > > > > device configuration in qed. > > > > > > > > Signed-off-by: Michal Kalderon <Michal.Kalderon@cavium.com> > > > > Signed-off-by: Ariel Elior <Ariel.Elior@cavium.com> > > > > --- > > > > > > Please add Fixes. > > > > > > Thanks > > sure, i'll send v1 > > Does just responding with a "Fixes" tag get appended automagically by > Patchworks? I don't think so, but let's check with fixes line from v1. Fixes: e6a38c54faf ("RDMA/qedr: Add support for registering an iWARP device") The v0 patch is here https://patchwork.kernel.org/patch/9959815/ Thanks > > -Denny >
On Tue, 2017-09-26 at 09:10 +0300, Leon Romanovsky wrote: > On Mon, Sep 25, 2017 at 08:29:58AM -0400, Dennis Dalessandro wrote: > > On 9/20/2017 1:42 AM, Kalderon, Michal wrote: > > > From: Leon Romanovsky <leon@kernel.org> > > > Sent: Tuesday, September 19, 2017 8:47 PM > > > > > > On Tue, Sep 19, 2017 at 08:38:37PM +0300, Michal Kalderon wrote: > > > > > Initialize the rdma_type (iWARP or RoCE) which is set > > > > > according to > > > > > device configuration in qed. > > > > > > > > > > Signed-off-by: Michal Kalderon <Michal.Kalderon@cavium.com> > > > > > Signed-off-by: Ariel Elior <Ariel.Elior@cavium.com> > > > > > --- > > > > > > > > Please add Fixes. > > > > > > > > Thanks > > > > > > sure, i'll send v1 > > > > Does just responding with a "Fixes" tag get appended automagically > > by > > Patchworks? > > I don't think so, but let's check with fixes line from v1. > Fixes: e6a38c54faf ("RDMA/qedr: Add support for registering an iWARP > device") Patchworks does, in fact, add the Fixes: line (although not in the format we normally tell people to use as there is empty space between the Fixes: line and the start of the Signed-off-by: lines). However, that's all irrelevant, as this patch breaks the build for me. Is there a prerequisite patch in net-next for this?
diff --git a/drivers/infiniband/hw/qedr/main.c b/drivers/infiniband/hw/qedr/main.c index ca93171..1afc267 100644 --- a/drivers/infiniband/hw/qedr/main.c +++ b/drivers/infiniband/hw/qedr/main.c @@ -870,6 +870,7 @@ static struct qedr_dev *qedr_add(struct qed_dev *cdev, struct pci_dev *pdev, goto init_err; dev->user_dpm_enabled = dev_info.user_dpm_enabled; + dev->rdma_type = dev_info.rdma_type; dev->num_hwfns = dev_info.common.num_hwfns; dev->rdma_ctx = dev->ops->rdma_get_rdma_ctx(cdev);