diff mbox series

[for-rc,4/8] RDMA/hns: Limit minimum ROCE CQ depth to 64

Message ID 1548405030-124329-5-git-send-email-oulijun@huawei.com (mailing list archive)
State Changes Requested
Headers show
Series Some hns bugfixes for 5.0-rc3 | expand

Commit Message

Lijun Ou Jan. 25, 2019, 8:30 a.m. UTC 
From: chenglang <chenglang@huawei.com>

This patch modifies the minimum CQ depth specification of hip08
and is consistent with the processing of hip06.

Signed-off-by: chenglang <chenglang@huawei.com>
---
 drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Dennis Dalessandro Jan. 25, 2019, 12:29 p.m. UTC | #1 
On 1/25/2019 3:30 AM, Lijun Ou wrote:
> From: chenglang <chenglang@huawei.com>
> 
> This patch modifies the minimum CQ depth specification of hip08
> and is consistent with the processing of hip06.
> 
> Signed-off-by: chenglang <chenglang@huawei.com>
> ---
>   drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
> index 07f2e7a..c68d72c 100644
> --- a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
> +++ b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
> @@ -1313,6 +1313,7 @@ static int hns_roce_v2_profile(struct hns_roce_dev *hr_dev)
>   	caps->max_wqes		= HNS_ROCE_V2_MAX_WQE_NUM;
>   	caps->num_cqs		= HNS_ROCE_V2_MAX_CQ_NUM;
>   	caps->num_srqs		= HNS_ROCE_V2_MAX_SRQ_NUM;
> +	caps->min_cqes		= HNS_ROCE_MIN_CQE_NUM;
>   	caps->max_cqes		= HNS_ROCE_V2_MAX_CQE_NUM;
>   	caps->max_srqwqes	= HNS_ROCE_V2_MAX_SRQWQE_NUM;
>   	caps->max_sq_sg		= HNS_ROCE_V2_MAX_SQ_SGE_NUM;
> 

So what is the impact of not having this set?

-Denny
Lijun Ou Jan. 26, 2019, 1:13 a.m. UTC | #2 
在 2019/1/25 20:29, Dennis Dalessandro 写道:
> On 1/25/2019 3:30 AM, Lijun Ou wrote:
>> From: chenglang <chenglang@huawei.com>
>>
>> This patch modifies the minimum CQ depth specification of hip08
>> and is consistent with the processing of hip06.
>>
>> Signed-off-by: chenglang <chenglang@huawei.com>
>> ---
>>   drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
>> index 07f2e7a..c68d72c 100644
>> --- a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
>> +++ b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
>> @@ -1313,6 +1313,7 @@ static int hns_roce_v2_profile(struct hns_roce_dev *hr_dev)
>>       caps->max_wqes        = HNS_ROCE_V2_MAX_WQE_NUM;
>>       caps->num_cqs        = HNS_ROCE_V2_MAX_CQ_NUM;
>>       caps->num_srqs        = HNS_ROCE_V2_MAX_SRQ_NUM;
>> +    caps->min_cqes        = HNS_ROCE_MIN_CQE_NUM;
>>       caps->max_cqes        = HNS_ROCE_V2_MAX_CQE_NUM;
>>       caps->max_srqwqes    = HNS_ROCE_V2_MAX_SRQWQE_NUM;
>>       caps->max_sq_sg        = HNS_ROCE_V2_MAX_SQ_SGE_NUM;
>>
>
> So what is the impact of not having this set?
>
> -Denny
>
The driver will not fix the min cqes in hip08.
> .
>
diff mbox series

Patch

diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
index 07f2e7a..c68d72c 100644
--- a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
+++ b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
@@ -1313,6 +1313,7 @@  static int hns_roce_v2_profile(struct hns_roce_dev *hr_dev)
 	caps->max_wqes		= HNS_ROCE_V2_MAX_WQE_NUM;
 	caps->num_cqs		= HNS_ROCE_V2_MAX_CQ_NUM;
 	caps->num_srqs		= HNS_ROCE_V2_MAX_SRQ_NUM;
+	caps->min_cqes		= HNS_ROCE_MIN_CQE_NUM;
 	caps->max_cqes		= HNS_ROCE_V2_MAX_CQE_NUM;
 	caps->max_srqwqes	= HNS_ROCE_V2_MAX_SRQWQE_NUM;
 	caps->max_sq_sg		= HNS_ROCE_V2_MAX_SQ_SGE_NUM;