diff mbox

staging: rdma: shift wrapping bug in c2_get_dma_mr()

Message ID 20160108114936.GA3802@mwanda (mailing list archive)
State Not Applicable
Headers show

Commit Message

Dan Carpenter Jan. 8, 2016, 11:49 a.m. UTC
We should be using all 64 bits of page_list[i] instead of just the lower
32.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Christoph Hellwig Jan. 8, 2016, 1:29 p.m. UTC | #1
Looks fine.

Doug: what's the status of the staged out drivers?  I thought we were
going to delete them for 4.5?
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Doug Ledford Jan. 19, 2016, 6:13 p.m. UTC | #2
On 01/08/2016 08:29 AM, Christoph Hellwig wrote:
> Looks fine.
> 
> Doug: what's the status of the staged out drivers?  I thought we were
> going to delete them for 4.5?
> 

I am.  They will be going away shortly.
diff mbox

Patch

diff --git a/drivers/staging/rdma/amso1100/c2_provider.c b/drivers/staging/rdma/amso1100/c2_provider.c
index de8d10e..ac6a6ff 100644
--- a/drivers/staging/rdma/amso1100/c2_provider.c
+++ b/drivers/staging/rdma/amso1100/c2_provider.c
@@ -361,7 +361,7 @@  static struct ib_mr *c2_get_dma_mr(struct ib_pd *pd, int acc)
 	}
 
 	for (i = 0; i < pbl_depth; i++)
-		page_list[i] = (i << page_shift);
+		page_list[i] = ((u64)i << page_shift);
 
 	mr = kmalloc(sizeof(*mr), GFP_KERNEL);
 	if (!mr) {