| Message ID | 20160206151114.GA18959@amitoj-Inspiron-3542 (mailing list archive) |
|---|---|
| State | Rejected |
| Headers | show |
On 02/06/2016 10:11 AM, Amitoj Kaur Chawla wrote: > Replace generic pr_debug() with netdev_dbg() for net devices. > > Found using Coccinelle. The semantic patch used to find this is as > follows: > > //<smpl> > @@ > expression e; > identifier f,i; > position p; > @@ > > f(...,struct net_device *i,...) { > ... > - pr_debug@p(e); > + netdev_dbg(i, e); > ... > } > //</smpl> > > Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com> This driver has been removed entire as of 4.5-rc2, so this patch can no longer be applied. > --- > drivers/staging/rdma/amso1100/c2_provider.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/rdma/amso1100/c2_provider.c b/drivers/staging/rdma/amso1100/c2_provider.c > index e44ad22..75a7de5 100644 > --- a/drivers/staging/rdma/amso1100/c2_provider.c > +++ b/drivers/staging/rdma/amso1100/c2_provider.c > @@ -659,7 +659,7 @@ static int c2_pseudo_up(struct net_device *netdev) > if (!ind) > return 0; > > - pr_debug("adding...\n"); > + netdev_dbg(netdev, "adding...\n"); > for_ifa(ind) { > #ifdef DEBUG > u8 *ip = (u8 *) & ifa->ifa_address; > @@ -684,7 +684,7 @@ static int c2_pseudo_down(struct net_device *netdev) > if (!ind) > return 0; > > - pr_debug("deleting...\n"); > + netdev_dbg(netdev, "deleting...\n"); > for_ifa(ind) { > #ifdef DEBUG > u8 *ip = (u8 *) & ifa->ifa_address; >
diff --git a/drivers/staging/rdma/amso1100/c2_provider.c b/drivers/staging/rdma/amso1100/c2_provider.c index e44ad22..75a7de5 100644 --- a/drivers/staging/rdma/amso1100/c2_provider.c +++ b/drivers/staging/rdma/amso1100/c2_provider.c @@ -659,7 +659,7 @@ static int c2_pseudo_up(struct net_device *netdev) if (!ind) return 0; - pr_debug("adding...\n"); + netdev_dbg(netdev, "adding...\n"); for_ifa(ind) { #ifdef DEBUG u8 *ip = (u8 *) & ifa->ifa_address; @@ -684,7 +684,7 @@ static int c2_pseudo_down(struct net_device *netdev) if (!ind) return 0; - pr_debug("deleting...\n"); + netdev_dbg(netdev, "deleting...\n"); for_ifa(ind) { #ifdef DEBUG u8 *ip = (u8 *) & ifa->ifa_address;
Replace generic pr_debug() with netdev_dbg() for net devices. Found using Coccinelle. The semantic patch used to find this is as follows: //<smpl> @@ expression e; identifier f,i; position p; @@ f(...,struct net_device *i,...) { ... - pr_debug@p(e); + netdev_dbg(i, e); ... } //</smpl> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com> --- drivers/staging/rdma/amso1100/c2_provider.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)