| Message ID | 20170109085429.32598-1-leonro@mellanox.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On Mon, Jan 09, 2017 at 10:54:29AM +0200, Leon Romanovsky wrote: > The modules ib_addr.ko, ib_mad.ko and ib_sa.ko were integrated > into ib_core.ko in following kernel commits: > * c2e49c92326f ("IB/SA: Integrate ib_sa module into ib_core module") > * 4c2cb4220431 ("IB/MAD: Integrate ib_mad module into ib_core module") > * e3f20f02864f ("IB/core: Integrate IB address resolution module into core") > > Fixes: 39fa824dd80e ("redhat: add udev/systemd/etc infrastructure bits") > Cc: Jarod Wilson <jarod@redhat.com> > Signed-off-by: Leon Romanovsky <leonro@mellanox.com> > redhat/rdma.kernel-init | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Make sense to me, but if we are saying the redhat scripts only work with a certain newish kernel then it would be great to also purge all that crufty compat stuff (mttrs, pci tuning, etc) so we can better understand what is still actually needed.. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Jan 09, 2017 at 08:43:02AM -0700, Jason Gunthorpe wrote: > On Mon, Jan 09, 2017 at 10:54:29AM +0200, Leon Romanovsky wrote: > > The modules ib_addr.ko, ib_mad.ko and ib_sa.ko were integrated > > into ib_core.ko in following kernel commits: > > * c2e49c92326f ("IB/SA: Integrate ib_sa module into ib_core module") > > * 4c2cb4220431 ("IB/MAD: Integrate ib_mad module into ib_core module") > > * e3f20f02864f ("IB/core: Integrate IB address resolution module into core") > > > > Fixes: 39fa824dd80e ("redhat: add udev/systemd/etc infrastructure bits") > > Cc: Jarod Wilson <jarod@redhat.com> > > Signed-off-by: Leon Romanovsky <leonro@mellanox.com> > > redhat/rdma.kernel-init | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Make sense to me, but if we are saying the redhat scripts only work > with a certain newish kernel then it would be great to also purge all > that crufty compat stuff (mttrs, pci tuning, etc) so we can better > understand what is still actually needed.. Other stuff doesn't crash our verification runs of upstream rdma-core vs. upstream kernel :) In our previous discussions, we agreed to have master branch to be in sync with Linus's tree and proposed to distributions to manage special (backported) branches for specific releases. And I agree with you and would like to see compat stuff removed. Doug, Jarod What do you think? Can you do it? Thanks > > Jason > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
On 2017-01-09 12:40 PM, Leon Romanovsky wrote: > On Mon, Jan 09, 2017 at 08:43:02AM -0700, Jason Gunthorpe wrote: >> On Mon, Jan 09, 2017 at 10:54:29AM +0200, Leon Romanovsky wrote: >>> The modules ib_addr.ko, ib_mad.ko and ib_sa.ko were integrated >>> into ib_core.ko in following kernel commits: >>> * c2e49c92326f ("IB/SA: Integrate ib_sa module into ib_core module") >>> * 4c2cb4220431 ("IB/MAD: Integrate ib_mad module into ib_core module") >>> * e3f20f02864f ("IB/core: Integrate IB address resolution module into core") >>> >>> Fixes: 39fa824dd80e ("redhat: add udev/systemd/etc infrastructure bits") >>> Cc: Jarod Wilson <jarod@redhat.com> >>> Signed-off-by: Leon Romanovsky <leonro@mellanox.com> >>> redhat/rdma.kernel-init | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> Make sense to me, but if we are saying the redhat scripts only work >> with a certain newish kernel then it would be great to also purge all >> that crufty compat stuff (mttrs, pci tuning, etc) so we can better >> understand what is still actually needed.. > > Other stuff doesn't crash our verification runs of upstream rdma-core > vs. upstream kernel :) > > In our previous discussions, we agreed to have master branch to be in > sync with Linus's tree and proposed to distributions to manage special > (backported) branches for specific releases. > > And I agree with you and would like to see compat stuff removed. > > Doug, Jarod > What do you think? Can you do it? I think this should be fine, I don't think rdma-core is going to make it's way (at least not directly) back to distros with sufficiently old enough rdma kernel stacks that this would cause any issues.
On Mon, Jan 09, 2017 at 10:54:29AM +0200, Leon Romanovsky wrote: > The modules ib_addr.ko, ib_mad.ko and ib_sa.ko were integrated > into ib_core.ko in following kernel commits: > * c2e49c92326f ("IB/SA: Integrate ib_sa module into ib_core module") > * 4c2cb4220431 ("IB/MAD: Integrate ib_mad module into ib_core module") > * e3f20f02864f ("IB/core: Integrate IB address resolution module into core") > > Fixes: 39fa824dd80e ("redhat: add udev/systemd/etc infrastructure bits") > Cc: Jarod Wilson <jarod@redhat.com> > Signed-off-by: Leon Romanovsky <leonro@mellanox.com> > --- > redhat/rdma.kernel-init | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied
diff --git a/redhat/rdma.kernel-init b/redhat/rdma.kernel-init index 6cb4732..ecfe5b5 100644 --- a/redhat/rdma.kernel-init +++ b/redhat/rdma.kernel-init @@ -14,7 +14,7 @@ MTRR_SCRIPT=/usr/libexec/rdma-fixup-mtrr.awk LOAD_ULP_MODULES="" LOAD_CORE_USER_MODULES="ib_umad ib_uverbs ib_ucm rdma_ucm" LOAD_CORE_CM_MODULES="iw_cm ib_cm rdma_cm" -LOAD_CORE_MODULES="ib_core ib_mad ib_sa ib_addr" +LOAD_CORE_MODULES="ib_core" LOAD_TECH_PREVIEW_DRIVERS="no" if [ -f $CONFIG ]; then
The modules ib_addr.ko, ib_mad.ko and ib_sa.ko were integrated into ib_core.ko in following kernel commits: * c2e49c92326f ("IB/SA: Integrate ib_sa module into ib_core module") * 4c2cb4220431 ("IB/MAD: Integrate ib_mad module into ib_core module") * e3f20f02864f ("IB/core: Integrate IB address resolution module into core") Fixes: 39fa824dd80e ("redhat: add udev/systemd/etc infrastructure bits") Cc: Jarod Wilson <jarod@redhat.com> Signed-off-by: Leon Romanovsky <leonro@mellanox.com> --- redhat/rdma.kernel-init | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.10.2 -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html