Message ID | 20170208185446.GH6005@mtr-leonro.local (mailing list archive) |
---|---|
State | Not Applicable |
Headers | show |
On Wed, Feb 08, 2017 at 08:54:46PM +0200, Leon Romanovsky wrote: > > Hmm. Can you update your github? I'll look for you. > > I pushed latest code to m/dv-1 branch, it is not for inclusion yet. > https://github.com/rleon/rdma-core/commits/m/dv-v1 > Updated cover letter with changelog: > https://github.com/rleon/rdma-core/commit/a332669511d5bbbd3dcdd977fbf95aa7ee47a69e > And all cmake/packages stuff in the patch: > https://github.com/rleon/rdma-core/commit/fcc4996c7fa5169fe599c2d568476314c1f65ddc This should take care of most things https://github.com/jgunthorpe/rdma-plumbing/commit/490b7fb184c414ab16b7056f1effa9136e8afe46 The debian packaging still needs some adjusting. I suspect it is against Debian policy to include libmlx.so in the providers package, it probably needs to have its own package and its own -dev package. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Feb 08, 2017 at 01:56:22PM -0700, Jason Gunthorpe wrote: > On Wed, Feb 08, 2017 at 08:54:46PM +0200, Leon Romanovsky wrote: > > > > Hmm. Can you update your github? I'll look for you. > > > > I pushed latest code to m/dv-1 branch, it is not for inclusion yet. > > https://github.com/rleon/rdma-core/commits/m/dv-v1 > > Updated cover letter with changelog: > > https://github.com/rleon/rdma-core/commit/a332669511d5bbbd3dcdd977fbf95aa7ee47a69e > > And all cmake/packages stuff in the patch: > > https://github.com/rleon/rdma-core/commit/fcc4996c7fa5169fe599c2d568476314c1f65ddc > > This should take care of most things > > https://github.com/jgunthorpe/rdma-plumbing/commit/490b7fb184c414ab16b7056f1effa9136e8afe46 Thanks a lot, we will add into our v1. > > The debian packaging still needs some adjusting. > > I suspect it is against Debian policy to include libmlx.so in the > providers package, it probably needs to have its own package and its > own -dev package. I don't know, at the end, it is provider. > > Jason
Am Mittwoch, den 08.02.2017, 13:56 -0700 schrieb Jason Gunthorpe: > On Wed, Feb 08, 2017 at 08:54:46PM +0200, Leon Romanovsky wrote: > > > > Hmm. Can you update your github? I'll look for you. > > > > I pushed latest code to m/dv-1 branch, it is not for inclusion yet. > > https://github.com/rleon/rdma-core/commits/m/dv-v1 > > Updated cover letter with changelog: > > https://github.com/rleon/rdma-core/commit/a332669511d5bbbd3dcdd977f > > bf95aa7ee47a69e > > And all cmake/packages stuff in the patch: > > https://github.com/rleon/rdma-core/commit/fcc4996c7fa5169fe599c2d56 > > 8476314c1f65ddc > > This should take care of most things > > https://github.com/jgunthorpe/rdma-plumbing/commit/490b7fb184c414ab16 > b7056f1effa9136e8afe46 > > The debian packaging still needs some adjusting. > > I suspect it is against Debian policy to include libmlx.so in the > providers package, it probably needs to have its own package and its > own -dev package. When other packages should be able to link against libmlx.so and need header files for that, it is better to have separate binary packages (libmlx and libmlx-dev) for it.
On Thu, Feb 09, 2017 at 10:53:26AM +0100, Benjamin Drung wrote: > Am Mittwoch, den 08.02.2017, 13:56 -0700 schrieb Jason Gunthorpe: > > On Wed, Feb 08, 2017 at 08:54:46PM +0200, Leon Romanovsky wrote: > > > > > > Hmm. Can you update your github? I'll look for you. > > > > > > I pushed latest code to m/dv-1 branch, it is not for inclusion yet. > > > https://github.com/rleon/rdma-core/commits/m/dv-v1 > > > Updated cover letter with changelog: > > > https://github.com/rleon/rdma-core/commit/a332669511d5bbbd3dcdd977f > > > bf95aa7ee47a69e > > > And all cmake/packages stuff in the patch: > > > https://github.com/rleon/rdma-core/commit/fcc4996c7fa5169fe599c2d56 > > > 8476314c1f65ddc > > > > This should take care of most things > > > > https://github.com/jgunthorpe/rdma-plumbing/commit/490b7fb184c414ab16 > > b7056f1effa9136e8afe46 > > > > The debian packaging still needs some adjusting. > > > > I suspect it is against Debian policy to include libmlx.so in the > > providers package, it probably needs to have its own package and its > > own -dev package. > > When other packages should be able to link against libmlx.so and need > header files for that, it is better to have separate binary packages > (libmlx and libmlx-dev) for it. This libmlx is dependent on ibverbs-provider and libibverbs. It is useless without them and will be always installed together, so why do we need to complicate users life by adding new library? And we can always spin-off it as a separate package once someone will need it. Thanks > > -- > Benjamin Drung > System Developer > Debian & Ubuntu Developer > > ProfitBricks GmbH > Greifswalder Str. 207 > D - 10405 Berlin > > Email: benjamin.drung@profitbricks.com > URL: http://www.profitbricks.com > > Sitz der Gesellschaft: Berlin. > Registergericht: Amtsgericht Charlottenburg, HRB 125506B. > Geschäftsführer: Andreas Gauger, Achim Weiss.
diff --git a/buildlib/rdma_functions.cmake b/buildlib/rdma_functions.cmake index 3d0683d0..3a1758f8 100644 --- a/buildlib/rdma_functions.cmake +++ b/buildlib/rdma_functions.cmake @@ -110,9 +110,15 @@ function(rdma_shared_provider DEST VERSION_SCRIPT SOVERSION VERSION) add_dependencies(share_link ${DEST}) install(TARGETS ${DEST} DESTINATION "${CMAKE_INSTALL_LIBDIR}") - execute_process(COMMAND python ${CMAKE_SOURCE_DIR}/buildlib/relpath - ${CMAKE_INSTALL_LIBDIR}/lib${DEST}.so.${VERSION} ${VERBS_PROVIDER_DIR} - OUTPUT_VARIABLE DEST_LINK_PATH OUTPUT_STRIP_TRAILING_WHITESPACE) + if (NOT ${CMAKE_INSTALL_FULL_LIBDIR} STREQUAL ${CMAKE_INSTALL_LIBDIR}) + execute_process(COMMAND python ${CMAKE_SOURCE_DIR}/buildlib/relpath + ${CMAKE_INSTALL_FULL_LIBDIR}/lib${DEST}.so.${VERSION} ${VERBS_PROVIDER_DIR} + OUTPUT_VARIABLE DEST_LINK_PATH OUTPUT_STRIP_TRAILING_WHITESPACE) + else() + execute_process(COMMAND python ${CMAKE_SOURCE_DIR}/buildlib/relpath + ${CMAKE_INSTALL_LIBDIR}/lib${DEST}.so.${VERSION} ${VERBS_PROVIDER_DIR} + OUTPUT_VARIABLE DEST_LINK_PATH OUTPUT_STRIP_TRAILING_WHITESPACE) + endif() rdma_install_symlink("${DEST_LINK_PATH}" "${VERBS_PROVIDER_DIR}/lib${DEST}-rdmav2.so") endfunction()