| Message ID | 20170217144110.2237820-1-arnd@arndb.de (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On Fri, 2017-02-17 at 15:40 +0100, Arnd Bergmann wrote: > When CONFIG_DCB is disabled, we get a link error: > > drivers/infiniband/built-in.o: In function `bnxt_re_setup_qos': > trace.c:(.text+0x155774): undefined reference to > `dcb_ieee_getapp_mask' > trace.c:(.text+0x155774): relocation truncated to fit: > R_AARCH64_CALL26 against undefined symbol `dcb_ieee_getapp_mask' > trace.c:(.text+0x155794): undefined reference to > `dcb_ieee_getapp_mask' > trace.c:(.text+0x155794): relocation truncated to fit: > R_AARCH64_CALL26 against undefined symbol `dcb_ieee_getapp_mask' > > Like the other drivers that use this function, a Kconfig dependency > is > the correct fix. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Thanks, applied.
diff --git a/drivers/infiniband/hw/bnxt_re/Kconfig b/drivers/infiniband/hw/bnxt_re/Kconfig index cd0175e32584..19982a4a9bba 100644 --- a/drivers/infiniband/hw/bnxt_re/Kconfig +++ b/drivers/infiniband/hw/bnxt_re/Kconfig @@ -1,6 +1,6 @@ config INFINIBAND_BNXT_RE tristate "Broadcom Netxtreme HCA support" - depends on ETHERNET && NETDEVICES && PCI && INET + depends on ETHERNET && NETDEVICES && PCI && INET && DCB select NET_VENDOR_BROADCOM select BNXT ---help---
When CONFIG_DCB is disabled, we get a link error: drivers/infiniband/built-in.o: In function `bnxt_re_setup_qos': trace.c:(.text+0x155774): undefined reference to `dcb_ieee_getapp_mask' trace.c:(.text+0x155774): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `dcb_ieee_getapp_mask' trace.c:(.text+0x155794): undefined reference to `dcb_ieee_getapp_mask' trace.c:(.text+0x155794): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `dcb_ieee_getapp_mask' Like the other drivers that use this function, a Kconfig dependency is the correct fix. Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/infiniband/hw/bnxt_re/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)