| Message ID | 20170713154722.10294-1-leon@kernel.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
Something was broken in my scripts, it should be rdma-core and not rdma-next. Sorry. On Thu, Jul 13, 2017 at 06:47:22PM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky <leonro@mellanox.com> > > [59/189] Building C object providers/bnxt_re/CMakeFiles/bnxt_re-rdmav2.dir/verbs.c.o > ../providers/bnxt_re/verbs.c: In function ‘bnxt_re_post_send’: > ../providers/bnxt_re/verbs.c:1222:18: warning: this statement may fall through [-Wimplicit-fallthrough=] > hdr->key_immd = htole32(be32toh(wr->imm_data)); > ^ > ../providers/bnxt_re/verbs.c:1223:3: note: here > case IBV_WR_SEND: > ^~~~ > ../providers/bnxt_re/verbs.c:1232:18: warning: this statement may fall through [-Wimplicit-fallthrough=] > hdr->key_immd = htole32(be32toh(wr->imm_data)); > ^ > ../providers/bnxt_re/verbs.c:1233:3: note: here > case IBV_WR_RDMA_WRITE: > > Cc: Bart Van Assche <Bart.VanAssche@wdc.com> > Signed-off-by: Leon Romanovsky <leonro@mellanox.com> > --- > Changelog from v0: > * Used commonly used in rdma-core annotation to mark fail through. > --- > providers/bnxt_re/verbs.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/providers/bnxt_re/verbs.c b/providers/bnxt_re/verbs.c > index 1fe79671..b89bcbaa 100644 > --- a/providers/bnxt_re/verbs.c > +++ b/providers/bnxt_re/verbs.c > @@ -1220,6 +1220,7 @@ int bnxt_re_post_send(struct ibv_qp *ibvqp, struct ibv_send_wr *wr, > * LE platform be32toh will do the job. > */ > hdr->key_immd = htole32(be32toh(wr->imm_data)); > + /* fall through */ > case IBV_WR_SEND: > if (qp->qptyp == IBV_QPT_UD) > bytes = bnxt_re_build_ud_sqe(qp, sqe, wr, > @@ -1230,6 +1231,7 @@ int bnxt_re_post_send(struct ibv_qp *ibvqp, struct ibv_send_wr *wr, > break; > case IBV_WR_RDMA_WRITE_WITH_IMM: > hdr->key_immd = htole32(be32toh(wr->imm_data)); > + /* fall through */ > case IBV_WR_RDMA_WRITE: > bytes = bnxt_re_build_rdma_sqe(qp, sqe, wr, is_inline); > break; > -- > 2.13.2 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
On 07/13/17 08:47, Leon Romanovsky wrote: > From: Leon Romanovsky <leonro@mellanox.com> > > [59/189] Building C object providers/bnxt_re/CMakeFiles/bnxt_re-rdmav2.dir/verbs.c.o > ../providers/bnxt_re/verbs.c: In function ‘bnxt_re_post_send’: > ../providers/bnxt_re/verbs.c:1222:18: warning: this statement may fall through [-Wimplicit-fallthrough=] > hdr->key_immd = htole32(be32toh(wr->imm_data)); > ^ > ../providers/bnxt_re/verbs.c:1223:3: note: here > case IBV_WR_SEND: > ^~~~ > ../providers/bnxt_re/verbs.c:1232:18: warning: this statement may fall through [-Wimplicit-fallthrough=] > hdr->key_immd = htole32(be32toh(wr->imm_data)); > ^ > ../providers/bnxt_re/verbs.c:1233:3: note: here > case IBV_WR_RDMA_WRITE: Reviewed-by: Bart Van Assche <Bart.VanAssche@wdc.com> -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/providers/bnxt_re/verbs.c b/providers/bnxt_re/verbs.c index 1fe79671..b89bcbaa 100644 --- a/providers/bnxt_re/verbs.c +++ b/providers/bnxt_re/verbs.c @@ -1220,6 +1220,7 @@ int bnxt_re_post_send(struct ibv_qp *ibvqp, struct ibv_send_wr *wr, * LE platform be32toh will do the job. */ hdr->key_immd = htole32(be32toh(wr->imm_data)); + /* fall through */ case IBV_WR_SEND: if (qp->qptyp == IBV_QPT_UD) bytes = bnxt_re_build_ud_sqe(qp, sqe, wr, @@ -1230,6 +1231,7 @@ int bnxt_re_post_send(struct ibv_qp *ibvqp, struct ibv_send_wr *wr, break; case IBV_WR_RDMA_WRITE_WITH_IMM: hdr->key_immd = htole32(be32toh(wr->imm_data)); + /* fall through */ case IBV_WR_RDMA_WRITE: bytes = bnxt_re_build_rdma_sqe(qp, sqe, wr, is_inline); break;