diff mbox

[rdma-core,1/4] debian: Let libibverbs1 17 break ibverbs-providers 16

Message ID 20180219115754.29519-1-benjamin.drung@profitbricks.com (mailing list archive)
State Superseded
Headers show

Commit Message

Benjamin Drung Feb. 19, 2018, 11:57 a.m. UTC
ibverbs-providers uses the private symbols of libibverbs1. Thus
libibverbs1 will not work with an old version version of
ibverbs-providers if the private symbol version is bumped.

Bump the ibverbs-providers version that libibverbs1 and
ibverbs-providers use the same major version.

Signed-off-by: Benjamin Drung <benjamin.drung@profitbricks.com>
(cherry picked from commit 52b7a610f5b5e478c5292d2689090883eaaee0a0)
---
 debian/control | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jason Gunthorpe Feb. 19, 2018, 10:38 p.m. UTC | #1
On Mon, Feb 19, 2018 at 12:57:51PM +0100, Benjamin Drung wrote:
> ibverbs-providers uses the private symbols of libibverbs1. Thus
> libibverbs1 will not work with an old version version of
> ibverbs-providers if the private symbol version is bumped.
> 
> Bump the ibverbs-providers version that libibverbs1 and
> ibverbs-providers use the same major version.
> 
> Signed-off-by: Benjamin Drung <benjamin.drung@profitbricks.com>
> (cherry picked from commit 52b7a610f5b5e478c5292d2689090883eaaee0a0)
>  debian/control | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

There is a file in documentation containing all the steps for a new
major version release commit (and maybe we should script it)

Can you update it to incude what to do for this part?

Thanks,
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Leon Romanovsky Feb. 20, 2018, 12:19 p.m. UTC | #2
On Mon, Feb 19, 2018 at 12:57:51PM +0100, Benjamin Drung wrote:
> ibverbs-providers uses the private symbols of libibverbs1. Thus
> libibverbs1 will not work with an old version version of
> ibverbs-providers if the private symbol version is bumped.
>
> Bump the ibverbs-providers version that libibverbs1 and
> ibverbs-providers use the same major version.
>
> Signed-off-by: Benjamin Drung <benjamin.drung@profitbricks.com>
> (cherry picked from commit 52b7a610f5b5e478c5292d2689090883eaaee0a0)

Can you please use cover letter for such patches? So I'll know which
one to apply on master and which one to skip.

Thanks
Benjamin Drung Feb. 20, 2018, 3:22 p.m. UTC | #3
Am Dienstag, den 20.02.2018, 14:19 +0200 schrieb Leon Romanovsky:
> On Mon, Feb 19, 2018 at 12:57:51PM +0100, Benjamin Drung wrote:
> > ibverbs-providers uses the private symbols of libibverbs1. Thus
> > libibverbs1 will not work with an old version version of
> > ibverbs-providers if the private symbol version is bumped.
> > 
> > Bump the ibverbs-providers version that libibverbs1 and
> > ibverbs-providers use the same major version.
> > 
> > Signed-off-by: Benjamin Drung <benjamin.drung@profitbricks.com>
> > (cherry picked from commit
> > 52b7a610f5b5e478c5292d2689090883eaaee0a0)
> 
> Can you please use cover letter for such patches? So I'll know which
> one to apply on master and which one to skip.

Okay. I will write a cover letter next time. All four patches target
master.
Leon Romanovsky Feb. 21, 2018, 8:45 a.m. UTC | #4
On Tue, Feb 20, 2018 at 04:22:15PM +0100, Benjamin Drung wrote:
> Am Dienstag, den 20.02.2018, 14:19 +0200 schrieb Leon Romanovsky:
> > On Mon, Feb 19, 2018 at 12:57:51PM +0100, Benjamin Drung wrote:
> > > ibverbs-providers uses the private symbols of libibverbs1. Thus
> > > libibverbs1 will not work with an old version version of
> > > ibverbs-providers if the private symbol version is bumped.
> > >
> > > Bump the ibverbs-providers version that libibverbs1 and
> > > ibverbs-providers use the same major version.
> > >
> > > Signed-off-by: Benjamin Drung <benjamin.drung@profitbricks.com>
> > > (cherry picked from commit
> > > 52b7a610f5b5e478c5292d2689090883eaaee0a0)
> >
> > Can you please use cover letter for such patches? So I'll know which
> > one to apply on master and which one to skip.
>
> Okay. I will write a cover letter next time. All four patches target
> master.

Thanks, applied.

>
> --
> Benjamin Drung
> System Developer
> Debian & Ubuntu Developer
>
> ProfitBricks GmbH
> Greifswalder Str. 207
> D - 10405 Berlin
>
> Email: benjamin.drung@profitbricks.com
> URL: https://www.profitbricks.de
>
> Sitz der Gesellschaft: Berlin
> Registergericht: Amtsgericht Charlottenburg, HRB 125506 B
> Geschäftsführer: Achim Weiss, Matthias Steinberg
diff mbox

Patch

diff --git a/debian/control b/debian/control
index c3b1aadc..642a715e 100644
--- a/debian/control
+++ b/debian/control
@@ -138,7 +138,7 @@  Section: libs
 Pre-Depends: ${misc:Pre-Depends}
 Depends: adduser, ${misc:Depends}, ${shlibs:Depends}
 Recommends: ibverbs-providers
-Breaks: ibverbs-providers (<< 16~)
+Breaks: ibverbs-providers (<< 17~)
 Description: Library for direct userspace use of RDMA (InfiniBand/iWARP)
  libibverbs is a library that allows userspace processes to use RDMA
  "verbs" as described in the InfiniBand Architecture Specification and