| Message ID | 20180315211401.GA28731@ziepe.ca (mailing list archive) |
|---|---|
| State | RFC |
| Headers | show |
> -----Original Message----- > From: Jason Gunthorpe [mailto:jgg@ziepe.ca] > Sent: Thursday, March 15, 2018 4:14 PM > To: Leon Romanovsky <leon@kernel.org> > Cc: Doug Ledford <dledford@redhat.com>; Leon Romanovsky > <leonro@mellanox.com>; RDMA mailing list <linux-rdma@vger.kernel.org>; > Daniel Jurgens <danielj@mellanox.com>; Mark Bloch <markb@mellanox.com>; > Parav Pandit <parav@mellanox.com> > Subject: Re: [PATCH rdma-next v1 06/13] IB/core: Remove > rdma_resolve_ip_route() as exported symbol > > On Tue, Mar 13, 2018 at 04:06:16PM +0200, Leon Romanovsky wrote: > > From: Parav Pandit <parav@mellanox.com> > > > > rdma_resolve_ip_route() is used only by ib_core module. Therefore it > > is removed as exported symbol. > > > > Reviewed-by: Daniel Jurgens <danielj@mellanox.com> > > Signed-off-by: Parav Pandit <parav@mellanox.com> > > Signed-off-by: Leon Romanovsky <leon@kernel.org> > > drivers/infiniband/core/addr.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/infiniband/core/addr.c > > b/drivers/infiniband/core/addr.c index a5b4cf030c11..d5f552780fac > > 100644 > > +++ b/drivers/infiniband/core/addr.c > > @@ -716,7 +716,6 @@ int rdma_resolve_ip_route(struct sockaddr > > *src_addr, > > > > return addr_resolve(src_in, dst_addr, addr, false, 0); } > > -EXPORT_SYMBOL(rdma_resolve_ip_route); > > > > void rdma_addr_cancel(struct rdma_dev_addr *addr) { > > Since the export is gone the function prototype should be in core_priv.h. I added > these hunks to the patch: > > diff --git a/drivers/infiniband/core/core_priv.h > b/drivers/infiniband/core/core_priv.h > index 0f8d1f321e8157..479418c6143085 100644 > --- a/drivers/infiniband/core/core_priv.h > +++ b/drivers/infiniband/core/core_priv.h > @@ -338,4 +338,10 @@ int rdma_addr_find_l2_eth_by_grh(const union ib_gid > *sgid, > const union ib_gid *dgid, > u8 *dmac, const struct net_device *ndev, > int *hoplimit); > + > +struct rdma_dev_addr; > +int rdma_resolve_ip_route(struct sockaddr *src_addr, > + const struct sockaddr *dst_addr, > + struct rdma_dev_addr *addr); > + > #endif /* _CORE_PRIV_H */ > diff --git a/include/rdma/ib_addr.h b/include/rdma/ib_addr.h index > bba6f5dd9ed1d9..e8860a46754a4e 100644 > --- a/include/rdma/ib_addr.h > +++ b/include/rdma/ib_addr.h > @@ -119,10 +119,6 @@ int rdma_resolve_ip(struct rdma_addr_client *client, > struct rdma_dev_addr *addr, void *context), > void *context); > > -int rdma_resolve_ip_route(struct sockaddr *src_addr, > - const struct sockaddr *dst_addr, > - struct rdma_dev_addr *addr); > - > void rdma_addr_cancel(struct rdma_dev_addr *addr); > > void rdma_copy_addr(struct rdma_dev_addr *dev_addr, Looks to me. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/infiniband/core/core_priv.h b/drivers/infiniband/core/core_priv.h index 0f8d1f321e8157..479418c6143085 100644 --- a/drivers/infiniband/core/core_priv.h +++ b/drivers/infiniband/core/core_priv.h @@ -338,4 +338,10 @@ int rdma_addr_find_l2_eth_by_grh(const union ib_gid *sgid, const union ib_gid *dgid, u8 *dmac, const struct net_device *ndev, int *hoplimit); + +struct rdma_dev_addr; +int rdma_resolve_ip_route(struct sockaddr *src_addr, + const struct sockaddr *dst_addr, + struct rdma_dev_addr *addr); + #endif /* _CORE_PRIV_H */ diff --git a/include/rdma/ib_addr.h b/include/rdma/ib_addr.h index bba6f5dd9ed1d9..e8860a46754a4e 100644 --- a/include/rdma/ib_addr.h +++ b/include/rdma/ib_addr.h @@ -119,10 +119,6 @@ int rdma_resolve_ip(struct rdma_addr_client *client, struct rdma_dev_addr *addr, void *context), void *context); -int rdma_resolve_ip_route(struct sockaddr *src_addr, - const struct sockaddr *dst_addr, - struct rdma_dev_addr *addr); - void rdma_addr_cancel(struct rdma_dev_addr *addr); void rdma_copy_addr(struct rdma_dev_addr *dev_addr,