| Message ID | 20180403153228.28340-1-shiraz.saleem@intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On Tue, Apr 03, 2018 at 10:32:28AM -0500, Shiraz Saleem wrote: > Support for resource profile 1 is currenlty deprecated due to > a pre-production errata. Remove this workaround as its no longer > needed. > > Signed-off-by: Shiraz Saleem <shiraz.saleem@intel.com> > --- > drivers/infiniband/hw/i40iw/i40iw_main.c | 2 -- > 1 file changed, 2 deletions(-) Applied to for-next Thanks, Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Apr 03, 2018 at 10:32:28AM -0500, Shiraz Saleem wrote: > Support for resource profile 1 is currenlty deprecated due to > a pre-production errata. Remove this workaround as its no longer > needed. The sentence "Support for resource profile 1 is currenlty deprecated" caused me to wonder What should user expect after he supplies "1" in resource_profile module parameter? If he can't supply, you will need to issue warning and change I40IW_HMC_PROFILE_DEFAULT to be something else than it is now. Thanks
On Wed, Apr 04, 2018 at 08:38:50AM +0300, Leon Romanovsky wrote: > On Tue, Apr 03, 2018 at 10:32:28AM -0500, Shiraz Saleem wrote: > > Support for resource profile 1 is currenlty deprecated due to > > a pre-production errata. Remove this workaround as its no longer > > needed. > > The sentence "Support for resource profile 1 is currenlty deprecated" > caused me to wonder What should user expect after he supplies "1" > in resource_profile module parameter? > The resource profile 1 was never deprecated, I misused the word. It was a workaround and is no longer needed. Shiraz -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Apr 04, 2018 at 08:52:45AM -0500, Shiraz Saleem wrote: > On Wed, Apr 04, 2018 at 08:38:50AM +0300, Leon Romanovsky wrote: > > On Tue, Apr 03, 2018 at 10:32:28AM -0500, Shiraz Saleem wrote: > > > Support for resource profile 1 is currenlty deprecated due to > > > a pre-production errata. Remove this workaround as its no longer > > > needed. > > > > The sentence "Support for resource profile 1 is currenlty deprecated" > > caused me to wonder What should user expect after he supplies "1" > > in resource_profile module parameter? > > > > The resource profile 1 was never deprecated, I misused the word. > It was a workaround and is no longer needed. Ahhh, Thanks > > Shiraz
diff --git a/drivers/infiniband/hw/i40iw/i40iw_main.c b/drivers/infiniband/hw/i40iw/i40iw_main.c index b088629..9cd0d3e 100644 --- a/drivers/infiniband/hw/i40iw/i40iw_main.c +++ b/drivers/infiniband/hw/i40iw/i40iw_main.c @@ -1560,8 +1560,6 @@ static enum i40iw_status_code i40iw_setup_init_state(struct i40iw_handler *hdl, enum i40iw_status_code status; memcpy(&hdl->ldev, ldev, sizeof(*ldev)); - if (resource_profile == 1) - resource_profile = 2; iwdev->mpa_version = mpa_version; iwdev->resource_profile = (resource_profile < I40IW_HMC_PROFILE_EQUAL) ?
Support for resource profile 1 is currenlty deprecated due to a pre-production errata. Remove this workaround as its no longer needed. Signed-off-by: Shiraz Saleem <shiraz.saleem@intel.com> --- drivers/infiniband/hw/i40iw/i40iw_main.c | 2 -- 1 file changed, 2 deletions(-)