| Message ID | 20180420090122.9697-1-benjamin.drung@profitbricks.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On Fri, Apr 20, 2018 at 11:01:22AM +0200, Benjamin Drung wrote: > valgrind is not available on the quite new riscv64 architecture and it > is not likely to have valgrind soon. Therefore rdma-core shouldn't > build-depend on it. > > Closes: #896150 > Thanks: Manuel A. Fernandez Montecelo <mafm@debian.org> > Signed-off-by: Benjamin Drung <benjamin.drung@profitbricks.com> > --- > debian/control | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > I wonder if the easy path is to write where valgrind works instead of blacklisting everything. Thanks, applied
Am Donnerstag, den 26.04.2018, 13:39 +0300 schrieb Leon Romanovsky: > On Fri, Apr 20, 2018 at 11:01:22AM +0200, Benjamin Drung wrote: > > valgrind is not available on the quite new riscv64 architecture and > > it > > is not likely to have valgrind soon. Therefore rdma-core shouldn't > > build-depend on it. > > > > Closes: #896150 > > Thanks: Manuel A. Fernandez Montecelo <mafm@debian.org> > > Signed-off-by: Benjamin Drung <benjamin.drung@profitbricks.com> > > --- > > debian/control | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > I wonder if the easy path is to write where valgrind works instead of > blacklisting everything. Whitelisting is an option too. We either have to maintain either list (either the archs which have valgrind or the archs that do not have it). Should I switch to whitelisting?
On Thu, Apr 26, 2018 at 04:20:17PM +0200, Benjamin Drung wrote: > Am Donnerstag, den 26.04.2018, 13:39 +0300 schrieb Leon Romanovsky: > > On Fri, Apr 20, 2018 at 11:01:22AM +0200, Benjamin Drung wrote: > > > valgrind is not available on the quite new riscv64 architecture and > > > it > > > is not likely to have valgrind soon. Therefore rdma-core shouldn't > > > build-depend on it. > > > > > > Closes: #896150 > > > Thanks: Manuel A. Fernandez Montecelo <mafm@debian.org> > > > Signed-off-by: Benjamin Drung <benjamin.drung@profitbricks.com> > > > --- > > > debian/control | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > I wonder if the easy path is to write where valgrind works instead of > > blacklisting everything. > > Whitelisting is an option too. We either have to maintain either list > (either the archs which have valgrind or the archs that do not have > it). Should I switch to whitelisting? Completely upto you. IMHO, it is better to wait for next update of this line and to switch at that point. Thanks > > -- > Benjamin Drung > System Developer > Debian & Ubuntu Developer > > ProfitBricks GmbH > Greifswalder Str. 207 > 10405 Berlin > > Email: benjamin.drung@profitbricks.com > URL: https://www.profitbricks.de > > Sitz der Gesellschaft: Berlin > Registergericht: Amtsgericht Charlottenburg, HRB 125506 B > Geschäftsführer: Achim Weiss, Matthias Steinberg, Christoph Steffens
diff --git a/debian/control b/debian/control index 3c04b97c..fa897c2f 100644 --- a/debian/control +++ b/debian/control @@ -12,7 +12,7 @@ Build-Depends: cmake (>= 2.8.11), ninja-build, pkg-config, python, - valgrind [!alpha !armel !hppa !ia64 !m68k !powerpcspe !sh4 !sparc64 !x32] + valgrind [!alpha !armel !hppa !ia64 !m68k !powerpcspe !riscv64 !sh4 !sparc64 !x32] Standards-Version: 4.1.3 Vcs-Git: https://github.com/linux-rdma/rdma-core.git Vcs-Browser: https://github.com/linux-rdma/rdma-core
valgrind is not available on the quite new riscv64 architecture and it is not likely to have valgrind soon. Therefore rdma-core shouldn't build-depend on it. Closes: #896150 Thanks: Manuel A. Fernandez Montecelo <mafm@debian.org> Signed-off-by: Benjamin Drung <benjamin.drung@profitbricks.com> --- debian/control | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)