diff mbox

iw_cxgb4: remove duplicate memcpy() in c4iw_create_listen()

Message ID 20180615152823.13031-1-bharat@chelsio.com (mailing list archive)
State Accepted
Delegated to: Jason Gunthorpe
Headers show

Commit Message

Potnuri Bharat Teja June 15, 2018, 3:28 p.m. UTC
memcpy() of mapped addresses is done twice in c4iw_create_listen(),
removing the duplicate memcpy().

Fixes: 170003c894d9 ("iw_cxgb4: remove port mapper related code")

Reviewed-by: Steve Wise <swise@opengridcomputing.com>
Signed-off-by: Potnuri Bharat Teja <bharat@chelsio.com>
---
 drivers/infiniband/hw/cxgb4/cm.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Jason Gunthorpe June 18, 2018, 10:06 p.m. UTC | #1
On Fri, Jun 15, 2018 at 08:58:23PM +0530, Bharat Potnuri wrote:
> memcpy() of mapped addresses is done twice in c4iw_create_listen(),
> removing the duplicate memcpy().
> 
> Fixes: 170003c894d9 ("iw_cxgb4: remove port mapper related code")
> 
> Reviewed-by: Steve Wise <swise@opengridcomputing.com>
> Signed-off-by: Potnuri Bharat Teja <bharat@chelsio.com>

No blank line after fixes.

> ---
>  drivers/infiniband/hw/cxgb4/cm.c | 3 ---
>  1 file changed, 3 deletions(-)

I applied this to for-next, thanks

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c
index 0912fa026327..77243f7e17d5 100644
--- a/drivers/infiniband/hw/cxgb4/cm.c
+++ b/drivers/infiniband/hw/cxgb4/cm.c
@@ -3444,9 +3444,6 @@  int c4iw_create_listen(struct iw_cm_id *cm_id, int backlog)
 	}
 	insert_handle(dev, &dev->stid_idr, ep, ep->stid);
 
-	memcpy(&ep->com.local_addr, &cm_id->m_local_addr,
-	       sizeof(ep->com.local_addr));
-
 	state_set(&ep->com, LISTEN);
 	if (ep->com.local_addr.ss_family == AF_INET)
 		err = create_server4(dev, ep);