| Message ID | 20180711175540.12725-1-kamalheib1@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Jason Gunthorpe |
| Headers | show |
On Wed, Jul 11, 2018 at 08:55:40PM +0300, Kamal Heib wrote: > The rdma core is taking care of return the right error code when > modify_ah() callback isn't supported by the driver provider. > > Fixes: fe2caefcdf58 ('RDMA/ocrdma: Add driver for Emulex OneConnect IBoE RDMA adapter') > Signed-off-by: Kamal Heib <kamalheib1@gmail.com> > --- > drivers/infiniband/hw/ocrdma/ocrdma_ah.c | 6 ------ > drivers/infiniband/hw/ocrdma/ocrdma_ah.h | 1 - > drivers/infiniband/hw/ocrdma/ocrdma_main.c | 1 - > 3 files changed, 8 deletions(-) I would be very happy to see a patch that got all of these pointless functions across all of the drivers. ie 10s of grepping finds this one: pvrdma_modify_cq I know there are many, I keep seeing them.. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> -----Original Message----- > From: linux-rdma-owner@vger.kernel.org [mailto:linux-rdma- > owner@vger.kernel.org] On Behalf Of Kamal Heib > Sent: Wednesday, July 11, 2018 12:56 PM > To: Doug Ledford <dledford@redhat.com>; Jason Gunthorpe <jgg@ziepe.ca> > Cc: linux-rdma@vger.kernel.org; Kamal Heib <kamalheib1@gmail.com> > Subject: [PATCH rdma-next] RDMA/ocrdma: Remove ocrdma_modify_ah() > > The rdma core is taking care of return the right error code when > modify_ah() callback isn't supported by the driver provider. > > Fixes: fe2caefcdf58 ('RDMA/ocrdma: Add driver for Emulex OneConnect IBoE > RDMA adapter') It should be, Fixes: fe2caefcdf58 ("RDMA/ocrdma: Add driver for Emulex OneConnect IBoE RDMA adapter") -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Jul 11, 2018 at 12:08:51PM -0600, Jason Gunthorpe wrote: > On Wed, Jul 11, 2018 at 08:55:40PM +0300, Kamal Heib wrote: > > The rdma core is taking care of return the right error code when > > modify_ah() callback isn't supported by the driver provider. > > > > Fixes: fe2caefcdf58 ('RDMA/ocrdma: Add driver for Emulex OneConnect IBoE RDMA adapter') > > Signed-off-by: Kamal Heib <kamalheib1@gmail.com> > > --- > > drivers/infiniband/hw/ocrdma/ocrdma_ah.c | 6 ------ > > drivers/infiniband/hw/ocrdma/ocrdma_ah.h | 1 - > > drivers/infiniband/hw/ocrdma/ocrdma_main.c | 1 - > > 3 files changed, 8 deletions(-) > > I would be very happy to see a patch that got all of these pointless > functions across all of the drivers. > > ie 10s of grepping finds this one: pvrdma_modify_cq > > I know there are many, I keep seeing them.. > > Jason OK, I see your point. I'll start prepare that patch. Thanks, Kamal -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Jul 11, 2018 at 07:01:29PM +0000, Parav Pandit wrote: > > > > -----Original Message----- > > From: linux-rdma-owner@vger.kernel.org [mailto:linux-rdma- > > owner@vger.kernel.org] On Behalf Of Kamal Heib > > Sent: Wednesday, July 11, 2018 12:56 PM > > To: Doug Ledford <dledford@redhat.com>; Jason Gunthorpe <jgg@ziepe.ca> > > Cc: linux-rdma@vger.kernel.org; Kamal Heib <kamalheib1@gmail.com> > > Subject: [PATCH rdma-next] RDMA/ocrdma: Remove ocrdma_modify_ah() > > > > The rdma core is taking care of return the right error code when > > modify_ah() callback isn't supported by the driver provider. > > > > Fixes: fe2caefcdf58 ('RDMA/ocrdma: Add driver for Emulex OneConnect IBoE > > RDMA adapter') > It should be, > Fixes: fe2caefcdf58 ("RDMA/ocrdma: Add driver for Emulex OneConnect IBoE RDMA adapter") > ACK, I fix my .gitconfig file. Thanks, Kamal -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_ah.c b/drivers/infiniband/hw/ocrdma/ocrdma_ah.c index 8cc9459a9f9b..58188fe5aed2 100644 --- a/drivers/infiniband/hw/ocrdma/ocrdma_ah.c +++ b/drivers/infiniband/hw/ocrdma/ocrdma_ah.c @@ -254,12 +254,6 @@ int ocrdma_query_ah(struct ib_ah *ibah, struct rdma_ah_attr *attr) return 0; } -int ocrdma_modify_ah(struct ib_ah *ibah, struct rdma_ah_attr *attr) -{ - /* modify_ah is unsupported */ - return -ENOSYS; -} - int ocrdma_process_mad(struct ib_device *ibdev, int process_mad_flags, u8 port_num, diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_ah.h b/drivers/infiniband/hw/ocrdma/ocrdma_ah.h index 1a65c47945aa..c0c32c9b80ae 100644 --- a/drivers/infiniband/hw/ocrdma/ocrdma_ah.h +++ b/drivers/infiniband/hw/ocrdma/ocrdma_ah.h @@ -55,7 +55,6 @@ struct ib_ah *ocrdma_create_ah(struct ib_pd *pd, struct rdma_ah_attr *ah_attr, struct ib_udata *udata); int ocrdma_destroy_ah(struct ib_ah *ah); int ocrdma_query_ah(struct ib_ah *ah, struct rdma_ah_attr *ah_attr); -int ocrdma_modify_ah(struct ib_ah *ah, struct rdma_ah_attr *ah_attr); int ocrdma_process_mad(struct ib_device *, int process_mad_flags, diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_main.c b/drivers/infiniband/hw/ocrdma/ocrdma_main.c index 5962c0ed9847..7832ee3e0c84 100644 --- a/drivers/infiniband/hw/ocrdma/ocrdma_main.c +++ b/drivers/infiniband/hw/ocrdma/ocrdma_main.c @@ -176,7 +176,6 @@ static int ocrdma_register_device(struct ocrdma_dev *dev) dev->ibdev.create_ah = ocrdma_create_ah; dev->ibdev.destroy_ah = ocrdma_destroy_ah; dev->ibdev.query_ah = ocrdma_query_ah; - dev->ibdev.modify_ah = ocrdma_modify_ah; dev->ibdev.poll_cq = ocrdma_poll_cq; dev->ibdev.post_send = ocrdma_post_send;
The rdma core is taking care of return the right error code when modify_ah() callback isn't supported by the driver provider. Fixes: fe2caefcdf58 ('RDMA/ocrdma: Add driver for Emulex OneConnect IBoE RDMA adapter') Signed-off-by: Kamal Heib <kamalheib1@gmail.com> --- drivers/infiniband/hw/ocrdma/ocrdma_ah.c | 6 ------ drivers/infiniband/hw/ocrdma/ocrdma_ah.h | 1 - drivers/infiniband/hw/ocrdma/ocrdma_main.c | 1 - 3 files changed, 8 deletions(-)