| Message ID | 20180714232811.9164-2-kamalheib1@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
On Sun, Jul 15, 2018 at 02:28:09AM +0300, Kamal Heib wrote: > {create,destroy}_ah aren't mandatory verbs, because not all providers > are implementing them. It is chicken-egg problem. The "MANDATORY" here means IBTA spec and not implementation mandatory. IMHO or we are removing everything or we are not removing parts. > > Signed-off-by: Kamal Heib <kamalheib1@gmail.com> > --- > drivers/infiniband/core/device.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/infiniband/core/device.c b/drivers/infiniband/core/device.c > index b8144f194777..db3b6271f09d 100644 > --- a/drivers/infiniband/core/device.c > +++ b/drivers/infiniband/core/device.c > @@ -105,8 +105,6 @@ static int ib_device_check_mandatory(struct ib_device *device) > IB_MANDATORY_FUNC(query_pkey), > IB_MANDATORY_FUNC(alloc_pd), > IB_MANDATORY_FUNC(dealloc_pd), > - IB_MANDATORY_FUNC(create_ah), > - IB_MANDATORY_FUNC(destroy_ah), > IB_MANDATORY_FUNC(create_qp), > IB_MANDATORY_FUNC(modify_qp), > IB_MANDATORY_FUNC(destroy_qp), > -- > 2.14.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Jul 24, 2018 at 09:16:00AM +0300, Leon Romanovsky wrote: > On Sun, Jul 15, 2018 at 02:28:09AM +0300, Kamal Heib wrote: > > {create,destroy}_ah aren't mandatory verbs, because not all providers > > are implementing them. > > It is chicken-egg problem. The "MANDATORY" here means IBTA spec and not > implementation mandatory. IMHO or we are removing everything or we are > not removing parts. We are not implementing the IBTA spec when working with iwarp.. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Jul 24, 2018 at 08:29:38AM -0600, Jason Gunthorpe wrote: > On Tue, Jul 24, 2018 at 09:16:00AM +0300, Leon Romanovsky wrote: > > On Sun, Jul 15, 2018 at 02:28:09AM +0300, Kamal Heib wrote: > > > {create,destroy}_ah aren't mandatory verbs, because not all providers > > > are implementing them. > > > > It is chicken-egg problem. The "MANDATORY" here means IBTA spec and not > > implementation mandatory. IMHO or we are removing everything or we are > > not removing parts. > > We are not implementing the IBTA spec when working with iwarp.. I know, this is why I wrote about first option: "removing everything". > > Jason
On Tue, Jul 24, 2018 at 05:32:42PM +0300, Leon Romanovsky wrote: > On Tue, Jul 24, 2018 at 08:29:38AM -0600, Jason Gunthorpe wrote: > > On Tue, Jul 24, 2018 at 09:16:00AM +0300, Leon Romanovsky wrote: > > > On Sun, Jul 15, 2018 at 02:28:09AM +0300, Kamal Heib wrote: > > > > {create,destroy}_ah aren't mandatory verbs, because not all providers > > > > are implementing them. > > > > > > It is chicken-egg problem. The "MANDATORY" here means IBTA spec and not > > > implementation mandatory. IMHO or we are removing everything or we are > > > not removing parts. > > > > We are not implementing the IBTA spec when working with iwarp.. > > I know, this is why I wrote about first option: "removing everything". Okay, I'm fine with that too, please respin.. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/infiniband/core/device.c b/drivers/infiniband/core/device.c index b8144f194777..db3b6271f09d 100644 --- a/drivers/infiniband/core/device.c +++ b/drivers/infiniband/core/device.c @@ -105,8 +105,6 @@ static int ib_device_check_mandatory(struct ib_device *device) IB_MANDATORY_FUNC(query_pkey), IB_MANDATORY_FUNC(alloc_pd), IB_MANDATORY_FUNC(dealloc_pd), - IB_MANDATORY_FUNC(create_ah), - IB_MANDATORY_FUNC(destroy_ah), IB_MANDATORY_FUNC(create_qp), IB_MANDATORY_FUNC(modify_qp), IB_MANDATORY_FUNC(destroy_qp),
{create,destroy}_ah aren't mandatory verbs, because not all providers are implementing them. Signed-off-by: Kamal Heib <kamalheib1@gmail.com> --- drivers/infiniband/core/device.c | 2 -- 1 file changed, 2 deletions(-)