| Message ID | 20181008164403.8060-1-pressmangal@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Jason Gunthorpe |
| Headers | show |
| Series | [rdma-next] RDMA/mlx5: Remove extraneous error check | expand |
> On Oct 8, 2018, at 7:44 PM, Gal Pressman <pressmangal@gmail.com> wrote: > > Remove double error check from create user RQ error flow. > > Fixes: 79b20a6c3014 ("IB/mlx5: Add receive Work Queue verbs") > Signed-off-by: Gal Pressman <pressmangal@gmail.com> Reviewed-by: Majd Dibbiny <majd@mellanox.com> > --- > drivers/infiniband/hw/mlx5/qp.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c > index fa8e5dc65cb4..829aec3aba8f 100644 > --- a/drivers/infiniband/hw/mlx5/qp.c > +++ b/drivers/infiniband/hw/mlx5/qp.c > @@ -5587,8 +5587,7 @@ static int prepare_user_rq(struct ib_pd *pd, > err = create_user_rq(dev, pd, rwq, &ucmd); > if (err) { > mlx5_ib_dbg(dev, "err %d\n", err); > - if (err) > - return err; > + return err; > } > > rwq->user_index = ucmd.user_index; > -- > 2.14.4 >
On Mon, Oct 08, 2018 at 07:44:03PM +0300, Gal Pressman wrote: > Remove double error check from create user RQ error flow. > > Fixes: 79b20a6c3014 ("IB/mlx5: Add receive Work Queue verbs") > Signed-off-by: Gal Pressman <pressmangal@gmail.com> > Reviewed-by: Majd Dibbiny <majd@mellanox.com> > --- > drivers/infiniband/hw/mlx5/qp.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Applied to for-next, thanks Jason
diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c index fa8e5dc65cb4..829aec3aba8f 100644 --- a/drivers/infiniband/hw/mlx5/qp.c +++ b/drivers/infiniband/hw/mlx5/qp.c @@ -5587,8 +5587,7 @@ static int prepare_user_rq(struct ib_pd *pd, err = create_user_rq(dev, pd, rwq, &ucmd); if (err) { mlx5_ib_dbg(dev, "err %d\n", err); - if (err) - return err; + return err; } rwq->user_index = ucmd.user_index;
Remove double error check from create user RQ error flow. Fixes: 79b20a6c3014 ("IB/mlx5: Add receive Work Queue verbs") Signed-off-by: Gal Pressman <pressmangal@gmail.com> --- drivers/infiniband/hw/mlx5/qp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)